Doug Berger 20d1f2d1b0 net: bcmgenet: use hardware padding of runt frames ... When commit 474ea9cafc ("net: bcmgenet: correctly pad short packets") added the call to skb_padto() it should have been located before the nr_frags parameter was read since that value could be changed when padding packets with lengths between 55 and 59 bytes (inclusive). The use of a stale nr_frags value can cause corruption of the pad data when tx-scatter-gather is enabled. This corruption of the pad can cause invalid checksum computation when hardware offload of tx-checksum is also enabled. Since the original reason for the padding was corrected by commit 7dd399130e ("net: bcmgenet: fix skb_len in bcmgenet_xmit_single()") we can remove the software padding all together and make use of hardware padding of short frames as long as the hardware also always appends the FCS value to the frame. Fixes: 474ea9cafc ("net: bcmgenet: correctly pad short packets") Signed-off-by: Doug Berger <opendmb@gmail.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2020-06-24 21:51:03 -07:00
..
bcmgenet_wol.c	net: bcmgenet: Move wake-up event out of side band ISR	2020-05-01 15:54:33 -07:00
bcmgenet.c	net: bcmgenet: use hardware padding of runt frames	2020-06-24 21:51:03 -07:00
bcmgenet.h	net: bcmgenet: Move wake-up event out of side band ISR	2020-05-01 15:54:33 -07:00
bcmmii.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-03-25 18:58:11 -07:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00