2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-21 11:44:01 +08:00
linux-next/drivers/media/i2c/soc_camera
Akinobu Mita 22216ec41e media: soc_camera: ov772x: correct setting of banding filter
The banding filter ON/OFF is controlled via bit 5 of COM8 register.  It
is attempted to be enabled in ov772x_set_params() by the following line.

	ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, 1);

But this unexpectedly results disabling the banding filter, because the
mask and set bits are exclusive.

On the other hand, ov772x_s_ctrl() correctly sets the bit by:

	ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, BNDF_ON_OFF);

The same fix was already applied to non-soc_camera version of ov772x
driver in the commit commit a024ee14cd ("media: ov772x: correct setting
of banding filter")

Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
2018-06-28 09:22:57 -04:00
..
Kconfig media: mt9t031: deprecate, move to staging 2018-02-23 02:31:38 -05:00
Makefile media: mt9t031: deprecate, move to staging 2018-02-23 02:31:38 -05:00
mt9m001.c [media] mt9m001: avoid calling mt9m001_find_datafmt() twice 2017-04-14 22:29:13 -03:00
mt9t112.c media: i2c: mt9t112: Remove soc_camera dependencies 2018-03-21 15:29:07 -04:00
mt9v022.c [media] mt9v022: avoid calling mt9v022_find_datafmt() twice 2017-04-14 22:29:57 -03:00
ov772x.c media: soc_camera: ov772x: correct setting of banding filter 2018-06-28 09:22:57 -04:00
ov5642.c [media] ov5642: avoid calling ov5642_find_datafmt() twice 2017-04-14 22:30:21 -03:00
ov9640.c [media] i2c: Improve a size determination 2017-10-04 17:15:39 -03:00
ov9640.h [media] soc-camera: switch I2C subdevice drivers to use v4l2-clk 2013-06-21 16:32:36 -03:00
ov9740.c [media] i2c: Improve a size determination 2017-10-04 17:15:39 -03:00
rj54n1cb0c.c [media] media: i2c: soc_camera: constify v4l2_subdev_* structures 2017-03-23 14:43:49 -03:00
tw9910.c [media] media: i2c: soc_camera: constify v4l2_subdev_* structures 2017-03-23 14:43:49 -03:00