2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-25 21:54:06 +08:00
linux-next/arch/um/drivers
André Goddard Rosa e7d2860b69 tree-wide: convert open calls to remove spaces to skip_spaces() lib function
Makes use of skip_spaces() defined in lib/string.c for removing leading
spaces from strings all over the tree.

It decreases lib.a code size by 47 bytes and reuses the function tree-wide:
   text    data     bss     dec     hex filename
  64688     584     592   65864   10148 (TOTALS-BEFORE)
  64641     584     592   65817   10119 (TOTALS-AFTER)

Also, while at it, if we see (*str && isspace(*str)), we can be sure to
remove the first condition (*str) as the second one (isspace(*str)) also
evaluates to 0 whenever *str == 0, making it redundant. In other words,
"a char equals zero is never a space".

Julia Lawall tried the semantic patch (http://coccinelle.lip6.fr) below,
and found occurrences of this pattern on 3 more files:
    drivers/leds/led-class.c
    drivers/leds/ledtrig-timer.c
    drivers/video/output.c

@@
expression str;
@@

( // ignore skip_spaces cases
while (*str &&  isspace(*str)) { \(str++;\|++str;\) }
|
- *str &&
isspace(*str)
)

Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com>
Cc: Julia Lawall <julia@diku.dk>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Neil Brown <neilb@suse.de>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: David Howells <dhowells@redhat.com>
Cc: <linux-ext4@vger.kernel.org>
Cc: Samuel Ortiz <samuel@sortiz.org>
Cc: Patrick McHardy <kaber@trash.net>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-12-15 08:53:32 -08:00
..
chan_kern.c uml: remove a useless function 2008-04-28 08:58:28 -07:00
chan_user.c uml: fix build when SLOB is enabled 2008-05-13 08:02:22 -07:00
cow_sys.h uml: fix build when SLOB is enabled 2008-05-13 08:02:22 -07:00
cow_user.c uml: arch/um/drivers formatting 2007-10-16 09:43:09 -07:00
cow.h [PATCH] uml: avoid warnings for diffent names for an unsigned quadword 2006-04-11 06:18:37 -07:00
daemon_kern.c um: Kill directly reference of netdev->priv 2008-12-04 15:07:33 -08:00
daemon_user.c uml: fix build when SLOB is enabled 2008-05-13 08:02:22 -07:00
daemon.h uml: network formatting 2007-10-16 09:43:08 -07:00
fd.c uml: fix build when SLOB is enabled 2008-05-13 08:02:22 -07:00
harddog_kern.c uml-harddog: BKL pushdown 2008-07-02 15:06:26 -06:00
harddog_user.c uml: fix helper_wait calls in watchdog 2008-02-23 17:12:15 -08:00
hostaudio_kern.c uml: fix errno return 2008-05-13 08:02:21 -07:00
line.c headers: remove sched.h from interrupt.h 2009-10-11 11:20:58 -07:00
Makefile x86, um: get rid of arch/um/os symlink 2008-10-22 22:55:22 -07:00
mcast_kern.c um: Kill directly reference of netdev->priv 2008-12-04 15:07:33 -08:00
mcast_user.c uml: fix build when SLOB is enabled 2008-05-13 08:02:22 -07:00
mcast.h uml: network formatting 2007-10-16 09:43:08 -07:00
mconsole_kern.c tree-wide: convert open calls to remove spaces to skip_spaces() lib function 2009-12-15 08:53:32 -08:00
mconsole_user.c uml: make three functions static 2008-04-28 08:58:28 -07:00
mmapper_kern.c um: Remove BKL from mmapper 2009-10-14 15:35:51 +02:00
net_kern.c trivial: remove unnecessary semicolons 2009-09-21 15:14:58 +02:00
net_user.c uml: fix build when SLOB is enabled 2008-05-13 08:02:22 -07:00
null.c spelling fixes: arch/um/ 2007-10-20 01:23:03 +02:00
pcap_kern.c um: Kill directly reference of netdev->priv 2008-12-04 15:07:33 -08:00
pcap_user.c missed kmalloc() in pcap_user.c 2008-05-21 16:55:57 -07:00
pcap_user.h uml: remove useless comments 2009-04-01 08:59:17 -07:00
port_kern.c headers: remove sched.h from interrupt.h 2009-10-11 11:20:58 -07:00
port_user.c uml: fix build when SLOB is enabled 2008-05-13 08:02:22 -07:00
port.h uml: remove useless comments 2009-04-01 08:59:17 -07:00
pty.c uml: fix build when SLOB is enabled 2008-05-13 08:02:22 -07:00
random.c um: Remove BKL from random 2009-10-14 15:35:51 +02:00
slip_common.c [PATCH] uml: slirp and slip driver cleanups and fixes 2005-06-13 20:58:43 -07:00
slip_common.h [PATCH] uml: fix hugest stack users 2006-02-01 08:53:22 -08:00
slip_kern.c UML: Fix some apparent bitrot 2009-06-25 11:22:13 -07:00
slip_user.c uml: fix build when SLOB is enabled 2008-05-13 08:02:22 -07:00
slip.h [PATCH] uml: const more data 2006-09-27 08:26:15 -07:00
slirp_kern.c UML: Fix some apparent bitrot 2009-06-25 11:22:13 -07:00
slirp_user.c uml: tidy helper code 2008-02-05 09:44:30 -08:00
slirp.h [PATCH] uml: const more data 2006-09-27 08:26:15 -07:00
ssl.c uml: tidy kern_util.h 2008-02-05 09:44:26 -08:00
ssl.h uml: remove useless comments 2009-04-01 08:59:17 -07:00
stderr_console.c spelling fixes: arch/um/ 2007-10-20 01:23:03 +02:00
stdio_console.c uml: make several things static 2008-04-28 08:58:28 -07:00
stdio_console.h uml: remove useless comments 2009-04-01 08:59:17 -07:00
tty.c uml: fix build when SLOB is enabled 2008-05-13 08:02:22 -07:00
ubd_kern.c uml: convert to seq_file/proc_fops 2009-12-15 08:53:25 -08:00
ubd_user.c uml: tidy kern_util.h 2008-02-05 09:44:26 -08:00
vde_kern.c um: Kill directly reference of netdev->priv 2008-12-04 15:07:33 -08:00
vde_user.c uml: fix vde network backend in user mode linux 2009-02-20 17:57:48 -08:00
vde.h uml: add VDE networking support 2007-10-16 09:43:05 -07:00
xterm_kern.c uml: xterm driver tidying 2007-07-16 09:05:38 -07:00
xterm.c uml: fix build when SLOB is enabled 2008-05-13 08:02:22 -07:00
xterm.h uml: remove useless comments 2009-04-01 08:59:17 -07:00