Jerry Zhang 4d644abf25 usb: gadget: f_fs: Only return delayed status when len is 0 ... Commit 1b9ba000 ("Allow function drivers to pause control transfers") states that USB_GADGET_DELAYED_STATUS is only supported if data phase is 0 bytes. It seems that when the length is not 0 bytes, there is no need to explicitly delay the data stage since the transfer is not completed until the user responds. However, when the length is 0, there is no data stage and the transfer is finished once setup() returns, hence there is a need to explicitly delay completion. This manifests as the following bugs: Prior to 946ef68ad4 ('Let setup() return USB_GADGET_DELAYED_STATUS'), when setup is 0 bytes, ffs would require user to queue a 0 byte request in order to clear setup state. However, that 0 byte request was actually not needed and would hang and cause errors in other setup requests. After the above commit, 0 byte setups work since the gadget now accepts empty queues to ep0 to clear the delay, but all other setups hang. Fixes: 946ef68ad4 ("Let setup() return USB_GADGET_DELAYED_STATUS") Signed-off-by: Jerry Zhang <zhangjerry@google.com> Cc: stable <stable@vger.kernel.org> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-07-20 16:02:49 +02:00
..
function	usb: gadget: f_fs: Only return delayed status when len is 0	2018-07-20 16:02:49 +02:00
legacy	USB/PHY patches for 4.17-rc1	2018-04-04 17:55:35 -07:00
udc	usb: gadget: aspeed: Workaround memory ordering issue	2018-07-17 10:12:51 +03:00
composite.c	usb: gadget: Fix OS descriptors support	2018-07-17 10:12:51 +03:00
config.c	USB: gadget: Remove redundant license text	2017-11-07 15:45:02 +01:00
configfs.c	A couple of configfs cleanups:	2017-11-14 14:44:04 -08:00
configfs.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
epautoconf.c	USB: gadget: Remove redundant license text	2017-11-07 15:45:02 +01:00
functions.c	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
Kconfig	Revert "usb: gadget: allow to enable legacy drivers without USB_ETH"	2017-12-12 12:48:30 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
u_f.c	USB: gadget: Remove redundant license text	2017-11-07 15:45:02 +01:00
u_f.h	USB: gadget: f_midi: fixing a possible double-free in f_midi	2018-03-26 11:53:14 +02:00
u_os_desc.h	USB: gadget: Remove redundant license text	2017-11-07 15:45:02 +01:00
usbstring.c	usb/gadget: Constify usb_gadget_get_string "table" argument	2018-05-15 10:06:49 +03:00