Dave Chinner 1e82379b01 xfs: xfs_bmap_add_attrfork_local is too generic ... When we are converting local data to an extent format as a result of adding an attribute, the type of data contained in the local fork determines the behaviour that needs to occur. xfs_bmap_add_attrfork_local() already handles the directory data case specially by using S_ISDIR() and calling out to xfs_dir2_sf_to_block(), but with verifiers we now need to handle each different type of metadata specially and different metadata formats require different verifiers (and eventually block header initialisation). There is only a single place that we add and attribute fork to the inode, but that is in the attribute code and it knows nothing about the specific contents of the data fork. It is only the case of local data that is the issue here, so adding code to hadnle this case in the attribute specific code is wrong. Hence we are really stuck trying to detect the data fork contents in xfs_bmap_add_attrfork_local() and performing the correct callout there. Luckily the current cases can be determined by S_IS* macros, and we can push the work off to data specific callouts, but each of those callouts does a lot of work in common with xfs_bmap_local_to_extents(). The only reason that this fails for symlinks right now is is that xfs_bmap_local_to_extents() assumes the data fork contains extent data, and so attaches a a bmap extent data verifier to the buffer and simply copies the data fork information straight into it. To fix this, allow us to pass a "formatting" callback into xfs_bmap_local_to_extents() which is responsible for setting the buffer type, initialising it and copying the data fork contents over to the new buffer. This allows callers to specify how they want to format the new buffer (which is necessary for the upcoming CRC enabled metadata blocks) and hence make xfs_bmap_local_to_extents() useful for any type of data fork content. Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Mark Tinguely <tinguely@sgi.com> Signed-off-by: Ben Myers <bpm@sgi.com>		2013-02-14 17:35:51 -06:00
..
Kconfig	xfs: add CRC infrastructure	2012-11-19 20:11:24 -06:00
kmem.c	xfs: switch to proper __bitwise type for KM_... flags	2012-05-29 23:28:32 -04:00
kmem.h	xfs: switch to proper __bitwise type for KM_... flags	2012-05-29 23:28:32 -04:00
Makefile	xfs: remove xfs_flushinval_pages	2012-11-14 15:15:08 -06:00
mrlock.h	xfs: remove subdirectories	2011-08-12 16:21:35 -05:00
time.h	xfs: remove subdirectories	2011-08-12 16:21:35 -05:00
uuid.c	xfs: remove subdirectories	2011-08-12 16:21:35 -05:00
uuid.h	xfs: add CRC infrastructure	2012-11-19 20:11:24 -06:00
xfs_acl.c	userns: Pass a userns parameter into posix_acl_to_xattr and posix_acl_from_xattr	2012-09-18 01:01:35 -07:00
xfs_acl.h	xfs: Fix build breakage in xfs_iops.c when CONFIG_FS_POSIX_ACL is not set	2011-08-01 02:35:04 -04:00
xfs_ag.h	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_alloc_btree.c	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_alloc_btree.h	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_alloc.c	xfs: don't zero structure members after a memset(0)	2013-01-03 16:00:07 -06:00
xfs_alloc.h	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_aops.c	xfs: Fix possible use-after-free with AIO	2013-01-26 09:43:58 -06:00
xfs_aops.h	Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision.	2012-07-22 11:00:55 -05:00
xfs_attr_leaf.c	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_attr_leaf.h	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_attr_sf.h
xfs_attr.c	xfs: refactor space log reservation for XFS_TRANS_ATTR_SET	2013-02-01 14:56:31 -06:00
xfs_attr.h
xfs_bit.c
xfs_bit.h
xfs_bmap_btree.c	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_bmap_btree.h	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_bmap.c	xfs: xfs_bmap_add_attrfork_local is too generic	2013-02-14 17:35:51 -06:00
xfs_bmap.h	xfs: move allocation stack switch up to xfs_bmapi_allocate	2012-10-18 17:42:48 -05:00
xfs_btree.c	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_btree.h	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_buf_item.c	xfs: recheck buffer pinned status after push trylock failure	2013-02-14 17:23:42 -06:00
xfs_buf_item.h	xfs remove the XFS_TRANS_DEBUG routines	2012-12-17 16:29:00 -06:00
xfs_buf.c	xfs: remove log force from xfs_buf_trylock()	2013-02-14 17:24:53 -06:00
xfs_buf.h	xfs: use b_maps[] for discontiguous buffers	2012-12-17 16:19:56 -06:00
xfs_cksum.h	xfs: add CRC infrastructure	2012-11-19 20:11:24 -06:00
xfs_da_btree.c	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_da_btree.h	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_dfrag.c	xfs: Fix xfs_swap_extents() after removal of xfs_flushinval_pages()	2013-01-28 13:50:10 -06:00
xfs_dfrag.h
xfs_dinode.h	xfs: fix typo in comment of xfs_dinode_t.	2012-06-14 12:28:26 -05:00
xfs_dir2_block.c	xfs: recalculate leaf entry pointer after compacting a dir2 block	2013-01-13 14:36:17 -06:00
xfs_dir2_data.c	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_dir2_format.h	xfs: cleanup struct xfs_dir2_free	2011-07-13 13:43:48 +02:00
xfs_dir2_leaf.c	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_dir2_node.c	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_dir2_priv.h	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_dir2_sf.c	xfs: remove struct xfs_dabuf and infrastructure	2012-07-01 14:50:07 -05:00
xfs_dir2.c	xfs: remove struct xfs_dabuf and infrastructure	2012-07-01 14:50:07 -05:00
xfs_dir2.h	xfs: reshuffle dir2 headers	2011-07-13 13:43:48 +02:00
xfs_discard.c	xfs: check for possible overflow in xfs_ioc_trim	2012-08-23 14:48:44 -05:00
xfs_discard.h	xfs: remove subdirectories	2011-08-12 16:21:35 -05:00
xfs_dquot_item.c	xfs: clean up xfs_bit.h includes	2012-05-14 16:21:00 -05:00
xfs_dquot_item.h	xfs: remove subdirectories	2011-08-12 16:21:35 -05:00
xfs_dquot.c	xfs: calculate XFS_TRANS_QM_DQALLOC space log reservation at mount time	2013-02-01 14:43:51 -06:00
xfs_dquot.h	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_error.c	xfs: move xfsagino_t to xfs_types.h	2012-05-14 16:20:54 -05:00
xfs_error.h	xfs: kill support/debug.[ch]	2011-03-07 10:09:35 +11:00
xfs_export.c	xfs: remove xfs_iget.c	2012-10-17 13:42:25 -05:00
xfs_export.h	xfs: remove subdirectories	2011-08-12 16:21:35 -05:00
xfs_extent_busy.c	xfs: make xfs_extent_busy_trim not static	2012-05-14 16:21:04 -05:00
xfs_extent_busy.h	xfs: make xfs_extent_busy_trim not static	2012-05-14 16:21:04 -05:00
xfs_extfree_item.c	xfs: move xfsagino_t to xfs_types.h	2012-05-14 16:20:54 -05:00
xfs_extfree_item.h
xfs_file.c	xfs: byte range granularity for XFS_IOC_ZERO_RANGE	2012-11-29 14:21:46 -06:00
xfs_filestream.c	xfs: rename allocation range fields in struct xfs_bmalloca	2011-10-11 21:15:06 -05:00
xfs_filestream.h
xfs_fs.h	xfs: add minimum file size filtering to eofblocks scan	2012-11-08 15:32:29 -06:00
xfs_fsops.c	xfs: make use of XFS_SB_LOG_RES() at xfs_fs_log_dummy()	2013-02-01 14:55:59 -06:00
xfs_fsops.h	xfs: ensure log covering transactions are synchronous	2011-01-11 20:28:17 -06:00
xfs_globals.c	xfs: add background scanning to clear eofblocks inodes	2012-11-08 15:34:59 -06:00
xfs_ialloc_btree.c	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_ialloc_btree.h	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_ialloc.c	xfs: don't zero structure members after a memset(0)	2013-01-03 16:00:07 -06:00
xfs_ialloc.h	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_icache.c	xfs: add background scanning to clear eofblocks inodes	2012-11-08 15:34:59 -06:00
xfs_icache.h	xfs: add background scanning to clear eofblocks inodes	2012-11-08 15:34:59 -06:00
xfs_inode_item.c	xfs remove the XFS_TRANS_DEBUG routines	2012-12-17 16:29:00 -06:00
xfs_inode_item.h	xfs remove the XFS_TRANS_DEBUG routines	2012-12-17 16:29:00 -06:00
xfs_inode.c	xfs remove the XFS_TRANS_DEBUG routines	2012-12-17 16:29:00 -06:00
xfs_inode.h	xfs: memory barrier before wake_up_bit()	2013-02-07 09:39:48 -06:00
xfs_inum.h	xfs: move xfsagino_t to xfs_types.h	2012-05-14 16:20:54 -05:00
xfs_ioctl32.c	xfs: Convert to new freezing code	2012-07-31 09:45:48 +04:00
xfs_ioctl32.h	xfs: remove subdirectories	2011-08-12 16:21:35 -05:00
xfs_ioctl.c	xfs: add inode id filtering to eofblocks scan	2012-11-08 15:29:14 -06:00
xfs_ioctl.h	xfs: remove subdirectories	2011-08-12 16:21:35 -05:00
xfs_iomap.c	xfs: limit speculative prealloc size on sparse files	2013-02-14 17:21:32 -06:00
xfs_iomap.h
xfs_iops.c	xfs: remove xfs_flush_pages	2012-11-14 15:12:45 -06:00
xfs_iops.h	xfs: remove subdirectories	2011-08-12 16:21:35 -05:00
xfs_itable.c	xfs: convert buffer verifiers to an ops structure.	2012-11-15 21:35:12 -06:00
xfs_itable.h
xfs_linux.h	xfs: add CRC infrastructure	2012-11-19 20:11:24 -06:00
xfs_log_cil.c	xfs: rename log structure to xlog	2012-06-21 14:21:11 -05:00
xfs_log_priv.h	xfs: fix sparse reported log CRC endian issue	2012-12-03 12:10:59 -06:00
xfs_log_recover.c	xfs: fix sparse reported log CRC endian issue	2012-12-03 12:10:59 -06:00
xfs_log_recover.h
xfs_log.c	xfs: fix fs/xfs/xfs_log.c:1740:39: error: 'B_TRUE' undeclared	2013-01-18 15:11:57 -06:00
xfs_log.h	xfs: xfs_quiesce_attr() should quiesce the log like unmount	2012-10-17 13:39:14 -05:00
xfs_message.c	xfs: move xfsagino_t to xfs_types.h	2012-05-14 16:20:54 -05:00
xfs_message.h	treewide: use __printf not __attribute__((format(printf,...)))	2011-10-31 17:30:54 -07:00
xfs_mount.c	xfs: make use of XFS_SB_LOG_RES() at xfs_mount_log_sb()	2013-02-01 14:55:08 -06:00
xfs_mount.h	xfs: refactor space log reservation for XFS_TRANS_ATTR_SET	2013-02-01 14:56:31 -06:00
xfs_mru_cache.c	xfs: convert to alloc_workqueue()	2011-02-01 11:42:43 +01:00
xfs_mru_cache.h
xfs_qm_bhv.c	xfs: Remove boolean_t typedef completely.	2013-01-17 17:32:57 -06:00
xfs_qm_syscalls.c	xfs: calculate XFS_TRANS_QM_QUOTAOFF_END space log reservation at mount time	2013-02-01 14:45:50 -06:00
xfs_qm.c	xfs: calculate xfs_qm_write_sb_changes() space log reservation at mount time	2013-02-01 14:42:32 -06:00
xfs_qm.h	xfs: remove the global xfs_Gqm structure	2012-03-14 12:06:32 -05:00
xfs_quota_priv.h	xfs: use per-filesystem radix trees for dquot lookup	2012-03-14 11:09:06 -05:00
xfs_quota.h	Define new macro XFS_ALL_QUOTA_ACTIVE and simply some usage	2012-02-03 11:32:20 -06:00
xfs_quotaops.c	userns: Convert qutoactl	2012-09-18 01:01:39 -07:00
xfs_rename.c	xfs: move xfsagino_t to xfs_types.h	2012-05-14 16:20:54 -05:00
xfs_rtalloc.c	xfs: uncached buffer reads need to return an error	2012-11-15 21:34:05 -06:00
xfs_rtalloc.h	xfs: Remove the macro XFS_BUF_PTR	2011-07-25 15:03:13 -05:00
xfs_sb.h	xfs: add CRC infrastructure	2012-11-19 20:11:24 -06:00
xfs_stats.c	xfs: use common code for quota statistics	2012-03-14 11:09:06 -05:00
xfs_stats.h	xfs: use common code for quota statistics	2012-03-14 11:09:06 -05:00
xfs_super.c	fs/xfs remove obsolete simple_strto<foo>	2013-01-13 14:42:07 -06:00
xfs_super.h	xfs: xfs_sync_data is redundant.	2012-10-17 12:01:25 -05:00
xfs_sysctl.c	xfs: add background scanning to clear eofblocks inodes	2012-11-08 15:34:59 -06:00
xfs_sysctl.h	xfs: add background scanning to clear eofblocks inodes	2012-11-08 15:34:59 -06:00
xfs_trace.c	xfs: clean up xfs_bit.h includes	2012-05-14 16:21:00 -05:00
xfs_trace.h	xfs: fix shutdown hang on invalid inode during create	2013-01-26 09:34:38 -06:00
xfs_trans_ail.c	xfs remove the XFS_TRANS_DEBUG routines	2012-12-17 16:29:00 -06:00
xfs_trans_buf.c	xfs: fix the multi-segment log buffer format	2012-12-17 16:28:14 -06:00
xfs_trans_dquot.c	xfs: Remove boolean_t typedef completely.	2013-01-17 17:32:57 -06:00
xfs_trans_extfree.c	xfs: move xfsagino_t to xfs_types.h	2012-05-14 16:20:54 -05:00
xfs_trans_inode.c	xfs remove the XFS_TRANS_DEBUG routines	2012-12-17 16:29:00 -06:00
xfs_trans_priv.h	xfs: re-enable xfsaild idle mode and fix associated races	2012-07-29 16:27:57 -05:00
xfs_trans_space.h
xfs_trans.c	xfs: refactor space log reservation for XFS_TRANS_ATTR_SET	2013-02-01 14:56:31 -06:00
xfs_trans.h	xfs: refactor space log reservation for XFS_TRANS_ATTR_SET	2013-02-01 14:56:31 -06:00
xfs_types.h	xfs: Remove boolean_t typedef completely.	2013-01-17 17:32:57 -06:00
xfs_utils.c	xfs: remove the alloc_done argument to xfs_dialloc	2012-07-29 16:00:31 -05:00
xfs_utils.h	xfs: propagate umode_t	2012-01-03 22:55:00 -05:00
xfs_vnode.h	xfs: remove remaining scraps of struct xfs_iomap	2012-03-15 13:40:16 -05:00
xfs_vnodeops.c	xfs: Remove boolean_t typedef completely.	2013-01-17 17:32:57 -06:00
xfs_vnodeops.h	xfs: byte range granularity for XFS_IOC_ZERO_RANGE	2012-11-29 14:21:46 -06:00
xfs_xattr.c	xfs: remove subdirectories	2011-08-12 16:21:35 -05:00
xfs.h	xfs: don't expect xfs headers to be in subdirectories	2011-08-12 13:57:55 -05:00