renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-25 21:54:06 +08:00
Code
2fa4a32613
linux-next/drivers/scsi/libsas
History
Jason Yan 2fa4a32613 scsi: libsas: dynamically allocate and free ata host 
Commit 2623c7a5f2 ("libata: add refcounting to ata_host") v4.17+ introduced
refcounting to ata_host and will increase or decrease the refcount when
adding or deleting transport ATA port.

Now the ata host for libsas is embedded in domain_device, and the ->kref
member is not initialized. Afer we add ata transport class, ata_host_get()
will be called when adding transport ATA port and a warning will be
triggered as below:

refcount_t: increment on 0; use-after-free.
WARNING: CPU: 2 PID: 103 at
lib/refcount.c:153 refcount_inc+0x40/0x48 ......  Call trace:
 refcount_inc+0x40/0x48
 ata_host_get+0x10/0x18
 ata_tport_add+0x40/0x120
 ata_sas_tport_add+0xc/0x14
 sas_ata_init+0x7c/0xc8
 sas_discover_domain+0x380/0x53c
 process_one_work+0x12c/0x288
 worker_thread+0x58/0x3f0
 kthread+0xfc/0x128
 ret_from_fork+0x10/0x18

And also when removing transport ATA port ata_host_put() will be called and
another similar warning will be triggered. If the refcount decreased to
zero, the ata host will be freed. But this ata host is only part of
domain_device, it cannot be freed directly.

So we have to change this embedded static ata host to a dynamically
allocated ata host and initialize the ->kref member. To use ata_host_get()
and ata_host_put() in libsas, we need to move the declaration of these
functions to the public libata.h and export them.

Fixes: b6240a4df0 ("scsi: libsas: add transport class for ATA devices")
Signed-off-by: Jason Yan <yanaijie@huawei.com>
CC: John Garry <john.garry@huawei.com>
CC: Taras Kondratiuk <takondra@cisco.com>
CC: Tejun Heo <tj@kernel.org>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-06-19 22:02:25 -04:00
..
Kconfig scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough 2017-08-29 21:51:45 -04:00
Makefile Merge branch 'trivial' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6 2011-03-20 18:14:55 -07:00
sas_ata.c scsi: libsas: dynamically allocate and free ata host 2018-06-19 22:02:25 -04:00
sas_discover.c scsi: libsas: dynamically allocate and free ata host 2018-06-19 22:02:25 -04:00
sas_dump.c scsi: libsas: kill useless ha_event and do some cleanup 2017-09-15 21:32:58 -04:00
sas_dump.h scsi: libsas: kill useless ha_event and do some cleanup 2017-09-15 21:32:58 -04:00
sas_event.c scsi: libsas: notify event PORTE_BROADCAST_RCVD in sas_enable_revalidation() 2018-01-10 23:24:54 -05:00
sas_expander.c treewide: kzalloc() -> kcalloc() 2018-06-12 16:19:22 -07:00
sas_host_smp.c scsi: scsi_transport_sas: switch to bsg-lib for SMP passthrough 2017-08-29 21:51:45 -04:00
sas_init.c scsi: libsas: Fix kernel-doc headers 2018-02-27 21:15:16 -05:00
sas_internal.h scsi: libsas: direct call probe and destruct 2018-01-10 23:24:02 -05:00
sas_phy.c scsi: libsas: shut down the PHY if events reached the threshold 2018-01-08 21:59:28 -05:00
sas_port.c scsi: libsas: Fix kernel-doc headers 2018-02-27 21:15:16 -05:00
sas_scsi_host.c Merge branch 'fixes' into misc 2018-04-03 17:38:39 -07:00
sas_task.c scsi: Add export.h for EXPORT_SYMBOL/THIS_MODULE as required 2011-10-31 19:31:23 -04:00