Hugh Dickins 2e7842b887 [PATCH] fix umask when noACL kernel meets extN tuned for ACLs ... Fix insecure default behaviour reported by Tigran Aivazian: if an ext2 or ext3 or ext4 filesystem is tuned to mount with "acl", but mounted by a kernel built without ACL support, then umask was ignored when creating inodes - though root or user has umask 022, touch creates files as 0666, and mkdir creates directories as 0777. This appears to have worked right until 2.6.11, when a fix to the default mode on symlinks (always 0777) assumed VFS applies umask: which it does, unless the mount is marked for ACLs; but ext[234] set MS_POSIXACL in s_flags according to s_mount_opt set according to def_mount_opts. We could revert to the 2.6.10 ext[234]_init_acl (adding an S_ISLNK test); but other filesystems only set MS_POSIXACL when ACLs are configured. We could fix this at another level; but it seems most robust to avoid setting the s_mount_opt flag in the first place (at the expense of more ifdefs). Likewise don't set the XATTR_USER flag when built without XATTR support. Signed-off-by: Hugh Dickins <hugh@veritas.com> Cc: Tigran Aivazian <tigran@aivazian.fsnet.co.uk> Cc: <linux-ext4@vger.kernel.org> Cc: Andreas Gruenbacher <agruen@suse.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2007-02-11 10:51:34 -08:00
..
acl.c	[PATCH] ext4 whitespace cleanups	2006-10-11 11:14:19 -07:00
acl.h	[PATCH] ext4: rename ext4 symbols to avoid duplication of ext3 symbols	2006-10-11 11:14:15 -07:00
balloc.c	[PATCH] ext4 balloc: fix _with_rsv freeze	2006-12-07 08:39:43 -08:00
bitmap.c	[PATCH] jbd2: enable building of jbd2 and have ext4 use it rather than jbd	2006-10-11 11:14:16 -07:00
dir.c	[PATCH] ext4: change uses of f_{dentry, vfsmnt} to use f_path	2006-12-08 08:28:41 -08:00
ext4_jbd2.c	[PATCH] ext4: uninline large functions	2006-12-07 08:39:35 -08:00
extents.c	[PATCH] ext4: Eliminate inline functions	2006-12-07 08:39:48 -08:00
file.c	[PATCH] ext4: change uses of f_{dentry, vfsmnt} to use f_path	2006-12-08 08:28:41 -08:00
fsync.c	[PATCH] jbd2: enable building of jbd2 and have ext4 use it rather than jbd	2006-10-11 11:14:16 -07:00
hash.c	[PATCH] jbd2: enable building of jbd2 and have ext4 use it rather than jbd	2006-10-11 11:14:16 -07:00
ialloc.c	[PATCH] ext4 64 bit divide fix	2006-10-11 11:14:18 -07:00
inode.c	[PATCH] ext4 calls journal_stop	2006-12-08 08:28:37 -08:00
ioctl.c	[PATCH] ext4: change uses of f_{dentry, vfsmnt} to use f_path	2006-12-08 08:28:41 -08:00
Makefile	[PATCH] ext4: uninline large functions	2006-12-07 08:39:35 -08:00
namei.c	[PATCH] ext4: change uses of f_{dentry, vfsmnt} to use f_path	2006-12-08 08:28:41 -08:00
namei.h	[PATCH] ext4: rename ext4 symbols to avoid duplication of ext3 symbols	2006-10-11 11:14:15 -07:00
resize.c	[PATCH] ext4: fix printk format warnings	2006-10-28 11:30:51 -07:00
super.c	[PATCH] fix umask when noACL kernel meets extN tuned for ACLs	2007-02-11 10:51:34 -08:00
symlink.c	[PATCH] jbd2: enable building of jbd2 and have ext4 use it rather than jbd	2006-10-11 11:14:16 -07:00
xattr_security.c	[PATCH] jbd2: enable building of jbd2 and have ext4 use it rather than jbd	2006-10-11 11:14:16 -07:00
xattr_trusted.c	[PATCH] jbd2: enable building of jbd2 and have ext4 use it rather than jbd	2006-10-11 11:14:16 -07:00
xattr_user.c	[PATCH] jbd2: enable building of jbd2 and have ext4 use it rather than jbd	2006-10-11 11:14:16 -07:00
xattr.c	[PATCH] Remove superfluous lock_super() in extN xattr code	2006-12-07 08:39:32 -08:00
xattr.h	[PATCH] ext4: rename ext4 symbols to avoid duplication of ext3 symbols	2006-10-11 11:14:15 -07:00