Eric Dumazet 1f85e6267c tcp: do not send empty skb from tcp_write_xmit() ... Backport of commit fdfc5c8594 ("tcp: remove empty skb from write queue in error cases") in linux-4.14 stable triggered various bugs. One of them has been fixed in commit ba2ddb43f270 ("tcp: Don't dequeue SYN/FIN-segments from write-queue"), but we still have crashes in some occasions. Root-cause is that when tcp_sendmsg() has allocated a fresh skb and could not append a fragment before being blocked in sk_stream_wait_memory(), tcp_write_xmit() might be called and decide to send this fresh and empty skb. Sending an empty packet is not only silly, it might have caused many issues we had in the past with tp->packets_out being out of sync. Fixes: c65f7f00c5 ("[TCP]: Simplify SKB data portion allocation with NETIF_F_SG.") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Christoph Paasch <cpaasch@apple.com> Acked-by: Neal Cardwell <ncardwell@google.com> Cc: Jason Baron <jbaron@akamai.com> Acked-by: Soheil Hassas Yeganeh <soheil@google.com> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>		2019-12-13 21:58:40 -08:00
..
6lowpan	6lowpan: no need to check return value of debugfs_create functions	2019-07-06 12:50:01 +02:00
9p	9p pull request for inclusion in 5.4	2019-09-27 15:10:34 -07:00
802
8021q	net: remove unnecessary variables and callback	2019-10-24 14:53:49 -07:00
appletalk	appletalk: enforce CAP_NET_RAW for raw sockets	2019-09-24 16:37:18 +02:00
atm	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-11-22 16:27:24 -08:00
ax25	net: use helpers to change sk_ack_backlog	2019-11-06 16:14:48 -08:00
batman-adv	batman-adv: Drop lockdep.h include for soft-interface.c	2019-11-03 08:30:58 +01:00
bluetooth	compat_ioctl: remove most of fs/compat_ioctl.c	2019-12-01 13:46:15 -08:00
bpf	bpf: Fix memory leak on object 'data'	2019-11-18 19:32:59 -08:00
bpfilter	Kbuild updates for v5.3	2019-07-12 16:03:16 -07:00
bridge	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf	2019-12-09 14:03:33 -08:00
caif	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-11-02 13:54:56 -07:00
can	can: j1939: j1939_sk_bind(): take priv after lock is held	2019-12-08 11:52:02 +01:00
ceph	libceph, rbd, ceph: convert to use the new mount API	2019-11-27 22:28:37 +01:00
core	neighbour: remove neigh_cleanup() method	2019-12-09 09:48:47 -08:00
dcb
dccp	net: ipv6: add net argument to ip6_dst_lookup_flow	2019-12-04 12:27:12 -08:00
decnet	net: use helpers to change sk_ack_backlog	2019-11-06 16:14:48 -08:00
dns_resolver	Revert "Merge tag 'keys-acl-20190703' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs"	2019-07-10 18:43:43 -07:00
dsa	net: phylink: rename mac_link_state() op to mac_pcs_get_state()	2019-11-23 16:13:39 -08:00
ethernet	net: add annotations on hh->hh_len lockless accesses	2019-11-07 20:07:30 -08:00
hsr	hsr: fix a NULL pointer dereference in hsr_dev_xmit()	2019-12-05 12:09:02 -08:00
ieee802154	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-11-02 13:54:56 -07:00
ife	net: Fix Kconfig indentation	2019-09-26 08:56:17 +02:00
ipv4	tcp: do not send empty skb from tcp_write_xmit()	2019-12-13 21:58:40 -08:00
ipv6	ipv6/addrconf: only check invalid header values when NETLINK_F_STRICT_CHK is set	2019-12-13 17:13:49 -08:00
iucv	net/af_iucv: mark expected switch fall-throughs	2019-07-29 10:26:14 -07:00
kcm	kcm: disable preemption in kcm_parse_func_strparser()	2019-09-27 10:27:14 +02:00
key	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2019-07-08 19:48:57 -07:00
l2tp	net: ipv6: add net argument to ip6_dst_lookup_flow	2019-12-04 12:27:12 -08:00
l3mdev
lapb
llc	net: silence data-races on sk_backlog.tail	2019-11-06 21:35:34 -08:00
mac80211	Driver core patches for 5.5-rc1	2019-11-27 11:06:20 -08:00
mac802154
mpls	net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup	2019-12-04 12:27:13 -08:00
ncsi	net/ncsi: Disable global multicast filter	2019-09-19 18:04:40 -07:00
netfilter	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf	2019-12-09 14:03:33 -08:00
netlabel	netlabel: remove redundant assignment to pointer iter	2019-09-01 11:45:02 -07:00
netlink	genetlink: do not parse attributes for families with zero maxattr	2019-10-13 11:20:03 -07:00
netrom	net: core: add generic lockdep keys	2019-10-24 14:53:48 -07:00
nfc	NFC: NCI: use new delay structure for SPI transfer delays	2019-12-04 17:00:58 -08:00
nsh
openvswitch	net: Fixed updating of ethertype in skb_mpls_push()	2019-12-04 17:11:25 -08:00
packet	af_packet: set defaule value for tmo	2019-12-09 14:30:19 -08:00
phonet	net: use skb_queue_empty_lockless() in poll() handlers	2019-10-28 13:33:41 -07:00
psample	net: psample: fix skb_over_panic	2019-11-26 14:40:13 -08:00
qrtr	net: qrtr: Simplify 'qrtr_tun_release()'	2019-10-30 17:58:23 -07:00
rds	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-11-16 21:51:42 -08:00
rfkill	compat_ioctl: remove most of fs/compat_ioctl.c	2019-12-01 13:46:15 -08:00
rose	net: use helpers to change sk_ack_backlog	2019-11-06 16:14:48 -08:00
rxrpc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2019-11-25 20:02:57 -08:00
sched	net_sched: validate TCA_KIND attribute in tc_chain_tmplt_add()	2019-12-07 12:04:16 -08:00
sctp	sctp: fully initialize v4 addr in some functions	2019-12-09 10:16:39 -08:00
smc	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-11-16 21:51:42 -08:00
strparser
sunrpc	This is a relatively quiet cycle for nfsd, mainly various bugfixes.	2019-12-07 16:56:00 -08:00
switchdev
tipc	tipc: fix use-after-free in tipc_disc_rcv()	2019-12-10 17:45:04 -08:00
tls	net/tls: Fix return values to avoid ENOTSUPP	2019-12-06 20:15:39 -08:00
unix	compat_ioctl: remove most of fs/compat_ioctl.c	2019-12-01 13:46:15 -08:00
vmw_vsock	- Support for new VMBus protocols (Andrea Parri).	2019-11-30 14:50:51 -08:00
wimax	wimax: no need to check return value of debugfs_create functions	2019-08-10 15:25:47 -07:00
wireless	Some relatively small changes:	2019-11-08 11:36:48 -08:00
x25	net/x25: add new state X25_STATE_5	2019-12-09 10:28:43 -08:00
xdp	xsk: Fix xsk_poll()'s return type	2019-11-24 16:58:44 -08:00
xfrm	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next	2019-11-25 20:02:57 -08:00
compat.c	y2038: socket: use __kernel_old_timespec instead of timespec	2019-11-15 14:38:29 +01:00
Kconfig	net: Fix Kconfig indentation, continued	2019-11-21 12:00:21 -08:00
Makefile
socket.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-12-08 13:28:11 -08:00
sysctl_net.c