Zefan Li 090e28b229 netprio_cgroup: Fix unlimited memory leak of v2 cgroups ... If systemd is configured to use hybrid mode which enables the use of both cgroup v1 and v2, systemd will create new cgroup on both the default root (v2) and netprio_cgroup hierarchy (v1) for a new session and attach task to the two cgroups. If the task does some network thing then the v2 cgroup can never be freed after the session exited. One of our machines ran into OOM due to this memory leak. In the scenario described above when sk_alloc() is called cgroup_sk_alloc() thought it's in v2 mode, so it stores the cgroup pointer in sk->sk_cgrp_data and increments the cgroup refcnt, but then sock_update_netprioidx() thought it's in v1 mode, so it stores netprioidx value in sk->sk_cgrp_data, so the cgroup refcnt will never be freed. Currently we do the mode switch when someone writes to the ifpriomap cgroup control file. The easiest fix is to also do the switch when a task is attached to a new cgroup. Fixes: bd1060a1d6 ("sock, cgroup: add sock->sk_cgroup") Reported-by: Yang Yingliang <yangyingliang@huawei.com> Tested-by: Yang Yingliang <yangyingliang@huawei.com> Signed-off-by: Zefan Li <lizefan@huawei.com> Acked-by: Tejun Heo <tj@kernel.org> Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2020-05-09 20:59:21 -07:00
..
bpf_sk_storage.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2020-02-29 15:53:35 -08:00
datagram.c	net: use indirect call wrappers for skb_copy_datagram_iter()	2020-03-25 11:30:40 -07:00
datagram.h	net/core: Allow the compiler to verify declaration and definition consistency	2019-03-27 13:49:44 -07:00
dev_addr_lists.c	net: remove unnecessary variables and callback	2019-10-24 14:53:49 -07:00
dev_ioctl.c	ethtool: add timestamping related string sets	2020-03-29 22:32:36 -07:00
dev.c	net: fix a potential recursive NETDEV_FEAT_CHANGE	2020-05-07 18:18:36 -07:00
devlink.c	devlink: Fix reporter's recovery condition	2020-05-04 10:40:39 -07:00
drop_monitor.c	drop_monitor: work around gcc-10 stringop-overflow warning	2020-05-01 15:45:16 -07:00
dst_cache.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
dst.c	net: print proper warning on dst underflow	2019-09-26 09:05:56 +02:00
failover.c	failover: allow name change on IFF_UP slave interfaces	2019-04-10 22:12:26 -07:00
fib_notifier.c	net: fib_notifier: propagate extack down to the notifier block callback	2019-10-04 11:10:56 -07:00
fib_rules.c	net: fib_rules: Correctly set table field when table number exceeds 8 bits	2020-02-16 18:38:24 -08:00
filter.c	bpf, sockmap: msg_pop_data can incorrecty set an sge length	2020-05-06 00:22:15 +02:00
flow_dissector.c	bpf: Use bpf_prog_run_pin_on_cpu() at simple call sites.	2020-02-24 16:20:09 -08:00
flow_offload.c	netfilter: flowtable: Fix incorrect tc_setup_type type	2020-03-27 18:41:52 +01:00
gen_estimator.c	net_sched: gen_estimator: extend packet counter to 64bit	2019-11-06 21:51:36 -08:00
gen_stats.c	net_sched: add TCA_STATS_PKT64 attribute	2019-11-05 18:20:55 -08:00
gro_cells.c	gro_cells: make sure device is up in gro_cells_receive()	2019-03-10 11:07:14 -07:00
hwbm.c	net: hwbm: Make the hwbm_pool lock a mutex	2019-06-09 19:40:10 -07:00
link_watch.c	net: link_watch: prevent starvation when processing linkwatch wq	2019-07-01 19:02:47 -07:00
lwt_bpf.c	net: add net available in build_state	2020-03-29 22:30:57 -07:00
lwtunnel.c	net: ipv6: add rpl sr tunnel	2020-03-29 22:30:57 -07:00
Makefile	ethtool: move to its own directory	2019-12-12 17:07:05 -08:00
neighbour.c	neigh: send protocol value in neighbor create notification	2020-05-05 13:38:59 -07:00
net_namespace.c	bpf: Add netns cookie and enable it for bpf cgroup hooks	2020-03-27 19:40:38 -07:00
net-procfs.c	net: procfs: use index hashlist instead of name hashlist	2019-10-01 14:47:19 -07:00
net-sysfs.c	net-sysfs: remove redundant assignment to variable ret	2020-04-09 10:14:53 -07:00
net-sysfs.h	net-sysfs: add netdev_change_owner()	2020-02-26 20:07:25 -08:00
net-traces.c	page_pool: add tracepoints for page_pool with details need by XDP	2019-06-19 11:23:13 -04:00
netclassid_cgroup.c	cgroup, netclassid: remove double cond_resched	2020-04-21 15:44:30 -07:00
netevent.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
netpoll.c	net: fix skb use after free in netpoll	2019-08-27 20:52:02 -07:00
netprio_cgroup.c	netprio_cgroup: Fix unlimited memory leak of v2 cgroups	2020-05-09 20:59:21 -07:00
page_pool.c	net: page pool: allow to pass zero flags to page_pool_init()	2020-03-29 21:49:20 -07:00
pktgen.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-03-25 18:58:11 -07:00
ptp_classifier.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295	2019-06-05 17:36:38 +02:00
request_sock.c	tcp: add rcu protection around tp->fastopen_rsk	2019-10-13 10:13:08 -07:00
rtnetlink.c	xdp: Support specifying expected existing program when attaching XDP	2020-03-28 14:24:41 -07:00
scm.c	y2038: socket: remove timespec reference in timestamping	2019-11-15 14:38:29 +01:00
secure_seq.c	treewide: Add SPDX license identifier for missed files	2019-05-21 10:50:45 +02:00
skbuff.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-03-30 20:48:43 -07:00
skmsg.c	bpf: Use bpf_prog_run_pin_on_cpu() at simple call sites.	2020-02-24 16:20:09 -08:00
sock_diag.c	sock: make cookie generation global instead of per netns	2019-08-09 13:14:46 -07:00
sock_map.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2020-03-25 18:58:11 -07:00
sock_reuseport.c	net: Generate reuseport group ID on group creation	2020-02-21 22:29:45 +01:00
sock.c	net: remove obsolete comment	2020-04-25 20:49:32 -07:00
stream.c	tcp: make sure EPOLLOUT wont be missed	2019-08-19 13:07:43 -07:00
sysctl_net_core.c	net, sysctl: Fix compiler warning when only cBPF is present	2019-12-19 17:17:51 +01:00
timestamping.c	net: Introduce a new MII time stamping interface.	2019-12-25 19:51:33 -08:00
tso.c	net: Use skb accessors in network core	2019-07-22 20:47:56 -07:00
utils.c	net: Fix skb->csum update in inet_proto_csum_replace16().	2020-01-24 20:54:30 +01:00
xdp.c	net: page_pool: API cleanup and comments	2020-02-20 10:09:25 -08:00