Zhengjun Xing 7fc65d4c2b xhci: Fix Kernel oops in xhci dbgtty ... tty_unregister_driver may be called more than 1 time in some hotplug cases,it will cause the kernel oops. This patch checked dbc_tty_driver to make sure it is unregistered only 1 time. [ 175.741404] BUG: unable to handle kernel NULL pointer dereference at 0000000000000034 [ 175.742309] IP: tty_unregister_driver+0x9/0x70 [ 175.743148] PGD 0 P4D 0 [ 175.743981] Oops: 0000 [#1] SMP PTI [ 175.753904] RIP: 0010:tty_unregister_driver+0x9/0x70 [ 175.754817] RSP: 0018:ffffa8ff831d3bb0 EFLAGS: 00010246 [ 175.755753] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 [ 175.756685] RDX: ffff92089c616000 RSI: ffffe64fe1b26080 RDI: 0000000000000000 [ 175.757608] RBP: ffff92086c988230 R08: 000000006c982701 R09: 00000001801e0016 [ 175.758533] R10: ffffa8ff831d3b48 R11: ffff92086c982100 R12: ffff92086c98827c [ 175.759462] R13: ffff92086c988398 R14: 0000000000000060 R15: ffff92089c5e9b40 [ 175.760401] FS: 0000000000000000(0000) GS:ffff9208a0100000(0000) knlGS:0000000000000000 [ 175.761334] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 175.762270] CR2: 0000000000000034 CR3: 000000011800a003 CR4: 00000000003606e0 [ 175.763225] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 175.764164] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 175.765091] Call Trace: [ 175.766014] xhci_dbc_tty_unregister_driver+0x11/0x30 [ 175.766960] xhci_dbc_exit+0x2a/0x40 [ 175.767889] xhci_stop+0x57/0x1c0 [ 175.768824] usb_remove_hcd+0x100/0x250 [ 175.769708] usb_hcd_pci_remove+0x68/0x130 [ 175.770574] pci_device_remove+0x3b/0xc0 [ 175.771435] device_release_driver_internal+0x157/0x230 [ 175.772343] pci_stop_bus_device+0x74/0xa0 [ 175.773205] pci_stop_bus_device+0x2b/0xa0 [ 175.774061] pci_stop_bus_device+0x2b/0xa0 [ 175.774907] pci_stop_bus_device+0x2b/0xa0 [ 175.775741] pci_stop_bus_device+0x2b/0xa0 [ 175.776618] pci_stop_bus_device+0x2b/0xa0 [ 175.777452] pci_stop_bus_device+0x2b/0xa0 [ 175.778273] pci_stop_bus_device+0x2b/0xa0 [ 175.779092] pci_stop_bus_device+0x2b/0xa0 [ 175.779908] pci_stop_bus_device+0x2b/0xa0 [ 175.780750] pci_stop_bus_device+0x2b/0xa0 [ 175.781543] pci_stop_and_remove_bus_device+0xe/0x20 [ 175.782338] pciehp_unconfigure_device+0xb8/0x160 [ 175.783128] pciehp_disable_slot+0x4f/0xd0 [ 175.783920] pciehp_power_thread+0x82/0xa0 [ 175.784766] process_one_work+0x147/0x3c0 [ 175.785564] worker_thread+0x4a/0x440 [ 175.786376] kthread+0xf8/0x130 [ 175.787174] ? rescuer_thread+0x360/0x360 [ 175.787964] ? kthread_associate_blkcg+0x90/0x90 [ 175.788798] ret_from_fork+0x35/0x40 Cc: <stable@vger.kernel.org> # 4.16 Fixes: dfba2174dc ("usb: xhci: Add DbC support in xHCI driver") Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com> Tested-by: Christian Kellner <christian@kellner.me> Reviewed-by: Christian Kellner <christian@kellner.me> Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2018-04-22 15:23:37 +02:00
..
whci	USB: host: whci: Re-use DEFINE_SHOW_ATTRIBUTE() macro	2018-03-09 09:31:26 -08:00
bcma-hcd.c	USB: host: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-atmel.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-dbg.c	usb: host: fix incorrect updating of offset	2017-11-28 15:17:48 +01:00
ehci-exynos.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-fsl.c	usb: add a flag to skip PHY initialization to struct usb_hcd	2018-03-09 09:43:52 -08:00
ehci-fsl.h	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-grlib.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-hcd.c	usb: host: remove tilegx platform glue	2018-03-26 15:57:10 +02:00
ehci-hub.c	usb: host: ehci: use correct device pointer for dma ops	2018-02-15 18:43:57 +01:00
ehci-mem.c	usb: host: ehci: Use dma_pool_zalloc()	2018-02-22 15:17:05 +01:00
ehci-mv.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-mxc.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-omap.c	usb: ehci-omap: don't complain on -EPROBE_DEFER when no PHY found	2018-01-22 15:34:38 +01:00
ehci-orion.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-pci.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-platform.c	usb: host: ehci-platform: remove custom USB PHY handling	2018-03-09 09:43:53 -08:00
ehci-pmcmsp.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-ppc-of.c	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
ehci-ps3.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-q.c	usb: host: ehci: always enable interrupt for qtd completion at test mode	2018-02-15 18:45:34 +01:00
ehci-sched.c	usb: host: ehci: Use dma_pool_zalloc()	2018-02-22 15:17:05 +01:00
ehci-sh.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-spear.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-st.c	pinctrl: files should directly include apis they use	2018-02-05 09:41:54 -08:00
ehci-sysfs.c	USB: move many drivers to use DEVICE_ATTR_RW	2018-01-24 08:49:51 +01:00
ehci-tegra.c	usb: add a flag to skip PHY initialization to struct usb_hcd	2018-03-09 09:43:52 -08:00
ehci-timer.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-w90x900.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci-xilinx-of.c	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ehci.h	USB: host: ehci: Remove redundant license text	2017-11-07 15:45:02 +01:00
fhci-dbg.c	USB: host: fhci: Re-use DEFINE_SHOW_ATTRIBUTE() macro	2018-03-09 09:31:25 -08:00
fhci-hcd.c	USB: host: fhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
fhci-hub.c	USB: host: fhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
fhci-mem.c	USB: host: fhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
fhci-q.c	USB: host: fhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
fhci-sched.c	USB: host: fhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
fhci-tds.c	USB: host: fhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
fhci.h	USB: host: fhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
fotg210-hcd.c	USB: move many drivers to use DEVICE_ATTR_RW	2018-01-24 08:49:51 +01:00
fotg210.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fsl-mph-dr-of.c	USB: host: Remove redundant license text	2017-11-07 15:45:02 +01:00
hwa-hc.c	USB: host: Remove redundant license text	2017-11-07 15:45:02 +01:00
imx21-dbg.c	USB: host: imx21: Re-use DEFINE_SHOW_ATTRIBUTE() macro	2018-03-09 09:31:26 -08:00
imx21-hcd.c	USB: host: imx21: Remove redundant license text	2017-11-07 15:45:02 +01:00
imx21-hcd.h	USB: host: imx21: Remove redundant license text	2017-11-07 15:45:02 +01:00
isp116x-hcd.c	USB: host: isp116x: Re-use DEFINE_SHOW_ATTRIBUTE() macro	2018-03-09 09:31:26 -08:00
isp116x.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
isp1362-hcd.c	usb: host: isp1362-hcd: remove a couple of redundant assignments	2017-11-07 15:52:29 +01:00
isp1362.h	usb: isp1362: remove blackfin arch glue	2018-03-26 15:57:14 +02:00
Kconfig	USB/PHY patches for 4.17-rc1	2018-04-04 17:55:35 -07:00
Makefile	xhci: Add Intel extended cap / otg phy mux handling	2018-03-22 13:40:10 +01:00
max3421-hcd.c	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
ohci-at91.c	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
ohci-da8xx.c	USB: ohci: da8xx: remove clk con_id	2018-01-09 16:15:19 +01:00
ohci-dbg.c	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
ohci-exynos.c	USB: host: ohci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ohci-hcd.c	arch: remove obsolete architecture ports	2018-04-02 20:20:12 -07:00
ohci-hub.c	ohci-hcd: Fix race condition caused by ohci_urb_enqueue() and io_watchdog_func()	2018-02-15 18:43:57 +01:00
ohci-mem.c	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
ohci-nxp.c	USB: host: ohci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ohci-omap.c	usb: add a flag to skip PHY initialization to struct usb_hcd	2018-03-09 09:43:52 -08:00
ohci-pci.c	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
ohci-platform.c	usb: host: ohci-platform: remove custom USB PHY handling	2018-03-09 09:43:53 -08:00
ohci-ppc-of.c	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
ohci-ps3.c	USB: host: ohci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ohci-pxa27x.c	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
ohci-q.c	usb: ohci: Proper handling of ed_rm_list to handle race condition between usb_kill_urb() and finish_unlinks()	2018-02-15 18:45:34 +01:00
ohci-s3c2410.c	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
ohci-sa1111.c	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
ohci-sm501.c	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
ohci-spear.c	USB: host: ohci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ohci-st.c	USB: host: ohci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ohci-tmio.c	USB: host: ohci: Remove redundant license text	2017-11-07 15:45:02 +01:00
ohci.h	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
oxu210hp-hcd.c	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
oxu210hp.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
pci-quirks.c	xhci: workaround for AMD Promontory disabled ports wakeup	2018-02-15 18:36:19 +01:00
pci-quirks.h	xhci: workaround for AMD Promontory disabled ports wakeup	2018-02-15 18:36:19 +01:00
r8a66597-hcd.c	treewide: setup_timer() -> timer_setup()	2017-11-21 15:57:07 -08:00
r8a66597.h	USB: host: Remove redundant license text	2017-11-07 15:45:02 +01:00
sl811_cs.c	USB: add SPDX identifiers to all remaining files in drivers/usb/	2017-11-04 11:48:02 +01:00
sl811-hcd.c	USB: host: sl811: Re-use DEFINE_SHOW_ATTRIBUTE() macro	2018-03-16 15:40:19 +01:00
sl811.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
ssb-hcd.c	USB: host: Remove redundant license text	2017-11-07 15:45:02 +01:00
u132-hcd.c	USB: host: Remove redundant license text	2017-11-07 15:45:02 +01:00
uhci-debug.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
uhci-grlib.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
uhci-hcd.c	USB: host: Use zeroing memory allocator rather than allocator/memset	2018-01-04 17:03:15 +01:00
uhci-hcd.h	usb: uhci: Add clk support to uhci-platform	2018-01-17 15:08:56 +01:00
uhci-hub.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
uhci-pci.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
uhci-platform.c	usb: uhci: Add clk support to uhci-platform	2018-01-17 15:08:56 +01:00
uhci-q.c	USB: remove the URB_NO_FSBR flag	2017-12-12 13:16:07 +01:00
xhci-dbg.c	usb: xhci: Cleanup printk debug message for ERST	2017-12-08 17:43:52 +01:00
xhci-dbgcap.c	usb: xhci: dbc: Fix lockdep warning	2018-03-08 09:06:53 -08:00
xhci-dbgcap.h	usb: xhci: Add DbC support in xHCI driver	2017-12-08 17:43:52 +01:00
xhci-dbgtty.c	xhci: Fix Kernel oops in xhci dbgtty	2018-04-22 15:23:37 +02:00
xhci-debugfs.c	xhci: Fix NULL pointer in xhci debugfs	2018-02-15 18:36:19 +01:00
xhci-debugfs.h	USB: host: xhci-debugfs: add SPDX lines	2017-11-07 15:53:48 +01:00
xhci-ext-caps.c	xhci: Add Intel extended cap / otg phy mux handling	2018-03-22 13:40:10 +01:00
xhci-ext-caps.h	xhci: Add Intel extended cap / otg phy mux handling	2018-03-22 13:40:10 +01:00
xhci-hub.c	xhci: Don't print a warning when setting link state for disabled ports	2018-02-15 18:36:19 +01:00
xhci-mem.c	xhci: zero usb device slot_id member when disabling and freeing a xhci slot	2018-03-16 15:40:18 +01:00
xhci-mtk-sch.c	USB: host: xhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
xhci-mtk.c	usb: host: xhci-mtk: remove custom USB PHY handling	2018-03-09 09:43:53 -08:00
xhci-mtk.h	usb: xhci-mtk: supports remote wakeup for mt2712 with two xHCI IPs	2018-01-09 16:21:28 +01:00
xhci-mvebu.c	USB: host: xhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
xhci-mvebu.h	USB: host: xhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
xhci-pci.c	xhci: Fix USB ports for Dell Inspiron 5775	2018-04-20 16:24:20 +02:00
xhci-plat.c	Revert "xhci: plat: Register shutdown for xhci_plat"	2018-04-22 14:45:12 +02:00
xhci-plat.h	USB: host: xhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
xhci-rcar.c	usb: host: xhci-rcar: add support for r8a77965	2018-03-08 10:07:44 -08:00
xhci-rcar.h	USB: host: xhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
xhci-ring.c	xhci: Clear the host side toggle manually when endpoint is soft reset	2018-03-16 15:40:19 +01:00
xhci-tegra.c	USB: host: xhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
xhci-trace.c	USB: host: xhci: Remove redundant license text	2017-11-07 15:45:02 +01:00
xhci-trace.h	xhci: add port status tracing for Get Hub Status requests	2017-12-08 17:43:53 +01:00
xhci.c	Merge branch 4.16-rc6 into usb-next	2018-03-20 09:56:08 +01:00
xhci.h	usb: host: xhci-plat: Fix clock resource by adding a register clock	2018-04-20 16:24:20 +02:00