Junxiao Bi 087ffd4eae jbd2: fix null committed data return in undo_access ... introduced jbd2_write_access_granted() to improve write|undo_access speed, but missed to check the status of b_committed_data which caused a kernel panic on ocfs2. [ 6538.405938] ------------[ cut here ]------------ [ 6538.406686] kernel BUG at fs/ocfs2/suballoc.c:2400! [ 6538.406686] invalid opcode: 0000 [#1] SMP [ 6538.406686] Modules linked in: ocfs2 nfsd lockd grace nfs_acl auth_rpcgss sunrpc autofs4 ocfs2_dlmfs ocfs2_stack_o2cb ocfs2_dlm ocfs2_nodemanager ocfs2_stackglue configfs sd_mod sg ip6t_REJECT nf_reject_ipv6 nf_conntrack_ipv6 nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables be2iscsi iscsi_boot_sysfs bnx2i cnic uio cxgb4i cxgb4 cxgb3i libcxgbi cxgb3 mdio ib_iser rdma_cm ib_cm iw_cm ib_sa ib_mad ib_core ib_addr ipv6 iscsi_tcp libiscsi_tcp libiscsi scsi_transport_iscsi ppdev xen_kbdfront xen_netfront xen_fbfront parport_pc parport pcspkr i2c_piix4 acpi_cpufreq ext4 jbd2 mbcache xen_blkfront floppy pata_acpi ata_generic ata_piix cirrus ttm drm_kms_helper drm fb_sys_fops sysimgblt sysfillrect i2c_core syscopyarea dm_mirror dm_region_hash dm_log dm_mod [ 6538.406686] CPU: 1 PID: 16265 Comm: mmap_truncate Not tainted 4.3.0 #1 [ 6538.406686] Hardware name: Xen HVM domU, BIOS 4.3.1OVM 05/14/2014 [ 6538.406686] task: ffff88007c2bab00 ti: ffff880075b78000 task.ti: ffff880075b78000 [ 6538.406686] RIP: 0010:[<ffffffffa06a286b>] [<ffffffffa06a286b>] ocfs2_block_group_clear_bits+0x23b/0x250 [ocfs2] [ 6538.406686] RSP: 0018:ffff880075b7b7f8 EFLAGS: 00010246 [ 6538.406686] RAX: ffff8800760c5b40 RBX: ffff88006c06a000 RCX: ffffffffa06e6df0 [ 6538.406686] RDX: 0000000000000000 RSI: ffff88007a6f6ea0 RDI: ffff88007a760430 [ 6538.406686] RBP: ffff880075b7b878 R08: 0000000000000002 R09: 0000000000000001 [ 6538.406686] R10: ffffffffa06769be R11: 0000000000000000 R12: 0000000000000001 [ 6538.406686] R13: ffffffffa06a1750 R14: 0000000000000001 R15: ffff88007a6f6ea0 [ 6538.406686] FS: 00007f17fde30720(0000) GS:ffff88007f040000(0000) knlGS:0000000000000000 [ 6538.406686] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 6538.406686] CR2: 0000000000601730 CR3: 000000007aea0000 CR4: 00000000000406e0 [ 6538.406686] Stack: [ 6538.406686] ffff88007c2bb5b0 ffff880075b7b8e0 ffff88007a7604b0 ffff88006c640800 [ 6538.406686] ffff88007a7604b0 ffff880075d77390 0000000075b7b878 ffffffffa06a309d [ 6538.406686] ffff880075d752d8 ffff880075b7b990 ffff880075b7b898 0000000000000000 [ 6538.406686] Call Trace: [ 6538.406686] [<ffffffffa06a309d>] ? ocfs2_read_group_descriptor+0x6d/0xa0 [ocfs2] [ 6538.406686] [<ffffffffa06a3654>] _ocfs2_free_suballoc_bits+0xe4/0x320 [ocfs2] [ 6538.406686] [<ffffffffa06a1750>] ? ocfs2_put_slot+0xf0/0xf0 [ocfs2] [ 6538.406686] [<ffffffffa06a397e>] _ocfs2_free_clusters+0xee/0x210 [ocfs2] [ 6538.406686] [<ffffffffa06a1750>] ? ocfs2_put_slot+0xf0/0xf0 [ocfs2] [ 6538.406686] [<ffffffffa06a1750>] ? ocfs2_put_slot+0xf0/0xf0 [ocfs2] [ 6538.406686] [<ffffffffa0682d50>] ? ocfs2_extend_trans+0x50/0x1a0 [ocfs2] [ 6538.406686] [<ffffffffa06a3ad5>] ocfs2_free_clusters+0x15/0x20 [ocfs2] [ 6538.406686] [<ffffffffa065072c>] ocfs2_replay_truncate_records+0xfc/0x290 [ocfs2] [ 6538.406686] [<ffffffffa06843ac>] ? ocfs2_start_trans+0xec/0x1d0 [ocfs2] [ 6538.406686] [<ffffffffa0654600>] __ocfs2_flush_truncate_log+0x140/0x2d0 [ocfs2] [ 6538.406686] [<ffffffffa0654394>] ? ocfs2_reserve_blocks_for_rec_trunc.clone.0+0x44/0x170 [ocfs2] [ 6538.406686] [<ffffffffa065acd4>] ocfs2_remove_btree_range+0x374/0x630 [ocfs2] [ 6538.406686] [<ffffffffa017486b>] ? jbd2_journal_stop+0x25b/0x470 [jbd2] [ 6538.406686] [<ffffffffa065d5b5>] ocfs2_commit_truncate+0x305/0x670 [ocfs2] [ 6538.406686] [<ffffffffa0683430>] ? ocfs2_journal_access_eb+0x20/0x20 [ocfs2] [ 6538.406686] [<ffffffffa067adb7>] ocfs2_truncate_file+0x297/0x380 [ocfs2] [ 6538.406686] [<ffffffffa01759e4>] ? jbd2_journal_begin_ordered_truncate+0x64/0xc0 [jbd2] [ 6538.406686] [<ffffffffa067c7a2>] ocfs2_setattr+0x572/0x860 [ocfs2] [ 6538.406686] [<ffffffff810e4a3f>] ? current_fs_time+0x3f/0x50 [ 6538.406686] [<ffffffff812124b7>] notify_change+0x1d7/0x340 [ 6538.406686] [<ffffffff8121abf9>] ? generic_getxattr+0x79/0x80 [ 6538.406686] [<ffffffff811f5876>] do_truncate+0x66/0x90 [ 6538.406686] [<ffffffff81120e30>] ? __audit_syscall_entry+0xb0/0x110 [ 6538.406686] [<ffffffff811f5bb3>] do_sys_ftruncate.clone.0+0xf3/0x120 [ 6538.406686] [<ffffffff811f5bee>] SyS_ftruncate+0xe/0x10 [ 6538.406686] [<ffffffff816aa2ae>] entry_SYSCALL_64_fastpath+0x12/0x71 [ 6538.406686] Code: 28 48 81 ee b0 04 00 00 48 8b 92 50 fb ff ff 48 8b 80 b0 03 00 00 48 39 90 88 00 00 00 0f 84 30 fe ff ff 0f 0b eb fe 0f 0b eb fe <0f> 0b 0f 1f 00 eb fb 66 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 [ 6538.406686] RIP [<ffffffffa06a286b>] ocfs2_block_group_clear_bits+0x23b/0x250 [ocfs2] [ 6538.406686] RSP <ffff880075b7b7f8> [ 6538.691128] ---[ end trace 31cd7011d6770d7e ]--- [ 6538.694492] Kernel panic - not syncing: Fatal exception [ 6538.695484] Kernel Offset: disabled Fixes: de92c8caf16c("jbd2: speedup jbd2_journal_get_[write|undo]_access()") Cc: <stable@vger.kernel.org> Signed-off-by: Junxiao Bi <junxiao.bi@oracle.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>		2015-12-04 12:29:28 -05:00
..
9p	9p: fix return code of read() when count is 0	2015-08-23 14:21:36 -05:00
adfs	fs/adfs: remove unneeded cast	2015-06-30 19:44:57 -07:00
affs	fs/affs: make root lookup from blkdev logical size	2015-09-10 13:29:01 -07:00
afs	net: Add a struct net parameter to sock_create_kern	2015-05-11 10:50:17 -04:00
autofs4	make simple_positive() public	2015-06-23 18:02:01 -04:00
befs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
bfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-04-26 17:22:07 -07:00
btrfs	Merge branch 'for-linus-4.3' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs	2015-09-11 12:38:25 -07:00
cachefiles	Merge branch 'fscache-fixes' into for-next	2015-06-23 18:01:30 -04:00
ceph	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client	2015-09-11 12:33:03 -07:00
cifs	[CIFS] mount option sec=none not displayed properly in /proc/mounts	2015-09-11 19:37:06 -05:00
coda	fs/coda: fix readlink buffer overflow	2015-09-10 13:29:01 -07:00
configfs	configfs: fix kernel infoleak through user-controlled format string	2015-07-17 16:39:53 -07:00
cramfs
debugfs	debugfs: Export bool read/write functions	2015-07-20 18:44:50 +01:00
devpts	devpts: if initialization failed, don't crash when opening /dev/ptmx	2015-06-30 19:44:58 -07:00
dlm	dlm for 4.3	2015-09-03 12:57:48 -07:00
ecryptfs	Invalidate stale eCryptfs dcache entries caused by unlinked lower inodes	2015-09-08 11:26:17 -07:00
efivarfs	Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-05-06 10:57:37 -07:00
efs	fs/efs: femove unneeded cast	2015-06-25 17:00:42 -07:00
exofs	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
exportfs	VFS: (Scripted) Convert S_ISLNK/DIR/REG(dentry->d_inode) to d_is_*(dentry)	2015-02-22 11:38:41 -05:00
ext2	ext2: huge page fault support	2015-09-08 15:35:28 -07:00
ext4	ext4: add "static" to ext4_seq_##name##_fops struct	2015-11-26 15:52:24 -05:00
f2fs	Merge tag 'for-f2fs-4.3' of git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs	2015-09-03 13:10:22 -07:00
fat	writeback: separate out include/linux/backing-dev-defs.h	2015-06-02 08:33:34 -06:00
freevxfs	freevxfs: Grammar s/an negative/a negative/	2015-08-07 13:59:24 +02:00
fscache	FS-Cache: Retain the netfs context in the retrieval op earlier	2015-04-02 14:28:53 +01:00
fuse	fs/fuse: fix ioctl type confusion	2015-08-16 12:35:44 -07:00
gfs2	GFS2: merge window	2015-09-11 12:23:51 -07:00
hfs	hfs: fix B-tree corruption after insertion at position 0	2015-09-10 13:29:01 -07:00
hfsplus	hfs,hfsplus: cache pages correctly between bnode_create and bnode_free	2015-09-10 13:29:01 -07:00
hostfs	fs: create and use seq_show_option for escaping	2015-09-04 16:54:41 -07:00
hpfs	hpfs: update ctime and mtime on directory modification	2015-09-03 11:55:30 -07:00
hugetlbfs	hugetlbfs: add hugetlbfs_fallocate()	2015-09-08 15:35:28 -07:00
isofs	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
jbd2	jbd2: fix null committed data return in undo_access	2015-12-04 12:29:28 -05:00
jffs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
jfs	Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs	2015-09-03 12:28:30 -07:00
kernfs	kernfs: implement kernfs_path_len()	2015-08-18 15:49:15 -07:00
lockd	lockd: NLM grace period shouldn't block NFSv4 opens	2015-08-13 10:22:06 -04:00
logfs	block: remove bio_get_nr_vecs()	2015-08-13 12:32:04 -06:00
minix	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
ncpfs	ncpfs: successful rename() should invalidate caches for parents	2015-06-14 11:31:39 -04:00
nfs	NFS client updates for Linux 4.3	2015-09-07 14:02:24 -07:00
nfs_common	lockd: NLM grace period shouldn't block NFSv4 opens	2015-08-13 10:22:06 -04:00
nfsd	NFS client updates for Linux 4.3	2015-09-07 14:02:24 -07:00
nilfs2	block: remove bio_get_nr_vecs()	2015-08-13 12:32:04 -06:00
nls
notify	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-09-05 20:34:28 -07:00
ntfs	ntfs: delete unnecessary checks before calling iput()	2015-09-04 16:54:41 -07:00
ocfs2	revert "ocfs2/dlm: use list_for_each_entry instead of list_for_each"	2015-09-11 15:21:34 -07:00
omfs	omfs: fix potential integer overflow in allocator	2015-05-28 18:25:19 -07:00
openpromfs
overlayfs	fs: create and use seq_show_option for escaping	2015-09-04 16:54:41 -07:00
proc	proc: convert to kstrto*()/kstrto*_from_user()	2015-09-10 13:29:01 -07:00
pstore	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2015-07-03 15:20:57 -07:00
qnx4
qnx6	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
quota	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-09-05 20:34:28 -07:00
ramfs	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
reiserfs	fs: create and use seq_show_option for escaping	2015-09-04 16:54:41 -07:00
romfs	make new_sync_{read,write}() static	2015-04-11 22:29:40 -04:00
squashfs	fs: cleanup slight list_entry abuse	2015-06-23 18:01:59 -04:00
sysfs	vfs: Commit to never having exectuables on proc and sysfs.	2015-07-10 10:39:25 -05:00
sysv	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
tracefs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
ubifs	This pull request includes the following UBI/UBIFS changes:	2015-06-25 14:11:34 -07:00
udf	udf: Don't modify filesystem for read-only mounts	2015-08-20 14:58:35 +02:00
ufs	fix ufs write vs readpage race when writing into a hole	2015-09-09 10:43:12 -07:00
xfs	xfs: huge page fault support	2015-09-08 15:35:28 -07:00
aio.c	mm: move ->mremap() from file_operations to vm_operations_struct	2015-09-04 16:54:41 -07:00
anon_inodes.c
attr.c
bad_inode.c	don't bother with most of the bad_file_ops methods	2015-02-20 04:03:58 -05:00
binfmt_aout.c
binfmt_elf_fdpic.c
binfmt_elf.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-04-26 17:22:07 -07:00
binfmt_script.c
block_dev.c	blockdev: don't set S_DAX for misaligned partitions	2015-09-15 20:08:05 -04:00
buffer.c	fs: use helper bio_add_page() instead of open coding on bi_io_vec	2015-08-13 12:32:00 -06:00
char_dev.c	fs/char_dev.c: fix incorrect documentation for unregister_chrdev_region	2015-08-05 13:49:35 -07:00
compat_binfmt_elf.c
compat_ioctl.c	ioctl_compat: handle FITRIM	2015-07-09 11:42:21 -07:00
compat.c
coredump.c	fs: Don't dump core if the corefile would become world-readable.	2015-09-10 13:29:01 -07:00
dax.c	dax: fix O_DIRECT I/O to the last block of a blockdev	2015-09-15 20:07:35 -04:00
dcache.c	dcache: Reduce the scope of i_lock in d_splice_alias	2015-08-21 02:34:37 -04:00
dcookies.c
direct-io.c	block: remove bio_get_nr_vecs()	2015-08-13 12:32:04 -06:00
drop_caches.c	inode: convert inode_sb_list_lock to per-sb	2015-08-17 18:39:46 -04:00
eventfd.c	eventfd: don't take the spinlock in eventfd_poll	2015-02-17 14:34:52 -08:00
eventpoll.c	epoll: optimize setting task running after blocking	2015-02-13 21:21:40 -08:00
exec.c	vfs: Commit to never having exectuables on proc and sysfs.	2015-07-10 10:39:25 -05:00
fcntl.c
fhandle.c	vfs: read file_handle only once in handle_to_path	2015-06-02 10:29:07 -07:00
file_table.c	fs, file table: reinit files_stat.max_files after deferred memory initialisation	2015-08-07 04:39:40 +03:00
file.c	fs/file.c: __fget() and dup2() atomicity rules	2015-07-01 02:31:08 -04:00
filesystems.c
fs_pin.c	fs_pin: Allow for the possibility that m_list or s_list go unused.	2015-04-09 11:39:55 -05:00
fs_struct.c
fs-writeback.c	fs-writeback: unplug before cond_resched in writeback_sb_inodes	2015-09-19 18:50:19 -07:00
inode.c	inode: don't softlockup when evicting inodes	2015-08-18 10:20:09 -07:00
internal.h	inode: rename i_wb_list to i_io_list	2015-08-17 23:38:10 -04:00
ioctl.c	fsioctl.c: make generic_block_fiemap() signal-tolerant	2015-02-10 14:30:30 -08:00
Kconfig	fs: Remove ext3 filesystem driver	2015-07-23 20:59:40 +02:00
Kconfig.binfmt	mm: split ET_DYN ASLR from mmap ASLR	2015-04-14 16:49:05 -07:00
libfs.c	fs: Set the size of empty dirs to 0.	2015-08-12 15:28:45 -05:00
locks.c	fs: fix fs/locks.c kernel-doc warning	2015-08-31 16:27:25 -04:00
Makefile	ext4: promote ext4 over ext2 in the default probe order	2015-10-15 10:33:21 -04:00
mbcache.c
mount.h	fs: use seq_open_private() for proc_mounts	2015-06-30 19:44:56 -07:00
mpage.c	block: remove bio_get_nr_vecs()	2015-08-13 12:32:04 -06:00
namei.c	namei: fix warning while make xmldocs caused by namei.c	2015-09-10 13:29:01 -07:00
namespace.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2015-09-01 16:13:25 -07:00
no-block.c
nsfs.c	fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void	2015-09-11 15:21:34 -07:00
open.c	vfs: Commit to never having exectuables on proc and sysfs.	2015-07-10 10:39:25 -05:00
pipe.c	VFS: assorted weird filesystems: d_inode() annotations	2015-04-15 15:06:58 -04:00
pnode.c	mnt: Don't propagate unmounts to locked mounts	2015-04-02 20:34:20 -05:00
pnode.h	mnt: Clarify and correct the disconnect logic in umount_tree	2015-07-22 20:33:27 -05:00
posix_acl.c	fs/posix_acl.c: make posix_acl_create() safer and cleaner	2015-06-23 18:01:07 -04:00
proc_namespace.c	fs: use seq_open_private() for proc_mounts	2015-06-30 19:44:56 -07:00
read_write.c	new_sync_write(): discard ->ki_pos unless the return value is positive	2015-04-11 22:29:46 -04:00
readdir.c
select.c	locking/arch: Rename set_mb() to smp_store_mb()	2015-05-19 08:32:00 +02:00
seq_file.c	fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void	2015-09-11 15:21:34 -07:00
signalfd.c	signalfd: fix information leak in signalfd_copyinfo	2015-08-07 04:39:40 +03:00
splice.c	Merge branch 'akpm' (patches from Andrew)	2015-06-24 20:47:21 -07:00
stack.c
stat.c	VFS: assorted d_backing_inode() annotations	2015-04-15 15:06:59 -04:00
statfs.c
super.c	Merge branch 'superblock-scaling' of git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next into for-next	2015-08-21 02:31:20 -04:00
sync.c	vfs: add support for a lazytime mount option	2015-02-05 02:45:00 -05:00
timerfd.c
userfaultfd.c	userfaultfd: add missing mmput() in error path	2015-09-17 21:16:07 -07:00
utimes.c
xattr.c	evm: fix potential race when removing xattrs	2015-05-21 13:28:47 -04:00