Zhao Hongjiang 04df32fa10 inotify: invalid mask should return a error number but not set it ... When we run the crackerjack testsuite, the inotify_add_watch test is stalled. This is caused by the invalid mask 0 - the task is waiting for the event but it never comes. inotify_add_watch() should return -EINVAL as it did before commit 676a0675cf ("inotify: remove broken mask checks causing unmount to be EINVAL"). That commit removes the invalid mask check, but that check is needed. Check the mask's ALL_INOTIFY_BITS before the inotify_arg_to_mask() call. If none are set, just return -EINVAL. Because IN_UNMOUNT is in ALL_INOTIFY_BITS, this change will not trigger the problem that above commit fixed. [akpm@linux-foundation.org: fix build] Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com> Acked-by: Jim Somerville <Jim.Somerville@windriver.com> Cc: Paul Gortmaker <paul.gortmaker@windriver.com> Cc: Jerome Marchand <jmarchan@redhat.com> Cc: Eric Paris <eparis@parisplace.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2013-04-30 17:04:00 -07:00
..
inotify_fsnotify.c	inotify: don't use idr_remove_all()	2013-02-27 19:10:14 -08:00
inotify_user.c	inotify: invalid mask should return a error number but not set it	2013-04-30 17:04:00 -07:00
inotify.h	inotify: rename mark_entry to just mark	2010-07-28 09:58:54 -04:00
Kconfig	inotify: remove inotify in kernel interface	2010-07-28 09:58:31 -04:00
Makefile	inotify: remove inotify in kernel interface	2010-07-28 09:58:31 -04:00