Azat Khuzhin 036acea2ce ext4: fix ext4_count_free_clusters() with EXT4FS_DEBUG and bigalloc enabled ... With bigalloc enabled we must use EXT4_CLUSTERS_PER_GROUP() instead of EXT4_BLOCKS_PER_GROUP() otherwise we will go beyond the allocated buffer. $ mount -t ext4 /dev/vde /vde [ 70.573993] EXT4-fs DEBUG (fs/ext4/mballoc.c, 2346): ext4_mb_alloc_groupinfo: [ 70.575174] allocated s_groupinfo array for 1 meta_bg's [ 70.576172] EXT4-fs DEBUG (fs/ext4/super.c, 2092): ext4_check_descriptors: [ 70.576972] Checking group descriptorsBUG: unable to handle kernel paging request at ffff88006ab56000 [ 72.463686] IP: [<ffffffff81394eb9>] __bitmap_weight+0x2a/0x7f [ 72.464168] PGD 295e067 PUD 2961067 PMD 7fa8e067 PTE 800000006ab56060 [ 72.464738] Oops: 0000 [#1] SMP DEBUG_PAGEALLOC [ 72.465139] Modules linked in: [ 72.465402] CPU: 1 PID: 3560 Comm: mount Tainted: G W 3.14.0-rc2-00069-ge57bce1 #60 [ 72.466079] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 [ 72.466505] task: ffff88007ce6c8a0 ti: ffff88006b7f0000 task.ti: ffff88006b7f0000 [ 72.466505] RIP: 0010:[<ffffffff81394eb9>] [<ffffffff81394eb9>] __bitmap_weight+0x2a/0x7f [ 72.466505] RSP: 0018:ffff88006b7f1c00 EFLAGS: 00010206 [ 72.466505] RAX: 0000000000000000 RBX: 000000000000050a RCX: 0000000000000040 [ 72.466505] RDX: 0000000000000000 RSI: 0000000000080000 RDI: 0000000000000000 [ 72.466505] RBP: ffff88006b7f1c28 R08: 0000000000000002 R09: 0000000000000000 [ 72.466505] R10: 000000000000babe R11: 0000000000000400 R12: 0000000000080000 [ 72.466505] R13: 0000000000000200 R14: 0000000000002000 R15: ffff88006ab55000 [ 72.466505] FS: 00007f43ba1fa840(0000) GS:ffff88007f800000(0000) knlGS:0000000000000000 [ 72.466505] CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b [ 72.466505] CR2: ffff88006ab56000 CR3: 000000006b7e6000 CR4: 00000000000006e0 [ 72.466505] Stack: [ 72.466505] ffff88006ab65000 0000000000000000 0000000000000000 0000000000010000 [ 72.466505] ffff88006ab6f400 ffff88006b7f1c58 ffffffff81396bb8 0000000000010000 [ 72.466505] 0000000000000000 ffff88007b869a90 ffff88006a48a000 ffff88006b7f1c70 [ 72.466505] Call Trace: [ 72.466505] [<ffffffff81396bb8>] memweight+0x5f/0x8a [ 72.466505] [<ffffffff811c3b19>] ext4_count_free+0x13/0x21 [ 72.466505] [<ffffffff811c396c>] ext4_count_free_clusters+0xdb/0x171 [ 72.466505] [<ffffffff811e3bdd>] ext4_fill_super+0x117c/0x28ef [ 72.466505] [<ffffffff81391569>] ? vsnprintf+0x1c7/0x3f7 [ 72.466505] [<ffffffff8114d8dc>] mount_bdev+0x145/0x19c [ 72.466505] [<ffffffff811e2a61>] ? ext4_calculate_overhead+0x2a1/0x2a1 [ 72.466505] [<ffffffff811dab1d>] ext4_mount+0x15/0x17 [ 72.466505] [<ffffffff8114e3aa>] mount_fs+0x67/0x150 [ 72.466505] [<ffffffff811637ea>] vfs_kern_mount+0x64/0xde [ 72.466505] [<ffffffff81165d19>] do_mount+0x6fe/0x7f5 [ 72.466505] [<ffffffff81126cc8>] ? strndup_user+0x3a/0xd9 [ 72.466505] [<ffffffff8116604b>] SyS_mount+0x85/0xbe [ 72.466505] [<ffffffff81619e90>] tracesys+0xdd/0xe2 [ 72.466505] Code: c3 89 f0 b9 40 00 00 00 55 99 48 89 e5 41 57 f7 f9 41 56 49 89 ff 41 55 45 31 ed 41 54 41 89 f4 53 31 db 41 89 c6 45 39 ee 7e 10 <4b> 8b 3c ef 49 ff c5 e8 bf ff ff ff 01 c3 eb eb 31 c0 45 85 f6 [ 72.466505] RIP [<ffffffff81394eb9>] __bitmap_weight+0x2a/0x7f [ 72.466505] RSP <ffff88006b7f1c00> [ 72.466505] CR2: ffff88006ab56000 [ 72.466505] ---[ end trace 7d051a08ae138573 ]--- Killed Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>		2014-04-14 23:36:15 -04:00
..
acl.c	ext2/3/4: use generic posix ACL infrastructure	2014-01-25 23:58:19 -05:00
acl.h	ext2/3/4: use generic posix ACL infrastructure	2014-01-25 23:58:19 -05:00
balloc.c	ext4: fix ext4_count_free_clusters() with EXT4FS_DEBUG and bigalloc enabled	2014-04-14 23:36:15 -04:00
bitmap.c	ext4: Checksum the block bitmap properly with bigalloc enabled	2012-10-22 00:34:32 -04:00
block_validity.c	fs/ext4: use rbtree postorder iteration helper instead of opencoding	2014-01-23 16:37:03 -08:00
dir.c	fs/ext4: use rbtree postorder iteration helper instead of opencoding	2014-01-23 16:37:03 -08:00
ext4_extents.h	ext4: isolate ext4_extents.h file	2013-08-28 14:47:06 -04:00
ext4_jbd2.c	jbd2: improve error messages for inconsistent journal heads	2014-03-12 16:38:03 -04:00
ext4_jbd2.h	ext4: Fix misspellings using 'codespell' tool	2013-08-28 14:40:12 -04:00
ext4.h	ext4: move ext4_update_i_disksize() into mpage_map_and_submit_extent()	2014-04-11 10:35:17 -04:00
extents_status.c	ext4: fix 64-bit number truncation warning	2014-04-07 10:18:56 -04:00
extents_status.h	ext4: add ext4_es_store_pblock_status()	2014-02-19 20:15:15 -05:00
extents.c	ext4: always check ext4_ext_find_extent result	2014-04-13 15:41:13 -04:00
file.c	ext4: use i_size_read in ext4_unaligned_aio()	2014-04-12 12:45:25 -04:00
fsync.c	ext4: Fix fsync error handling after filesystem abort	2013-06-12 22:38:04 -04:00
hash.c	ext4: reduce one "if" comparison in ext4_dirhash()	2013-02-01 22:33:21 -05:00
ialloc.c	ext4: use prandom_u32() instead of get_random_bytes()	2013-11-08 00:14:53 -05:00
indirect.c	ext4: isolate ext4_extents.h file	2013-08-28 14:47:06 -04:00
inline.c	ext4: delete "set but not used" variables	2014-01-11 13:26:56 -05:00
inode.c	fs: disallow all fallocate operation on active swapfile	2014-04-12 10:05:37 -04:00
ioctl.c	ext4: clean up error handling in swap_inode_boot_loader()	2014-02-17 20:44:36 -05:00
Kconfig	ext4: fix Kconfig documentation for CONFIG_EXT4_DEBUG	2013-04-21 20:32:03 -04:00
Makefile	ext4: Remove CONFIG_EXT4_FS_XATTR	2012-12-10 16:30:43 -05:00
mballoc.c	ext4: silence sparse check warning for function ext4_trim_extent	2014-04-12 23:01:28 -04:00
mballoc.h	ext4: remove unused ac_ex_scanned	2014-02-20 13:32:10 -05:00
migrate.c	ext4: Fix misspellings using 'codespell' tool	2013-08-28 14:40:12 -04:00
mmp.c	ext4: use prandom_u32() instead of get_random_bytes()	2013-11-08 00:14:53 -05:00
move_extent.c	ext4: Add support FALLOC_FL_COLLAPSE_RANGE for fallocate	2014-02-23 15:18:59 -05:00
namei.c	ext4: add cross rename support	2014-04-01 17:08:44 +02:00
page-io.c	ext4: note the error in ext4_end_bio()	2014-04-07 10:54:20 -04:00
resize.c	ext4: fix online resize with a non-standard blocks per group setting	2014-02-15 22:42:25 -05:00
super.c	ext4: initialize multi-block allocator before checking block descriptors	2014-04-07 10:54:20 -04:00
symlink.c	ext4: Remove CONFIG_EXT4_FS_XATTR	2012-12-10 16:30:43 -05:00
truncate.h	ext4: move common truncate functions to header file	2011-06-27 19:16:04 -04:00
xattr_security.c	Merge branch 'for_linus' into for_linus_merged	2012-01-10 11:54:07 -05:00
xattr_trusted.c	ext2/3/4: delete unneeded includes of module.h	2012-01-09 13:52:10 +01:00
xattr_user.c	ext2/3/4: delete unneeded includes of module.h	2012-01-09 13:52:10 +01:00
xattr.c	ext4: fix jbd2 warning under heavy xattr load	2014-04-07 10:54:21 -04:00
xattr.h	ext4: each filesystem creates and uses its own mb_cache	2014-03-18 19:24:49 -04:00