2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-11 15:14:03 +08:00
Commit Graph

1808 Commits

Author SHA1 Message Date
Tapasweni Pathak
ffceca8c17 staging: iio: adc: use DIV_ROUND_UP
The kernel.h macro DIV_ROUND_UP performs the computation (((n) + (d) - 1) /
(d)) but is perhaps more readable.

Coccinelle script used :

// <smpl>
@haskernel@
@@
@depends on haskernel@
expression n,d;
@@
(
- (n + d - 1) / d
+ DIV_ROUND_UP(n,d)
|
- (n + (d - 1)) / d
+ DIV_ROUND_UP(n,d)
)
@depends on haskernel@
expression n,d;
@@
- DIV_ROUND_UP((n),d)
+ DIV_ROUND_UP(n,d)
@depends on haskernel@
expression n,d;
@@
- DIV_ROUND_UP(n,(d))
+ DIV_ROUND_UP(n,d)
// </smpl>

Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:19 +08:00
Darshana Padmadas
a2bc425bb3 Staging: iio: trigger: Break line over 80 characters
This patch breaks a line that is over 80 characters as reported by checkpatch.pl

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:09 +08:00
Darshana Padmadas
5c0ec98eba Staging: iio: trigger: Add module name information in Kconfig
This patch updates Kconfig with paragraphs that describe config symbol fully.
Found using checkpatch.pl.

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:09 +08:00
Heena Sirwani
d0e68ce199 Staging: iio: Documentation: Added check for sscanf return value.
The following patch fixes the following checkpatch.pl warning by adding
a check for sscanf return value.
WARNING: unchecked sscanf return value.

Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:08 +08:00
Heena Sirwani
edead9b1f9 Staging: iio: Documentation: Simplify error handling.
This also has the nice effect of removing of a temporary variable from stack and
fixes the following checkpatch.pl warning:
WARNING: Missing blank line after declarations.

Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:08 +08:00
Heena Sirwani
d1e5041345 Staging: iio: Documentation: Added missing blank line after declarations.
The following patch fixes the following checkpatch.pl warning by adding
a blank line after declarations.
WARNING: Missing blank line after declarations.

Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:08 +08:00
Tapasweni Pathak
30439b29b8 staging: iio: accel: Update Kconfig description with module name information
This patch fixes checkpatch.pl warning.
WARNING: please write a paragraph that describes the config symbol fully

Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:08 +08:00
Heena Sirwani
76ad1c42bb Staging: iio: gyro: Added description for config symbol.
The following patch fixes the checkpatch.pl warning by adding
description for a config symbol.
WARNING: please write a paragraph that describes the config symbol
fully.

Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:08 +08:00
Roxana Blaj
237d0bf9b5 staging: iio: addac: annotate Kconfig entries with module name information
This fixes the checkpatch.pl warning:
WARNING: please write a paragraph that describes the config symbol fully

Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:08 +08:00
Roxana Blaj
96cb9ab189 staging: iio: addac: fix line over 80 characters
This fixes checkpatch.pl warning:
WARNING: line over 80 characters

Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:08 +08:00
Melike Yurtoglu
79bdd48a7f staging: iio: Fix missing blank line warning
Fixes "Missing a blank line after declarations" checkpatch.pl warning in
Documentation/iio_utils.h

Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:08 +08:00
Melike Yurtoglu
ff39a252cd staging: iio: Fix missing blank line warning
Fixes "Missing a blank line after declarations" checkpatch.pl warning in
Documentation/generic_buffer.c

Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:08 +08:00
Darshana Padmadas
a724d08d01 Staging: iio: meter: Kconfig: Add module name information in Kconfig
This patch updates Kconfig with paragraphs that describe config symbol fully.
Found using checkpatch.pl.

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:08 +08:00
Roberta Dobrescu
3334155356 staging: iio: light: Remove unnecessary line continuations
This fixes the following checkpatch.pl warning:
WARNING: Avoid unnecessary line continuations

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:07 +08:00
Vaishali Thakkar
31c4670ff3 Staging: iio: adc: Fixing line over 80 characters
This patch fixes the following checkpatch.pl warning:

WARNING: line over 80 charcaters

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:07 +08:00
Vaishali Thakkar
29aeb33aca Staging: iio: adc: Fix line over 80 characters
This patch fixes the following checkpatch.pl warning:

WARNING: line over 80 characters

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:07 +08:00
Vaishali Thakkar
e3fe42b149 Staging: iio: adc: Refine delay computation
As per comment in function ad7280_delay, conversion delay may take up
to 250us. We cannot rely on msleep for this because it may sleep longer
than intended time for values less than 20ms, so use usleep_range instead.

Problem detected using checkpatch.pl.

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-20 10:29:07 +08:00
Vaishali Thakkar
e245b90418 Staging: iio: adc: Update Kconfig entries adding module name information
This patch fixes the following checkpatch.pl warning:

WARNING: please write a paragraph that describes the config symbol fully

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-02 10:06:10 -07:00
Vaishali Thakkar
3e4b49234d Staging: iio: adc: Add missing blank line
This fixes following checkpatch.pl warningi:

WARNING: Missing a blank line after declarations

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-02 10:06:10 -07:00
Roberta Dobrescu
97088bb3f7 staging: iio: resolver: Annotate Kconfig entries with module name information
This fixes the following checkpatch.pl warning:
WARNING: please write a paragraph that describes the config symbol fully

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-02 10:06:10 -07:00
Gulsah Kose
aa27f0ba0f staging: iio: addac: Combined seperated strings.
This patch fixes "quoted string split across lines" checkpatch.pl
warning in adt7316.c

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-02 10:04:18 -07:00
Gulsah Kose
042e0e463c staging: iio: accel: Removed unnecessary else expression.
This patch fixes "else is not generally useful after a break or return"
checkpatch.pl warning in adis16220_core.c

Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-02 10:04:18 -07:00
Darshana Padmadas
e09b142e2b Staging: iio: meter: Remove space before start of line
This patch removes spaces before start of the line reported by checkpatch.pl

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-02 10:04:18 -07:00
Darshana Padmadas
8594e07c3c Staging: iio: meter: Delete white spaces to make line shorter
Found using checkpatch warning.

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-02 10:04:18 -07:00
Darshana Padmadas
1592bfd203 Staging: iio: meter: Add blank line after declarations
This patch adds a blank line after declarations found by checkpatch warning.

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-02 10:02:08 -07:00
Darshana Padmadas
f6f0a3ab16 Staging: iio: meter: Add blank line after declarations.
This patch adds a blank line after declarations to fix checkpatch warning.

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-02 10:02:08 -07:00
Darshana Padmadas
b0604719c9 Staging: iio: meter: Add a blank line after declarations
Patch fixes warning and adds a blank line after declarations

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-02 10:02:08 -07:00
Roxana Blaj
15c643661b staging: iio: addac: remove unnecessary else
This fixes the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return

Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-10-02 10:02:08 -07:00
Aybuke Ozdemir
03c6eaa37a staging: iio: accel: Use __be16 instead of u16
This patch fixes these warning messages found by sparse:
drivers/staging/iio/accel/sca3000_ring.c:120:61: warning: incorrect type in argument 1 (different base types)
drivers/staging/iio/accel/sca3000_ring.c:120:61:    expected restricted __be16 const [usertype] *p
drivers/staging/iio/accel/sca3000_ring.c:120:61:    got unsigned short [usertype] *

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28 22:22:13 -04:00
Roberta Dobrescu
2bd7e245ea staging: iio: light: Add a blank line after declarations
This fixes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28 22:20:30 -04:00
Roberta Dobrescu
10b2e445aa staging: iio: light: Remove space before function pointer arguments
This fixes the following checkpatch.pl warning:
WARNING: Unnecessary space before function pointer arguments

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28 22:20:30 -04:00
Roberta Dobrescu
ad3e646c5b staging: iio: light: Fix quoted string split across lines
This fixes the following checkpatch.pl warning:
WARNING: quoted string split across lines

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28 22:20:30 -04:00
Roberta Dobrescu
f3f883b411 staging: iio: Add #include guards to header files
This patch adds #include guards in order to make the header files idempotent.

Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28 22:19:04 -04:00
Vaishali Thakkar
da96aecdc5 Staging: iio: Remove unnecessory immediate else after return statement
This patch fixes following checkpatch.pl warning:

WARNING: else is not generally useful after a break or return

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28 22:19:04 -04:00
Roxana Blaj
7bf6513eeb staging: iio: frequency: remove unnecessary semicolon
This fixes the checkpatch.pl warning:
WARNING: macros should not use a trailing semicolon

Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28 22:19:04 -04:00
Aybuke Ozdemir
f6077f4397 Staging: iio: light: Missing a blank line after declarations
This patch fixes these warning messages found by checkpatch.pl:
WARNING : Missing a blank line after declarations.

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28 22:17:23 -04:00
Roxana Blaj
580885415e staging: iio: frequency: add new line after declarations
This fixes the checkpatch.pl warning:
WARNING: Missing a blank line after declarations

Signed-off-by: Roxana Blaj <roxanagabriela10@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28 22:17:23 -04:00
Vaishali Thakkar
bb49a0f9b7 Staging: iio: adc: Use usleep_range instead of msleep
This patch fixes following checkpatch.pl warning:

WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-28 22:17:22 -04:00
Vaishali Thakkar
890d228fd9 Staging: iio: light: Use usleep_range instead of msleep
This patch fixes following checkpatch.pl warning:

WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt

Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-23 13:31:36 -07:00
Aybuke Ozdemir
020e46e06a Staging: iio: meter: Fix unnecessary space warning
Fixed "Unnecessary space before function pointer argument" checkpatch.pl
warning in ade7854.h

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-22 07:59:36 -07:00
Tapasweni Pathak
b5e736bd68 staging: iio: accel: remove else after return
This patch fixes checkpatch.pl warning in files of iio: accel
WARNING : else is not generally useful after a break or return

Signed-off-by: Tapasweni Pathak <tapaswenipathak@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-22 07:59:35 -07:00
Darshana Padmadas
0f8ad68b23 Staging: iio: adc: Fix else after return warning
This patch fixes checkpatch.pl warning:
WARNING: else is not generally useful after a break or return

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-22 07:58:48 -07:00
Darshana Padmadas
26cfea9e0e Staging: iio: adc: Fix quoted string split accross lines
This patch fixes the checkpatch warning:
WARNING: quoted string split across lines

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-22 07:58:48 -07:00
Darshana Padmadas
3ab7c7d48d Staging: iio: accel: Replace msleep with usleep for given range
This patch fixes checkpatch.pl warning:
WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt

As per Documentation/timers/timers-howto.txt usleep_range should be used
for sleeping for 10us-20ms

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-22 07:58:47 -07:00
Darshana Padmadas
5b12d0ac20 Staging: iio: adc: Fix warning prefer kmalloc_array over kmalloc
This patch fixes the checkpatch warning:
WARNING: Prefer kmalloc_array over kmalloc with multiply

kmalloc_array is preffered for allocating for arrays.

Signed-off-by: Darshana Padmadas <darshanapadmadas@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-22 07:58:47 -07:00
Greg Kroah-Hartman
d84a2b0d6f Merge 3.17-rc6 into staging-next.
We want the fixes in there, and it resolves a merge issue with
drivers/iio/accel/bma180.c

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-22 07:30:03 -07:00
Catalina Mocanu
288903f6b9 staging: iio: cdc: Don't put an else right after a return
This fixes the following checkpatch.pl warning:
WARNING: else is not generally useful after a break or return.

While at it, remove new line for symmetry with the rest of the code.

Signed-off-by: Catalina Mocanu <catalina.mocanu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19 17:49:39 -07:00
Catalina Mocanu
69869c01ff staging: iio: impedance-analyzer: add blank line after declaration
This fixes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations.

Signed-off-by: Catalina Mocanu <catalina.mocanu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19 16:25:09 -07:00
Catalina Mocanu
714ab9bdd3 staging: iio: trigger: add blank lines after declarations
This fixes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations.

Signed-off-by: Catalina Mocanu <catalina.mocanu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19 16:25:09 -07:00
Aybuke Ozdemir
8a689c1147 Staging: iio: resolver: Missing a blank line after declarations
This patch fixes these warning messages found by checkpatch.pl:
WARNING : Missing a blank line after declarations

Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2014-09-19 16:24:43 -07:00