Aaro Koskinen
c4fa7dfe57
staging: xgifb: main: move functions to avoid forward declarations
...
Move functions so that all forward declarations of internal functions
can be deleted.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25 17:26:27 -07:00
Aaro Koskinen
f45f59d763
staging: xgifb: delete unused register I/O functions
...
Delete unused register I/O functions.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25 17:26:27 -07:00
Aaro Koskinen
7a60d7728d
staging: xgifb: delete unused register I/O macros
...
Delete unused register I/O macros.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25 17:26:27 -07:00
Aaro Koskinen
65283d4296
staging: xgifb: replace setXGIIDXREG() with xgifb_reg_and_or()
...
Replace setXGIIDXREG() with xgifb_reg_and_or().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25 17:26:27 -07:00
Aaro Koskinen
b2135e4460
staging: xgifb: replace andXGIIDXREG() with xgifb_reg_and()
...
Replace andXGIIDXREG() with xgifb_reg_and().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25 17:26:27 -07:00
Aaro Koskinen
e67f4d4d9e
staging: xgifb: replace orXGIIDXREG() with xgifb_reg_or()
...
Replace orXGIIDXREG() with xgifb_reg_or().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25 17:26:26 -07:00
Aaro Koskinen
b6e2dc3948
staging: xgifb: replace outXGIIDXREG() with xgifb_reg_set()
...
Replace outXGIIDXREG() with xgifb_reg_set().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25 17:26:26 -07:00
Aaro Koskinen
7e119b750d
staging: xgifb: replace inXGIIDXREG() with xgifb_reg_get()
...
Replace inXGIIDXREG() with xgifb_reg_get().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25 17:26:25 -07:00
Aaro Koskinen
e3d5ceb090
staging: xgifb: replace outXGIREG() with outb()
...
Replace outXGIREG() with outb().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-04-25 17:26:25 -07:00
Lucas De Marchi
25985edced
Fix common misspellings
...
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi <lucas.demarchi@profusion.mobi>
2011-03-31 11:26:23 -03:00
Aaro Koskinen
459d2ea0b5
staging: xgifb: clean up register function variable names
...
Eliminate mixed case from variable names.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:34 -07:00
Aaro Koskinen
d0e23bdf3a
staging: xgifb: clean up register access types
...
Make type usage consistent. Use u8 for HW registers and unsigned for
bitmasks.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:34 -07:00
Aaro Koskinen
dc50556bbb
staging: xgifb: rename XGINew_SetRegAND() to xgifb_reg_and()
...
Rename XGINew_SetRegAND() to xgifb_reg_and().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:33 -07:00
Aaro Koskinen
ec9e5d3e73
staging: xgifb: rename XGINew_SetRegANDOR() to xgifb_reg_and_or()
...
Rename XGINew_SetRegANDOR() to xgifb_reg_and_or().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:33 -07:00
Aaro Koskinen
b9bf6e4e62
staging: xgifb: rename XGINew_SetRegOR() to xgifb_reg_or()
...
Rename XGINew_SetRegOR() to xgifb_reg_or().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:32 -07:00
Aaro Koskinen
58839b0194
staging: xgifb: rename XGINew_GetReg1() to xgifb_reg_get()
...
Rename XGINew_GetReg1() to xgifb_reg_get().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:32 -07:00
Aaro Koskinen
8104e32996
staging: xgifb: rename XGINew_SetReg1() to xgifb_reg_set()
...
Rename XGINew_SetReg1() to xgifb_reg_set().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:31 -07:00
Aaro Koskinen
3d2a60a29e
staging: xgifb: replace XGINew_SetReg4() with outl()
...
Replace XGINew_SetReg4() with outl().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:31 -07:00
Aaro Koskinen
efdf4ee78c
staging: xgifb: replace XGINew_SetReg3() with outb()
...
Replace XGINew_SetReg3() with outb().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:31 -07:00
Aaro Koskinen
f5b571fa24
staging: xgifb: replace XGINew_GetReg3() with inl()
...
Replace XGINew_GetReg3() with inl().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:30 -07:00
Aaro Koskinen
d8ad0a6d29
staging: xgifb: replace XGINew_GetReg2() with inb()
...
Replace XGINew_GetReg2() with inb().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:30 -07:00
Aaro Koskinen
b649c827a9
staging: xgifb: vb_util: delete commented-out code
...
Delete commented-out code.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:29 -07:00
Aaro Koskinen
0998e1db98
staging: xgifb: vb_util: include the .h file
...
Include the .h file and delete redundant definitions.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:29 -07:00
Aaro Koskinen
c45715bb95
staging: xgifb: replace DelayUS() with udelay()
...
Replace DelayUS() with udelay().
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:28 -07:00
Aaro Koskinen
c83c620afa
staging: xgifb: use mdelay() for millisecond delays
...
Use mdelay() instead of udelay() for millisecond delays.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:28 -07:00
Aaro Koskinen
8277cf87bd
staging: xgifb: delete incorrect I/O mapping
...
If the PCI device was disabled when the probe() routine started, the
driver will create 256 MB video memory mapping which is never used or
properly released. It's also unsafe as the size is incorrect for many
video cards. Deleting it also allows eliminating XGIvga_enable global
variable.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:27 -07:00
Aaro Koskinen
8a1ed67b51
staging: xgifb: delete redundant extended register access enable
...
The extended register access enable in !XGIvga_enabled case is not needed.
The driver has enabled the access unconditionally already earlier in
the routine.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:27 -07:00
Aaro Koskinen
38583420d3
staging: xgifb: delete unused LINUXBIOS code
...
Delete unused LINUXBIOS code.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:26 -07:00
Aaro Koskinen
0658733528
staging: xgifb: eliminate redudant chip type >= XG40 checks
...
Since all chips supported by the driver are >= XG40, these checks are
redundant and the code can be modified accordingly.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:26 -07:00
Aaro Koskinen
fd0ad4701a
staging: xgifb: delete dead code for chip types < XG40
...
XG40 is the first supported chip, so the code for earlier chips can
be dropped.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:25 -07:00
Aaro Koskinen
ebe7846def
staging: xgifb: delete unsupported chip types
...
The probe routine will fail if the chip is other than XG40..XG27, so
the other types can be dropped.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:25 -07:00
Aaro Koskinen
cc1e2398f7
staging: xgifb: vb_setmode: move functions to avoid forward declarations
...
Move functions to avoid forward declarations.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:24 -07:00
Aaro Koskinen
b9ebf5e591
staging: xgifb: vb_init: move functions to avoid forward declarations
...
Move functions to avoid forward declarations.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:24 -07:00
Aaro Koskinen
3f8214c33f
staging: xgifb: vb_ext: move functions to avoid forward declarations
...
Move functions to avoid forward declarations.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-14 11:52:23 -07:00
Aaro Koskinen
e0cc8a60c4
staging: xgifb: vb_init: make internal functions static
...
Make some internal functions static.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:55 -08:00
Aaro Koskinen
2b9edd3823
staging: xgifb: vb_init: delete unused functions
...
Delete unused functions.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:55 -08:00
Aaro Koskinen
81018f0038
staging: xgifb: vb_init: delete redundant declarations
...
Delete redundant declarations.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:55 -08:00
Aaro Koskinen
3d5375f470
staging: xgifb: vb_ext: make internal functions static
...
Make internal functions static.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:55 -08:00
Aaro Koskinen
f4dccca54a
staging: xgifb: vb_ext: delete unused functions
...
Delete unused functions.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:54 -08:00
Aaro Koskinen
eb51a91702
staging: xgifb: vb_ext: delete redundant declarations
...
Delete redundant declarations.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:54 -08:00
Aaro Koskinen
5e60b97cb1
staging: xgifb: vb_setmode: include the .h file
...
Include the file's .h file and delete the duplicate declarations from
the .c file.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:54 -08:00
Aaro Koskinen
063b9c4b89
staging: xgifb: vb_setmode: make internal functions static
...
Make internal functions static and remove unneeded forward declarations.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:53 -08:00
Aaro Koskinen
95befb5818
staging: xgifb: delete nomax module parameter
...
The parameter is not used.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:53 -08:00
Aaro Koskinen
dbbc2989a7
staging: xgifb: delete bIntegratedMMEnabled
...
bIntegratedMMEnabled is always true, so the field and checks can be
eliminated.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:52 -08:00
Aaro Koskinen
600a710b8b
staging: xgifb: delete bSkipSense
...
bSkipSense is always false, thus redundant.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:52 -08:00
Aaro Koskinen
66c2458c79
staging: xgifb: delete unused fields from xgi_hw_device_info
...
Delete unused fields from xgi_hw_device_info.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:52 -08:00
Aaro Koskinen
3259bb5a13
staging: xgifb: delete offscreen memory management
...
The offscreen memory area currently conflicts with the video memory
exported to the framebuffer layer. The driver does not utilize offscreen
memory, so the functionality can be deleted.
The patch also eliminates the one last memory leak when the driver
is unloaded.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:51 -08:00
Aaro Koskinen
83a8c24162
staging: xgifb: delete command queue selection/init
...
The driver does not utilize HW command queue in any way, so the code
can be dropped. The support for the default mode (MMIO) and AGP have
been disabled already anyway.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:51 -08:00
Aaro Koskinen
daa484ec96
staging: xgifb: delete HW cursor memory allocation
...
HW cursor area is not used in any way.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-09 16:02:51 -08:00
Aaro Koskinen
817368f19a
staging: xgifb: remove private ioctls
...
Drop the badly defined and broken private ioctl interface. Since the
driver is in staging, and some of the ioctls are clearly unsafe or not
even working, it's unlikely that there are any users.
Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-03-07 13:23:26 -08:00