Chuck Lever
5cfc822f3e
NFSD: Remove macros that are no longer used
...
Now that all the NFSv4 decoder functions have been converted to
make direct calls to the xdr helpers, remove the unused C macros.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:44 -05:00
Chuck Lever
d9b74bdac6
NFSD: Replace READ* macros in nfsd4_decode_compound()
...
And clean-up: Now that we have removed the DECODE_TAIL macro from
nfsd4_decode_compound(), we observe that there's no benefit for
nfsd4_decode_compound() to return nfs_ok or nfserr_bad_xdr only to
have its sole caller convert those values to one or zero,
respectively. Have nfsd4_decode_compound() return 1/0 instead.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:44 -05:00
Chuck Lever
3a237b4af5
NFSD: Make nfsd4_ops::opnum a u32
...
Avoid passing a "pointer to int" argument to xdr_stream_decode_u32.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:43 -05:00
Chuck Lever
2212036cad
NFSD: Replace READ* macros in nfsd4_decode_listxattrs()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:43 -05:00
Chuck Lever
403366a7e8
NFSD: Replace READ* macros in nfsd4_decode_setxattr()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:43 -05:00
Chuck Lever
830c71502a
NFSD: Replace READ* macros in nfsd4_decode_xattr_name()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:43 -05:00
Chuck Lever
3dfd0b0e15
NFSD: Replace READ* macros in nfsd4_decode_clone()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:43 -05:00
Chuck Lever
9d32b412fe
NFSD: Replace READ* macros in nfsd4_decode_seek()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:43 -05:00
Chuck Lever
2846bb0525
NFSD: Replace READ* macros in nfsd4_decode_offload_status()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:43 -05:00
Chuck Lever
f9a953fb36
NFSD: Replace READ* macros in nfsd4_decode_copy_notify()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:43 -05:00
Chuck Lever
e8febea719
NFSD: Replace READ* macros in nfsd4_decode_copy()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:43 -05:00
Chuck Lever
f49e4b4d58
NFSD: Replace READ* macros in nfsd4_decode_nl4_server()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:43 -05:00
Chuck Lever
6aef27aaea
NFSD: Replace READ* macros in nfsd4_decode_fallocate()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:42 -05:00
Chuck Lever
0d6467844d
NFSD: Replace READ* macros in nfsd4_decode_reclaim_complete()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:42 -05:00
Chuck Lever
c95f2ec349
NFSD: Replace READ* macros in nfsd4_decode_destroy_clientid()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:42 -05:00
Chuck Lever
b7a0c8f6e7
NFSD: Replace READ* macros in nfsd4_decode_test_stateid()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:42 -05:00
Chuck Lever
cf907b1132
NFSD: Replace READ* macros in nfsd4_decode_sequence()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:42 -05:00
Chuck Lever
53d70873e3
NFSD: Replace READ* macros in nfsd4_decode_secinfo_no_name()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:42 -05:00
Chuck Lever
645fcad371
NFSD: Replace READ* macros in nfsd4_decode_layoutreturn()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:42 -05:00
Chuck Lever
c8e88e3aa7
NFSD: Replace READ* macros in nfsd4_decode_layoutget()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:42 -05:00
Chuck Lever
5185980d8a
NFSD: Replace READ* macros in nfsd4_decode_layoutcommit()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:42 -05:00
Chuck Lever
044959715f
NFSD: Replace READ* macros in nfsd4_decode_getdeviceinfo()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:42 -05:00
Chuck Lever
aec387d590
NFSD: Replace READ* macros in nfsd4_decode_free_stateid()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:41 -05:00
Chuck Lever
94e254af1f
NFSD: Replace READ* macros in nfsd4_decode_destroy_session()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:41 -05:00
Chuck Lever
81243e3fe3
NFSD: Replace READ* macros in nfsd4_decode_create_session()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:41 -05:00
Chuck Lever
3a3f1fbacb
NFSD: Add a helper to decode channel_attrs4
...
De-duplicate some code.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:41 -05:00
Chuck Lever
10ff842281
NFSD: Add a helper to decode nfs_impl_id4
...
Refactor for clarity.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:41 -05:00
Chuck Lever
523ec6ed6f
NFSD: Add a helper to decode state_protect4_a
...
Refactor for clarity.
Also, remove a stale comment. Commit ed94164398
("nfsd: implement
machine credential support for some operations") added support for
SP4_MACH_CRED, so state_protect_a is no longer completely ignored.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:41 -05:00
Chuck Lever
547bfeb4cd
NFSD: Add a separate decoder for ssv_sp_parms
...
Refactor for clarity.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:41 -05:00
Chuck Lever
2548aa784d
NFSD: Add a separate decoder to handle state_protect_ops
...
Refactor for clarity and de-duplication of code.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:41 -05:00
Chuck Lever
571e0451c4
NFSD: Replace READ* macros in nfsd4_decode_bind_conn_to_session()
...
A dedicated sessionid4 decoder is introduced that will be used by
other operation decoders in subsequent patches.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:41 -05:00
Chuck Lever
0f81d96098
NFSD: Replace READ* macros in nfsd4_decode_backchannel_ctl()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:40 -05:00
Chuck Lever
1a99440807
NFSD: Replace READ* macros in nfsd4_decode_cb_sec()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:40 -05:00
Chuck Lever
a4a80c15ca
NFSD: Replace READ* macros in nfsd4_decode_release_lockowner()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:40 -05:00
Chuck Lever
244e2befcb
NFSD: Replace READ* macros in nfsd4_decode_write()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:40 -05:00
Chuck Lever
67cd453eed
NFSD: Replace READ* macros in nfsd4_decode_verify()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:40 -05:00
Chuck Lever
d1ca55149d
NFSD: Replace READ* macros in nfsd4_decode_setclientid_confirm()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:40 -05:00
Chuck Lever
92fa6c08c2
NFSD: Replace READ* macros in nfsd4_decode_setclientid()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:40 -05:00
Chuck Lever
44592fe947
NFSD: Replace READ* macros in nfsd4_decode_setattr()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:40 -05:00
Chuck Lever
d0abdae519
NFSD: Replace READ* macros in nfsd4_decode_secinfo()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:40 -05:00
Chuck Lever
d12f90458d
NFSD: Replace READ* macros in nfsd4_decode_renew()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:40 -05:00
Chuck Lever
ba881a0a53
NFSD: Replace READ* macros in nfsd4_decode_rename()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:39 -05:00
Chuck Lever
b7f5fbf219
NFSD: Replace READ* macros in nfsd4_decode_remove()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:39 -05:00
Chuck Lever
0dfaf2a371
NFSD: Replace READ* macros in nfsd4_decode_readdir()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:39 -05:00
Chuck Lever
3909c3bc60
NFSD: Replace READ* macros in nfsd4_decode_read()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:39 -05:00
Chuck Lever
a73bed9841
NFSD: Replace READ* macros in nfsd4_decode_putfh()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:39 -05:00
Chuck Lever
dca71651f0
NFSD: Replace READ* macros in nfsd4_decode_open_downgrade()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:39 -05:00
Chuck Lever
06bee693a1
NFSD: Replace READ* macros in nfsd4_decode_open_confirm()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:39 -05:00
Chuck Lever
61e5e0b3ec
NFSD: Replace READ* macros in nfsd4_decode_open()
...
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:39 -05:00
Chuck Lever
1708e50b01
NFSD: Add helper to decode OPEN's open_claim4 argument
...
Refactor for clarity.
Note that op_fname is the only instance of an NFSv4 filename stored
in a struct xdr_netobj. Convert it to a u32/char * pair so that the
new nfsd4_decode_filename() helper can be used.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2020-11-30 14:46:39 -05:00