mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-16 09:13:55 +08:00
scripts/setlocalversion: add more comments to -dirty flag detection
This script stumbled on the read-only source tree over again: -a2bb90a08c
("kbuild: fix delay in setlocalversion on readonly source") -cdf2bc632e
("scripts/setlocalversion on write-protected source tree") -8ef14c2c41
("Revert "scripts/setlocalversion: git: Make -dirty check more robust"") -ff64dd4857
("scripts/setlocalversion: Improve -dirty check with git-status --no-optional-locks") Add comments to clarify that this script should never ever try to write to the source tree. 'git describe --dirty' might look as a simple solution for appending the -dirty string, but we cannot use it because it creates the .git/index.lock file. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Reviewed-by: Nico Schottelius <nico-linuxsetlocalversion@schottelius.org>
This commit is contained in:
parent
a2be76a352
commit
ffaf62a805
@ -80,6 +80,10 @@ scm_version()
|
||||
fi
|
||||
|
||||
# Check for uncommitted changes.
|
||||
# This script must avoid any write attempt to the source tree,
|
||||
# which might be read-only.
|
||||
# You cannot use 'git describe --dirty' because it tries to
|
||||
# create .git/index.lock .
|
||||
# First, with git-status, but --no-optional-locks is only
|
||||
# supported in git >= 2.14, so fall back to git-diff-index if
|
||||
# it fails. Note that git-diff-index does not refresh the
|
||||
|
Loading…
Reference in New Issue
Block a user