renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-11-19 16:14:13 +08:00
Code

libahci: Fix bug in storing EM messages

Browse Source 
In function ahci_store_em_buffer(), if the input (signed char*) buffer
contains negative data, the constructed 32-bit long message data may
be wrong.

Signed-off-by: Harry Zhang <harry.zhang@amd.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
This commit is contained in:
Harry Zhang 2010-06-24 11:34:23 +08:00 committed by Jeff Garzik
parent 984bc9601f
commit f9ce889b8f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/ata/libahci.c
View File

@ -324,6 +324,7 @@ static ssize_t ahci_store_em_buffer(struct device *dev,
struct ahci_host_priv *hpriv = ap->host->private_data; struct ahci_host_priv *hpriv = ap->host->private_data;
void __iomem *mmio = hpriv->mmio; void __iomem *mmio = hpriv->mmio;
void __iomem *em_mmio = mmio + hpriv->em_loc; void __iomem *em_mmio = mmio + hpriv->em_loc;
const unsigned char *msg_buf = buf;
u32 em_ctl, msg; u32 em_ctl, msg;
unsigned long flags; unsigned long flags;
int i; int i;
@ -343,8 +344,8 @@ static ssize_t ahci_store_em_buffer(struct device *dev,
} }
for (i = 0; i < size; i += 4) { for (i = 0; i < size; i += 4) {
msg = buf[i] | buf[i + 1] << 8 | msg = msg_buf[i] | msg_buf[i + 1] << 8 |
buf[i + 2] << 16 | buf[i + 3] << 24; msg_buf[i + 2] << 16 | msg_buf[i + 3] << 24;
writel(msg, em_mmio + i); writel(msg, em_mmio + i);
} }