renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-23 12:43:55 +08:00
Code

hwrng: amd - Fix return value check in mod_init()

Browse Source 
In case of error, the function devm_kzalloc() or devm_ioport_map()
return NULL pointer not ERR_PTR(). The IS_ERR() test in the return
value check should be replaced with NULL test.

Fixes: 31b2a73c9c ("hwrng: amd - Migrate to managed API")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Wei Yongjun 2016-09-16 01:49:41 +00:00 committed by Herbert Xu
parent 06435f3437
commit f7eca278a8
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/char/hw_random/amd-rng.c
View File

@ -149,8 +149,8 @@ found:
return -EIO;
priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
if (IS_ERR(priv))
return PTR_ERR(priv);
if (!priv)
return -ENOMEM;
if (!devm_request_region(&pdev->dev, pmbase + PMBASE_OFFSET,
PMBASE_SIZE, DRV_NAME)) {
@ -161,9 +161,9 @@ found:
priv->iobase = devm_ioport_map(&pdev->dev, pmbase + PMBASE_OFFSET,
PMBASE_SIZE);
if (IS_ERR(priv->iobase)) {
if (!priv->iobase) {
pr_err(DRV_NAME "Cannot map ioport\n");
return PTR_ERR(priv->iobase);
return -ENOMEM;
}
amd_rng.priv = (unsigned long)priv;