renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-22 20:23:57 +08:00
Code

fb: adv7393: off by one in probe function

Browse Source 
This should be >= instead of >.  It's a little bit clearer if we just
get rid of the temporary variable and just use ARRAY_SIZE() directly.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
This commit is contained in:
Dan Carpenter 2016-07-15 14:08:17 +03:00 committed by Tomi Valkeinen
parent d4b9efa3b9
commit ee65e18206
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/video/fbdev/bfin_adv7393fb.c
View File

@ -375,7 +375,6 @@ static int bfin_adv7393_fb_probe(struct i2c_client *client,
{ {
int ret = 0; int ret = 0;
struct proc_dir_entry *entry; struct proc_dir_entry *entry;
int num_modes = ARRAY_SIZE(known_modes);
struct adv7393fb_device *fbdev = NULL; struct adv7393fb_device *fbdev = NULL;
@ -384,7 +383,7 @@ static int bfin_adv7393_fb_probe(struct i2c_client *client,
return -EINVAL; return -EINVAL;
} }
if (mode > num_modes) { if (mode >= ARRAY_SIZE(known_modes)) {
dev_err(&client->dev, "mode %d: not supported", mode); dev_err(&client->dev, "mode %d: not supported", mode);
return -EFAULT; return -EFAULT;
} }