renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-11 23:23:52 +08:00
Code

ixgbevf: Fix multiple issues in ixgbevf_get/set_ringparam

Browse Source 
In ixgbevf_get_ringparam we could run into a NULL pointer dereference
if the rings were not allocated when we attempted the call.  To prevent
that we can just access the tx/rx_ring_count values instead of attempting
to access the rings to get the count.

This change corrects a memory leak and memory corruption in
ixgbevf_set_ringparam.

The memory leak was due to us not freeing the resources from the ring
before overwriting them.  This change corrects the memory leak by making
certain to call ixgbe_free_tx/rx_resources on the rings prior to freeing
them.

The memory corruption was because we were replacing the rings but not
updating the q_vectors.  It addresses the memory corruption by leaving the
rings in place and instead just copying the contents of the new rings into
the existing rings.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Acked-by: Greg Rose <gregory.v.rose@intel.com>
Tested-by: Sibai Li <sibai.li@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
This commit is contained in:
Alexander Duyck 2012-07-19 00:18:05 +00:00 committed by Jeff Kirsher
parent 70a10e258c
commit eb022d058f
1 changed files with 85 additions and 72 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

157
drivers/net/ethernet/intel/ixgbevf/ethtool.c
View File

@ -284,13 +284,11 @@ static void ixgbevf_get_ringparam(struct net_device *netdev,
struct ethtool_ringparam *ring) struct ethtool_ringparam *ring)
{ {
struct ixgbevf_adapter *adapter = netdev_priv(netdev); struct ixgbevf_adapter *adapter = netdev_priv(netdev);
struct ixgbevf_ring *tx_ring = adapter->tx_ring;
struct ixgbevf_ring *rx_ring = adapter->rx_ring;
ring->rx_max_pending = IXGBEVF_MAX_RXD; ring->rx_max_pending = IXGBEVF_MAX_RXD;
ring->tx_max_pending = IXGBEVF_MAX_TXD; ring->tx_max_pending = IXGBEVF_MAX_TXD;
ring->rx_pending = rx_ring->count; ring->rx_pending = adapter->rx_ring_count;
ring->tx_pending = tx_ring->count; ring->tx_pending = adapter->tx_ring_count;
} }
static int ixgbevf_set_ringparam(struct net_device *netdev, static int ixgbevf_set_ringparam(struct net_device *netdev,
@ -298,33 +296,28 @@ static int ixgbevf_set_ringparam(struct net_device *netdev,
{ {
struct ixgbevf_adapter *adapter = netdev_priv(netdev); struct ixgbevf_adapter *adapter = netdev_priv(netdev);
struct ixgbevf_ring *tx_ring = NULL, *rx_ring = NULL; struct ixgbevf_ring *tx_ring = NULL, *rx_ring = NULL;
int i, err = 0;
u32 new_rx_count, new_tx_count; u32 new_rx_count, new_tx_count;
int i, err = 0;
if ((ring->rx_mini_pending) || (ring->rx_jumbo_pending)) if ((ring->rx_mini_pending) || (ring->rx_jumbo_pending))
return -EINVAL; return -EINVAL;
new_rx_count = max(ring->rx_pending, (u32)IXGBEVF_MIN_RXD); new_tx_count = max_t(u32, ring->tx_pending, IXGBEVF_MIN_TXD);
new_rx_count = min(new_rx_count, (u32)IXGBEVF_MAX_RXD); new_tx_count = min_t(u32, new_tx_count, IXGBEVF_MAX_TXD);
new_rx_count = ALIGN(new_rx_count, IXGBE_REQ_RX_DESCRIPTOR_MULTIPLE);
new_tx_count = max(ring->tx_pending, (u32)IXGBEVF_MIN_TXD);
new_tx_count = min(new_tx_count, (u32)IXGBEVF_MAX_TXD);
new_tx_count = ALIGN(new_tx_count, IXGBE_REQ_TX_DESCRIPTOR_MULTIPLE); new_tx_count = ALIGN(new_tx_count, IXGBE_REQ_TX_DESCRIPTOR_MULTIPLE);
if ((new_tx_count == adapter->tx_ring->count) && new_rx_count = max_t(u32, ring->rx_pending, IXGBEVF_MIN_RXD);
(new_rx_count == adapter->rx_ring->count)) { new_rx_count = min_t(u32, new_rx_count, IXGBEVF_MAX_RXD);
/* nothing to do */ new_rx_count = ALIGN(new_rx_count, IXGBE_REQ_RX_DESCRIPTOR_MULTIPLE);
/* if nothing to do return success */
if ((new_tx_count == adapter->tx_ring_count) &&
(new_rx_count == adapter->rx_ring_count))
return 0; return 0;
}
while (test_and_set_bit(__IXGBEVF_RESETTING, &adapter->state)) while (test_and_set_bit(__IXGBEVF_RESETTING, &adapter->state))
msleep(1); usleep_range(1000, 2000);
/*
* If the adapter isn't up and running then just set the
* new parameters and scurry for the exits.
*/
if (!netif_running(adapter->netdev)) { if (!netif_running(adapter->netdev)) {
for (i = 0; i < adapter->num_tx_queues; i++) for (i = 0; i < adapter->num_tx_queues; i++)
adapter->tx_ring[i].count = new_tx_count; adapter->tx_ring[i].count = new_tx_count;
@ -335,78 +328,98 @@ static int ixgbevf_set_ringparam(struct net_device *netdev,
goto clear_reset; goto clear_reset;
} }
tx_ring = kcalloc(adapter->num_tx_queues, if (new_tx_count != adapter->tx_ring_count) {
sizeof(struct ixgbevf_ring), GFP_KERNEL); tx_ring = vmalloc(adapter->num_tx_queues * sizeof(*tx_ring));
if (!tx_ring) { if (!tx_ring) {
err = -ENOMEM; err = -ENOMEM;
goto clear_reset; goto clear_reset;
} }
rx_ring = kcalloc(adapter->num_rx_queues, for (i = 0; i < adapter->num_tx_queues; i++) {
sizeof(struct ixgbevf_ring), GFP_KERNEL); /* clone ring and setup updated count */
if (!rx_ring) { tx_ring[i] = adapter->tx_ring[i];
err = -ENOMEM; tx_ring[i].count = new_tx_count;
goto err_rx_setup; err = ixgbevf_setup_tx_resources(adapter, &tx_ring[i]);
} if (!err)
continue;
ixgbevf_down(adapter);
memcpy(tx_ring, adapter->tx_ring,
adapter->num_tx_queues * sizeof(struct ixgbevf_ring));
for (i = 0; i < adapter->num_tx_queues; i++) {
tx_ring[i].count = new_tx_count;
err = ixgbevf_setup_tx_resources(adapter, &tx_ring[i]);
if (err) {
while (i) { while (i) {
i--; i--;
ixgbevf_free_tx_resources(adapter, &tx_ring[i]); ixgbevf_free_tx_resources(adapter, &tx_ring[i]);
} }
goto err_tx_ring_setup;
vfree(tx_ring);
tx_ring = NULL;
goto clear_reset;
} }
} }
memcpy(rx_ring, adapter->rx_ring, if (new_rx_count != adapter->rx_ring_count) {
adapter->num_rx_queues * sizeof(struct ixgbevf_ring)); rx_ring = vmalloc(adapter->num_rx_queues * sizeof(*rx_ring));
for (i = 0; i < adapter->num_rx_queues; i++) { if (!rx_ring) {
rx_ring[i].count = new_rx_count; err = -ENOMEM;
err = ixgbevf_setup_rx_resources(adapter, &rx_ring[i]); goto clear_reset;
if (err) { }
for (i = 0; i < adapter->num_rx_queues; i++) {
/* clone ring and setup updated count */
rx_ring[i] = adapter->rx_ring[i];
rx_ring[i].count = new_rx_count;
err = ixgbevf_setup_rx_resources(adapter, &rx_ring[i]);
if (!err)
continue;
while (i) { while (i) {
i--; i--;
ixgbevf_free_rx_resources(adapter, &rx_ring[i]); ixgbevf_free_rx_resources(adapter, &rx_ring[i]);
} }
goto err_rx_ring_setup;
vfree(rx_ring);
rx_ring = NULL;
goto clear_reset;
} }
} }
/* /* bring interface down to prepare for update */
* Only switch to new rings if all the prior allocations ixgbevf_down(adapter);
* and ring setups have succeeded.
*/
kfree(adapter->tx_ring);
adapter->tx_ring = tx_ring;
adapter->tx_ring_count = new_tx_count;
kfree(adapter->rx_ring); /* Tx */
adapter->rx_ring = rx_ring; if (tx_ring) {
adapter->rx_ring_count = new_rx_count; for (i = 0; i < adapter->num_tx_queues; i++) {
ixgbevf_free_tx_resources(adapter,
&adapter->tx_ring[i]);
adapter->tx_ring[i] = tx_ring[i];
}
adapter->tx_ring_count = new_tx_count;
/* success! */ vfree(tx_ring);
tx_ring = NULL;
}
/* Rx */
if (rx_ring) {
for (i = 0; i < adapter->num_rx_queues; i++) {
ixgbevf_free_rx_resources(adapter,
&adapter->rx_ring[i]);
adapter->rx_ring[i] = rx_ring[i];
}
adapter->rx_ring_count = new_rx_count;
vfree(rx_ring);
rx_ring = NULL;
}
/* restore interface using new values */
ixgbevf_up(adapter); ixgbevf_up(adapter);
goto clear_reset;
err_rx_ring_setup:
for(i = 0; i < adapter->num_tx_queues; i++)
ixgbevf_free_tx_resources(adapter, &tx_ring[i]);
err_tx_ring_setup:
kfree(rx_ring);
err_rx_setup:
kfree(tx_ring);
clear_reset: clear_reset:
/* free Tx resources if Rx error is encountered */
if (tx_ring) {
for (i = 0; i < adapter->num_tx_queues; i++)
ixgbevf_free_tx_resources(adapter, &tx_ring[i]);
vfree(tx_ring);
}
clear_bit(__IXGBEVF_RESETTING, &adapter->state); clear_bit(__IXGBEVF_RESETTING, &adapter->state);
return err; return err;
} }