renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-20 11:13:58 +08:00
Code

ACPI/IORT: Fix iort_get_platform_device_domain() uninitialized pointer value

Browse Source 
Running the Clang static analyzer on IORT code detected the following
error:

Logic error: Branch condition evaluates to a garbage value

in

iort_get_platform_device_domain()

If the named component associated with a given device has no IORT
mappings, iort_get_platform_device_domain() exits its MSI mapping loop
with msi_parent pointer containing garbage, which can lead to erroneous
code path execution.

Initialize the msi_parent pointer, fixing the bug.

Fixes: d4f54a1866 ("ACPI: platform: setup MSI domain for ACPI based
platform device")
Reported-by: Patrick Bellasi <patrick.bellasi@arm.com>
Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
Acked-by: Will Deacon <will.deacon@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
This commit is contained in:
Lorenzo Pieralisi 2018-11-29 09:55:59 +00:00 committed by Catalin Marinas
parent 874bfc6e54
commit ea2412dc21
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/acpi/arm64/iort.c
View File

@ -700,7 +700,7 @@ static void iort_set_device_domain(struct device *dev,
*/ */
static struct irq_domain *iort_get_platform_device_domain(struct device *dev) static struct irq_domain *iort_get_platform_device_domain(struct device *dev)
{ {
struct acpi_iort_node *node, *msi_parent; struct acpi_iort_node *node, *msi_parent = NULL;
struct fwnode_handle *iort_fwnode; struct fwnode_handle *iort_fwnode;
struct acpi_iort_its_group *its; struct acpi_iort_its_group *its;
int i; int i;