renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-01 18:24:23 +08:00
Code

staging: tidspbridge: move the dereference below the NULL test

Browse Source 
The dereference should be moved below the NULL test.

spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Wei Yongjun 2012-09-07 14:59:15 +08:00 committed by Greg Kroah-Hartman
parent 5da80ee8d8
commit e89a3370b0
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/tidspbridge/core/chnl_sm.c
View File

@ -94,7 +94,7 @@ int bridge_chnl_add_io_req(struct chnl_object *chnl_obj, void *host_buf,
struct dev_object *dev_obj; struct dev_object *dev_obj;
u8 dw_state; u8 dw_state;
bool is_eos; bool is_eos;
struct chnl_mgr *chnl_mgr_obj = pchnl->chnl_mgr_obj; struct chnl_mgr *chnl_mgr_obj;
u8 *host_sys_buf = NULL; u8 *host_sys_buf = NULL;
bool sched_dpc = false; bool sched_dpc = false;
u16 mb_val = 0; u16 mb_val = 0;
@ -153,6 +153,7 @@ func_cont:
* If DPC is scheduled in process context (iosm_schedule) and any * If DPC is scheduled in process context (iosm_schedule) and any
* non-mailbox interrupt occurs, that DPC will run and break CS. Hence * non-mailbox interrupt occurs, that DPC will run and break CS. Hence
* we disable ALL DPCs. We will try to disable ONLY IO DPC later. */ * we disable ALL DPCs. We will try to disable ONLY IO DPC later. */
chnl_mgr_obj = pchnl->chnl_mgr_obj;
spin_lock_bh(&chnl_mgr_obj->chnl_mgr_lock); spin_lock_bh(&chnl_mgr_obj->chnl_mgr_lock);
omap_mbox_disable_irq(dev_ctxt->mbox, IRQ_RX); omap_mbox_disable_irq(dev_ctxt->mbox, IRQ_RX);
if (pchnl->chnl_type == CHNL_PCPY) { if (pchnl->chnl_type == CHNL_PCPY) {