renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-11-18 07:35:12 +08:00
Code

block: make blkdev_get/put() handle exclusive access

Browse Source 
Over time, block layer has accumulated a set of APIs dealing with bdev
open, close, claim and release.

* blkdev_get/put() are the primary open and close functions.

* bd_claim/release() deal with exclusive open.

* open/close_bdev_exclusive() are combination of open and claim and
  the other way around, respectively.

* bd_link/unlink_disk_holder() to create and remove holder/slave
  symlinks.

* open_by_devnum() wraps bdget() + blkdev_get().

The interface is a bit confusing and the decoupling of open and claim
makes it impossible to properly guarantee exclusive access as
in-kernel open + claim sequence can disturb the existing exclusive
open even before the block layer knows the current open if for another
exclusive access.  Reorganize the interface such that,

* blkdev_get() is extended to include exclusive access management.
  @holder argument is added and, if is @FMODE_EXCL specified, it will
  gain exclusive access atomically w.r.t. other exclusive accesses.

* blkdev_put() is similarly extended.  It now takes @mode argument and
  if @FMODE_EXCL is set, it releases an exclusive access.  Also, when
  the last exclusive claim is released, the holder/slave symlinks are
  removed automatically.

* bd_claim/release() and close_bdev_exclusive() are no longer
  necessary and either made static or removed.

* bd_link_disk_holder() remains the same but bd_unlink_disk_holder()
  is no longer necessary and removed.

* open_bdev_exclusive() becomes a simple wrapper around lookup_bdev()
  and blkdev_get().  It also has an unexpected extra bdev_read_only()
  test which probably should be moved into blkdev_get().

* open_by_devnum() is modified to take @holder argument and pass it to
  blkdev_get().

Most of bdev open/close operations are unified into blkdev_get/put()
and most exclusive accesses are tested atomically at the open time (as
it should).  This cleans up code and removes some, both valid and
invalid, but unnecessary all the same, corner cases.

open_bdev_exclusive() and open_by_devnum() can use further cleanup -
rename to blkdev_get_by_path() and blkdev_get_by_devt() and drop
special features.  Well, let's leave them for another day.

Most conversions are straight-forward.  drbd conversion is a bit more
involved as there was some reordering, but the logic should stay the
same.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Neil Brown <neilb@suse.de>
Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Acked-by: Mike Snitzer <snitzer@redhat.com>
Acked-by: Philipp Reisner <philipp.reisner@linbit.com>
Cc: Peter Osterlund <petero2@telia.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: dm-devel@redhat.com
Cc: drbd-dev@lists.linbit.com
Cc: Leo Chen <leochen@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Steven Whitehouse <swhiteho@redhat.com>
Cc: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: Joern Engel <joern@logfs.org>
Cc: reiserfs-devel@vger.kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Tejun Heo 2010-11-13 11:55:17 +01:00
parent e09b457bdb
commit e525fd89d3
26 changed files with 163 additions and 319 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
block/ioctl.c
View File

@ -294,11 +294,12 @@ int blkdev_ioctl(struct block_device *bdev, fmode_t mode, unsigned cmd,
return -EINVAL; return -EINVAL;
if (get_user(n, (int __user *) arg)) if (get_user(n, (int __user *) arg))
return -EFAULT; return -EFAULT;
if (!(mode & FMODE_EXCL) && bd_claim(bdev, &bdev) < 0) if (!(mode & FMODE_EXCL) &&
blkdev_get(bdev, mode | FMODE_EXCL, &bdev) < 0)
return -EBUSY; return -EBUSY;
ret = set_blocksize(bdev, n); ret = set_blocksize(bdev, n);
if (!(mode & FMODE_EXCL)) if (!(mode & FMODE_EXCL))
bd_release(bdev); blkdev_put(bdev, mode | FMODE_EXCL);
return ret; return ret;
case BLKPG: case BLKPG:
ret = blkpg_ioctl(bdev, (struct blkpg_ioctl_arg __user *) arg); ret = blkpg_ioctl(bdev, (struct blkpg_ioctl_arg __user *) arg);

2
drivers/block/drbd/drbd_int.h
View File

@ -923,8 +923,6 @@ struct drbd_md {
struct drbd_backing_dev { struct drbd_backing_dev {
struct block_device *backing_bdev; struct block_device *backing_bdev;
struct block_device *md_bdev; struct block_device *md_bdev;
struct file *lo_file;
struct file *md_file;
struct drbd_md md; struct drbd_md md;
struct disk_conf dc; /* The user provided config... */ struct disk_conf dc; /* The user provided config... */
sector_t known_size; /* last known size of that backing device */ sector_t known_size; /* last known size of that backing device */

7
drivers/block/drbd/drbd_main.c
View File

@ -3361,11 +3361,8 @@ void drbd_free_bc(struct drbd_backing_dev *ldev)
if (ldev == NULL) if (ldev == NULL)
return; return;
bd_release(ldev->backing_bdev); blkdev_put(ldev->backing_bdev, FMODE_READ | FMODE_WRITE | FMODE_EXCL);
bd_release(ldev->md_bdev); blkdev_put(ldev->md_bdev, FMODE_READ | FMODE_WRITE | FMODE_EXCL);
fput(ldev->lo_file);
fput(ldev->md_file);
kfree(ldev); kfree(ldev);
} }

103
drivers/block/drbd/drbd_nl.c
View File

@ -855,7 +855,7 @@ static int drbd_nl_disk_conf(struct drbd_conf *mdev, struct drbd_nl_cfg_req *nlp
sector_t max_possible_sectors; sector_t max_possible_sectors;
sector_t min_md_device_sectors; sector_t min_md_device_sectors;
struct drbd_backing_dev *nbc = NULL; /* new_backing_conf */ struct drbd_backing_dev *nbc = NULL; /* new_backing_conf */
struct inode *inode, *inode2; struct block_device *bdev;
struct lru_cache *resync_lru = NULL; struct lru_cache *resync_lru = NULL;
union drbd_state ns, os; union drbd_state ns, os;
unsigned int max_seg_s; unsigned int max_seg_s;
@ -902,46 +902,40 @@ static int drbd_nl_disk_conf(struct drbd_conf *mdev, struct drbd_nl_cfg_req *nlp
} }
} }
nbc->lo_file = filp_open(nbc->dc.backing_dev, O_RDWR, 0); bdev = open_bdev_exclusive(nbc->dc.backing_dev,
if (IS_ERR(nbc->lo_file)) { FMODE_READ | FMODE_WRITE, mdev);
if (IS_ERR(bdev)) {
dev_err(DEV, "open(\"%s\") failed with %ld\n", nbc->dc.backing_dev, dev_err(DEV, "open(\"%s\") failed with %ld\n", nbc->dc.backing_dev,
PTR_ERR(nbc->lo_file)); PTR_ERR(bdev));
nbc->lo_file = NULL;
retcode = ERR_OPEN_DISK; retcode = ERR_OPEN_DISK;
goto fail; goto fail;
} }
nbc->backing_bdev = bdev;
inode = nbc->lo_file->f_dentry->d_inode; /*
* meta_dev_idx >= 0: external fixed size, possibly multiple
if (!S_ISBLK(inode->i_mode)) { * drbd sharing one meta device. TODO in that case, paranoia
retcode = ERR_DISK_NOT_BDEV; * check that [md_bdev, meta_dev_idx] is not yet used by some
goto fail; * other drbd minor! (if you use drbd.conf + drbdadm, that
} * should check it for you already; but if you don't, or
* someone fooled it, we need to double check here)
nbc->md_file = filp_open(nbc->dc.meta_dev, O_RDWR, 0); */
if (IS_ERR(nbc->md_file)) { bdev = open_bdev_exclusive(nbc->dc.meta_dev,
FMODE_READ | FMODE_WRITE,
(nbc->dc.meta_dev_idx < 0) ?
(void *)mdev : (void *)drbd_m_holder);
if (IS_ERR(bdev)) {
dev_err(DEV, "open(\"%s\") failed with %ld\n", nbc->dc.meta_dev, dev_err(DEV, "open(\"%s\") failed with %ld\n", nbc->dc.meta_dev,
PTR_ERR(nbc->md_file)); PTR_ERR(bdev));
nbc->md_file = NULL;
retcode = ERR_OPEN_MD_DISK; retcode = ERR_OPEN_MD_DISK;
goto fail; goto fail;
} }
nbc->md_bdev = bdev;
inode2 = nbc->md_file->f_dentry->d_inode; if ((nbc->backing_bdev == nbc->md_bdev) !=
(nbc->dc.meta_dev_idx == DRBD_MD_INDEX_INTERNAL ||
if (!S_ISBLK(inode2->i_mode)) { nbc->dc.meta_dev_idx == DRBD_MD_INDEX_FLEX_INT)) {
retcode = ERR_MD_NOT_BDEV; retcode = ERR_MD_IDX_INVALID;
goto fail;
}
nbc->backing_bdev = inode->i_bdev;
if (bd_claim(nbc->backing_bdev, mdev)) {
printk(KERN_ERR "drbd: bd_claim(%p,%p); failed [%p;%p;%u]\n",
nbc->backing_bdev, mdev,
nbc->backing_bdev->bd_holder,
nbc->backing_bdev->bd_contains->bd_holder,
nbc->backing_bdev->bd_holders);
retcode = ERR_BDCLAIM_DISK;
goto fail; goto fail;
} }
@ -950,28 +944,7 @@ static int drbd_nl_disk_conf(struct drbd_conf *mdev, struct drbd_nl_cfg_req *nlp
offsetof(struct bm_extent, lce)); offsetof(struct bm_extent, lce));
if (!resync_lru) { if (!resync_lru) {
retcode = ERR_NOMEM; retcode = ERR_NOMEM;
goto release_bdev_fail; goto fail;
}
/* meta_dev_idx >= 0: external fixed size,
* possibly multiple drbd sharing one meta device.
* TODO in that case, paranoia check that [md_bdev, meta_dev_idx] is
* not yet used by some other drbd minor!
* (if you use drbd.conf + drbdadm,
* that should check it for you already; but if you don't, or someone
* fooled it, we need to double check here) */
nbc->md_bdev = inode2->i_bdev;
if (bd_claim(nbc->md_bdev, (nbc->dc.meta_dev_idx < 0) ? (void *)mdev
: (void *) drbd_m_holder)) {
retcode = ERR_BDCLAIM_MD_DISK;
goto release_bdev_fail;
}
if ((nbc->backing_bdev == nbc->md_bdev) !=
(nbc->dc.meta_dev_idx == DRBD_MD_INDEX_INTERNAL ||
nbc->dc.meta_dev_idx == DRBD_MD_INDEX_FLEX_INT)) {
retcode = ERR_MD_IDX_INVALID;
goto release_bdev2_fail;
} }
/* RT - for drbd_get_max_capacity() DRBD_MD_INDEX_FLEX_INT */ /* RT - for drbd_get_max_capacity() DRBD_MD_INDEX_FLEX_INT */
@ -982,7 +955,7 @@ static int drbd_nl_disk_conf(struct drbd_conf *mdev, struct drbd_nl_cfg_req *nlp
(unsigned long long) drbd_get_max_capacity(nbc), (unsigned long long) drbd_get_max_capacity(nbc),
(unsigned long long) nbc->dc.disk_size); (unsigned long long) nbc->dc.disk_size);
retcode = ERR_DISK_TO_SMALL; retcode = ERR_DISK_TO_SMALL;
goto release_bdev2_fail; goto fail;
} }
if (nbc->dc.meta_dev_idx < 0) { if (nbc->dc.meta_dev_idx < 0) {
@ -999,7 +972,7 @@ static int drbd_nl_disk_conf(struct drbd_conf *mdev, struct drbd_nl_cfg_req *nlp
dev_warn(DEV, "refusing attach: md-device too small, " dev_warn(DEV, "refusing attach: md-device too small, "
"at least %llu sectors needed for this meta-disk type\n", "at least %llu sectors needed for this meta-disk type\n",
(unsigned long long) min_md_device_sectors); (unsigned long long) min_md_device_sectors);
goto release_bdev2_fail; goto fail;
} }
/* Make sure the new disk is big enough /* Make sure the new disk is big enough
@ -1007,7 +980,7 @@ static int drbd_nl_disk_conf(struct drbd_conf *mdev, struct drbd_nl_cfg_req *nlp
if (drbd_get_max_capacity(nbc) < if (drbd_get_max_capacity(nbc) <
drbd_get_capacity(mdev->this_bdev)) { drbd_get_capacity(mdev->this_bdev)) {
retcode = ERR_DISK_TO_SMALL; retcode = ERR_DISK_TO_SMALL;
goto release_bdev2_fail; goto fail;
} }
nbc->known_size = drbd_get_capacity(nbc->backing_bdev); nbc->known_size = drbd_get_capacity(nbc->backing_bdev);
@ -1030,7 +1003,7 @@ static int drbd_nl_disk_conf(struct drbd_conf *mdev, struct drbd_nl_cfg_req *nlp
retcode = _drbd_request_state(mdev, NS(disk, D_ATTACHING), CS_VERBOSE); retcode = _drbd_request_state(mdev, NS(disk, D_ATTACHING), CS_VERBOSE);
drbd_resume_io(mdev); drbd_resume_io(mdev);
if (retcode < SS_SUCCESS) if (retcode < SS_SUCCESS)
goto release_bdev2_fail; goto fail;
if (!get_ldev_if_state(mdev, D_ATTACHING)) if (!get_ldev_if_state(mdev, D_ATTACHING))
goto force_diskless; goto force_diskless;
@ -1264,18 +1237,14 @@ static int drbd_nl_disk_conf(struct drbd_conf *mdev, struct drbd_nl_cfg_req *nlp
force_diskless: force_diskless:
drbd_force_state(mdev, NS(disk, D_DISKLESS)); drbd_force_state(mdev, NS(disk, D_DISKLESS));
drbd_md_sync(mdev); drbd_md_sync(mdev);
release_bdev2_fail:
if (nbc)
bd_release(nbc->md_bdev);
release_bdev_fail:
if (nbc)
bd_release(nbc->backing_bdev);
fail: fail:
if (nbc) { if (nbc) {
if (nbc->lo_file) if (nbc->backing_bdev)
fput(nbc->lo_file); blkdev_put(nbc->backing_bdev,
if (nbc->md_file) FMODE_READ | FMODE_WRITE | FMODE_EXCL);
fput(nbc->md_file); if (nbc->md_bdev)
blkdev_put(nbc->md_bdev,
FMODE_READ | FMODE_WRITE | FMODE_EXCL);
kfree(nbc); kfree(nbc);
} }
lc_destroy(resync_lru); lc_destroy(resync_lru);

22
drivers/block/pktcdvd.c
View File

@ -2296,15 +2296,12 @@ static int pkt_open_dev(struct pktcdvd_device *pd, fmode_t write)
* so bdget() can't fail. * so bdget() can't fail.
*/ */
bdget(pd->bdev->bd_dev); bdget(pd->bdev->bd_dev);
if ((ret = blkdev_get(pd->bdev, FMODE_READ))) if ((ret = blkdev_get(pd->bdev, FMODE_READ | FMODE_EXCL, pd)))
goto out; goto out;
if ((ret = bd_claim(pd->bdev, pd)))
goto out_putdev;
if ((ret = pkt_get_last_written(pd, &lba))) { if ((ret = pkt_get_last_written(pd, &lba))) {
printk(DRIVER_NAME": pkt_get_last_written failed\n"); printk(DRIVER_NAME": pkt_get_last_written failed\n");
goto out_unclaim; goto out_putdev;
} }
set_capacity(pd->disk, lba << 2); set_capacity(pd->disk, lba << 2);
@ -2314,7 +2311,7 @@ static int pkt_open_dev(struct pktcdvd_device *pd, fmode_t write)
q = bdev_get_queue(pd->bdev); q = bdev_get_queue(pd->bdev);
if (write) { if (write) {
if ((ret = pkt_open_write(pd))) if ((ret = pkt_open_write(pd)))
goto out_unclaim; goto out_putdev;
/* /*
* Some CDRW drives can not handle writes larger than one packet, * Some CDRW drives can not handle writes larger than one packet,
* even if the size is a multiple of the packet size. * even if the size is a multiple of the packet size.
@ -2329,23 +2326,21 @@ static int pkt_open_dev(struct pktcdvd_device *pd, fmode_t write)
} }
if ((ret = pkt_set_segment_merging(pd, q))) if ((ret = pkt_set_segment_merging(pd, q)))
goto out_unclaim; goto out_putdev;
if (write) { if (write) {
if (!pkt_grow_pktlist(pd, CONFIG_CDROM_PKTCDVD_BUFFERS)) { if (!pkt_grow_pktlist(pd, CONFIG_CDROM_PKTCDVD_BUFFERS)) {
printk(DRIVER_NAME": not enough memory for buffers\n"); printk(DRIVER_NAME": not enough memory for buffers\n");
ret = -ENOMEM; ret = -ENOMEM;
goto out_unclaim; goto out_putdev;
} }
printk(DRIVER_NAME": %lukB available on disc\n", lba << 1); printk(DRIVER_NAME": %lukB available on disc\n", lba << 1);
} }
return 0; return 0;
out_unclaim:
bd_release(pd->bdev);
out_putdev: out_putdev:
blkdev_put(pd->bdev, FMODE_READ); blkdev_put(pd->bdev, FMODE_READ | FMODE_EXCL);
out: out:
return ret; return ret;
} }
@ -2362,8 +2357,7 @@ static void pkt_release_dev(struct pktcdvd_device *pd, int flush)
pkt_lock_door(pd, 0); pkt_lock_door(pd, 0);
pkt_set_speed(pd, MAX_SPEED, MAX_SPEED); pkt_set_speed(pd, MAX_SPEED, MAX_SPEED);
bd_release(pd->bdev); blkdev_put(pd->bdev, FMODE_READ | FMODE_EXCL);
blkdev_put(pd->bdev, FMODE_READ);
pkt_shrink_pktlist(pd); pkt_shrink_pktlist(pd);
} }
@ -2733,7 +2727,7 @@ static int pkt_new_dev(struct pktcdvd_device *pd, dev_t dev)
bdev = bdget(dev); bdev = bdget(dev);
if (!bdev) if (!bdev)
return -ENOMEM; return -ENOMEM;
ret = blkdev_get(bdev, FMODE_READ | FMODE_NDELAY); ret = blkdev_get(bdev, FMODE_READ | FMODE_NDELAY, NULL);
if (ret) if (ret)
return ret; return ret;

14
drivers/char/raw.c
View File

@ -65,15 +65,12 @@ static int raw_open(struct inode *inode, struct file *filp)
if (!bdev) if (!bdev)
goto out; goto out;
igrab(bdev->bd_inode); igrab(bdev->bd_inode);
err = blkdev_get(bdev, filp->f_mode); err = blkdev_get(bdev, filp->f_mode | FMODE_EXCL, raw_open);
if (err) if (err)
goto out; goto out;
err = bd_claim(bdev, raw_open);
if (err)
goto out1;
err = set_blocksize(bdev, bdev_logical_block_size(bdev)); err = set_blocksize(bdev, bdev_logical_block_size(bdev));
if (err) if (err)
goto out2; goto out1;
filp->f_flags |= O_DIRECT; filp->f_flags |= O_DIRECT;
filp->f_mapping = bdev->bd_inode->i_mapping; filp->f_mapping = bdev->bd_inode->i_mapping;
if (++raw_devices[minor].inuse == 1) if (++raw_devices[minor].inuse == 1)
@ -83,10 +80,8 @@ static int raw_open(struct inode *inode, struct file *filp)
mutex_unlock(&raw_mutex); mutex_unlock(&raw_mutex);
return 0; return 0;
out2:
bd_release(bdev);
out1: out1:
blkdev_put(bdev, filp->f_mode); blkdev_put(bdev, filp->f_mode | FMODE_EXCL);
out: out:
mutex_unlock(&raw_mutex); mutex_unlock(&raw_mutex);
return err; return err;
@ -110,8 +105,7 @@ static int raw_release(struct inode *inode, struct file *filp)
} }
mutex_unlock(&raw_mutex); mutex_unlock(&raw_mutex);
bd_release(bdev); blkdev_put(bdev, filp->f_mode | FMODE_EXCL);
blkdev_put(bdev, filp->f_mode);
return 0; return 0;
} }

15
drivers/md/dm-table.c
View File

@ -325,20 +325,13 @@ static int open_dev(struct dm_dev_internal *d, dev_t dev,
BUG_ON(d->dm_dev.bdev); BUG_ON(d->dm_dev.bdev);
bdev = open_by_devnum(dev, d->dm_dev.mode); bdev = open_by_devnum(dev, d->dm_dev.mode | FMODE_EXCL, _claim_ptr);
if (IS_ERR(bdev)) if (IS_ERR(bdev))
return PTR_ERR(bdev); return PTR_ERR(bdev);
r = bd_claim(bdev, _claim_ptr);
if (r) {
blkdev_put(bdev, d->dm_dev.mode);
return r;
}
r = bd_link_disk_holder(bdev, dm_disk(md)); r = bd_link_disk_holder(bdev, dm_disk(md));
if (r) { if (r) {
bd_release(bdev); blkdev_put(bdev, d->dm_dev.mode | FMODE_EXCL);
blkdev_put(bdev, d->dm_dev.mode);
return r; return r;
} }
@ -354,9 +347,7 @@ static void close_dev(struct dm_dev_internal *d, struct mapped_device *md)
if (!d->dm_dev.bdev) if (!d->dm_dev.bdev)
return; return;
bd_unlink_disk_holder(d->dm_dev.bdev); blkdev_put(d->dm_dev.bdev, d->dm_dev.mode | FMODE_EXCL);
bd_release(d->dm_dev.bdev);
blkdev_put(d->dm_dev.bdev, d->dm_dev.mode);
d->dm_dev.bdev = NULL; d->dm_dev.bdev = NULL;
} }

14
drivers/md/md.c
View File

@ -1907,7 +1907,6 @@ static void unbind_rdev_from_array(mdk_rdev_t * rdev)
MD_BUG(); MD_BUG();
return; return;
} }
bd_unlink_disk_holder(rdev->bdev);
list_del_rcu(&rdev->same_set); list_del_rcu(&rdev->same_set);
printk(KERN_INFO "md: unbind<%s>\n", bdevname(rdev->bdev,b)); printk(KERN_INFO "md: unbind<%s>\n", bdevname(rdev->bdev,b));
rdev->mddev = NULL; rdev->mddev = NULL;
@ -1935,19 +1934,13 @@ static int lock_rdev(mdk_rdev_t *rdev, dev_t dev, int shared)
struct block_device *bdev; struct block_device *bdev;
char b[BDEVNAME_SIZE]; char b[BDEVNAME_SIZE];
bdev = open_by_devnum(dev, FMODE_READ|FMODE_WRITE); bdev = open_by_devnum(dev, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
shared ? (mdk_rdev_t *)lock_rdev : rdev);
if (IS_ERR(bdev)) { if (IS_ERR(bdev)) {
printk(KERN_ERR "md: could not open %s.\n", printk(KERN_ERR "md: could not open %s.\n",
__bdevname(dev, b)); __bdevname(dev, b));
return PTR_ERR(bdev); return PTR_ERR(bdev);
} }
err = bd_claim(bdev, shared ? (mdk_rdev_t *)lock_rdev : rdev);
if (err) {
printk(KERN_ERR "md: could not bd_claim %s.\n",
bdevname(bdev, b));
blkdev_put(bdev, FMODE_READ|FMODE_WRITE);
return err;
}
if (!shared) if (!shared)
set_bit(AllReserved, &rdev->flags); set_bit(AllReserved, &rdev->flags);
rdev->bdev = bdev; rdev->bdev = bdev;
@ -1960,8 +1953,7 @@ static void unlock_rdev(mdk_rdev_t *rdev)
rdev->bdev = NULL; rdev->bdev = NULL;
if (!bdev) if (!bdev)
MD_BUG(); MD_BUG();
bd_release(bdev); blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
blkdev_put(bdev, FMODE_READ|FMODE_WRITE);
} }
void md_autodetect_dev(dev_t dev); void md_autodetect_dev(dev_t dev);

17
drivers/mtd/devices/block2mtd.c
View File

@ -224,7 +224,7 @@ static void block2mtd_free_device(struct block2mtd_dev *dev)
if (dev->blkdev) { if (dev->blkdev) {
invalidate_mapping_pages(dev->blkdev->bd_inode->i_mapping, invalidate_mapping_pages(dev->blkdev->bd_inode->i_mapping,
0, -1); 0, -1);
close_bdev_exclusive(dev->blkdev, FMODE_READ|FMODE_WRITE); blkdev_put(dev->blkdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
} }
kfree(dev); kfree(dev);
@ -234,7 +234,7 @@ static void block2mtd_free_device(struct block2mtd_dev *dev)
/* FIXME: ensure that mtd->size % erase_size == 0 */ /* FIXME: ensure that mtd->size % erase_size == 0 */
static struct block2mtd_dev *add_device(char *devname, int erase_size) static struct block2mtd_dev *add_device(char *devname, int erase_size)
{ {
const fmode_t mode = FMODE_READ | FMODE_WRITE; const fmode_t mode = FMODE_READ | FMODE_WRITE | FMODE_EXCL;
struct block_device *bdev; struct block_device *bdev;
struct block2mtd_dev *dev; struct block2mtd_dev *dev;
char *name; char *name;
@ -255,17 +255,8 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
to resolve the device name by other means. */ to resolve the device name by other means. */
dev_t devt = name_to_dev_t(devname); dev_t devt = name_to_dev_t(devname);
if (devt) { if (devt)
bdev = open_by_devnum(devt, mode); bdev = open_by_devnum(devt, mode, dev);
if (!IS_ERR(bdev)) {
int ret;
ret = bd_claim(bdev, dev);
if (ret) {
blkdev_put(bdev, mode);
bdev = ERR_PTR(ret);
}
}
}
} }
#endif #endif

2
drivers/s390/block/dasd_genhd.c
View File

@ -103,7 +103,7 @@ int dasd_scan_partitions(struct dasd_block *block)
struct block_device *bdev; struct block_device *bdev;
bdev = bdget_disk(block->gdp, 0); bdev = bdget_disk(block->gdp, 0);
if (!bdev || blkdev_get(bdev, FMODE_READ) < 0) if (!bdev || blkdev_get(bdev, FMODE_READ, NULL) < 0)
return -ENODEV; return -ENODEV;
/* /*
* See fs/partition/check.c:register_disk,rescan_partitions * See fs/partition/check.c:register_disk,rescan_partitions

151
fs/block_dev.c
View File

@ -660,7 +660,7 @@ static bool bd_may_claim(struct block_device *bdev, struct block_device *whole,
else if (bdev->bd_contains == bdev) else if (bdev->bd_contains == bdev)
return true; /* is a whole device which isn't held */ return true; /* is a whole device which isn't held */
else if (whole->bd_holder == bd_claim) else if (whole->bd_holder == bd_may_claim)
return true; /* is a partition of a device that is being partitioned */ return true; /* is a partition of a device that is being partitioned */
else if (whole->bd_holder != NULL) else if (whole->bd_holder != NULL)
return false; /* is a partition of a held device */ return false; /* is a partition of a held device */
@ -807,10 +807,10 @@ static void __bd_claim(struct block_device *bdev, struct block_device *whole,
{ {
/* note that for a whole device bd_holders /* note that for a whole device bd_holders
* will be incremented twice, and bd_holder will * will be incremented twice, and bd_holder will
* be set to bd_claim before being set to holder * be set to bd_may_claim before being set to holder
*/ */
whole->bd_holders++; whole->bd_holders++;
whole->bd_holder = bd_claim; whole->bd_holder = bd_may_claim;
bdev->bd_holders++; bdev->bd_holders++;
bdev->bd_holder = holder; bdev->bd_holder = holder;
} }
@ -835,37 +835,7 @@ static void bd_finish_claiming(struct block_device *bdev,
__bd_abort_claiming(whole, holder); /* not actually an abort */ __bd_abort_claiming(whole, holder); /* not actually an abort */
} }
/** static void bd_release(struct block_device *bdev)
* bd_claim - claim a block device
* @bdev: block device to claim
* @holder: holder trying to claim @bdev
*
* Try to claim @bdev which must have been opened successfully.
*
* CONTEXT:
* Might sleep.
*
* RETURNS:
* 0 if successful, -EBUSY if @bdev is already claimed.
*/
int bd_claim(struct block_device *bdev, void *holder)
{
struct block_device *whole = bdev->bd_contains;
int res;
might_sleep();
spin_lock(&bdev_lock);
res = bd_prepare_to_claim(bdev, whole, holder);
if (res == 0)
__bd_claim(bdev, whole, holder);
spin_unlock(&bdev_lock);
return res;
}
EXPORT_SYMBOL(bd_claim);
void bd_release(struct block_device *bdev)
{ {
spin_lock(&bdev_lock); spin_lock(&bdev_lock);
if (!--bdev->bd_contains->bd_holders) if (!--bdev->bd_contains->bd_holders)
@ -875,8 +845,6 @@ void bd_release(struct block_device *bdev)
spin_unlock(&bdev_lock); spin_unlock(&bdev_lock);
} }
EXPORT_SYMBOL(bd_release);
#ifdef CONFIG_SYSFS #ifdef CONFIG_SYSFS
static int add_symlink(struct kobject *from, struct kobject *to) static int add_symlink(struct kobject *from, struct kobject *to)
{ {
@ -943,7 +911,7 @@ out_unlock:
} }
EXPORT_SYMBOL_GPL(bd_link_disk_holder); EXPORT_SYMBOL_GPL(bd_link_disk_holder);
void bd_unlink_disk_holder(struct block_device *bdev) static void bd_unlink_disk_holder(struct block_device *bdev)
{ {
struct gendisk *disk = bdev->bd_holder_disk; struct gendisk *disk = bdev->bd_holder_disk;
@ -954,7 +922,9 @@ void bd_unlink_disk_holder(struct block_device *bdev)
del_symlink(disk->slave_dir, &part_to_dev(bdev->bd_part)->kobj); del_symlink(disk->slave_dir, &part_to_dev(bdev->bd_part)->kobj);
del_symlink(bdev->bd_part->holder_dir, &disk_to_dev(disk)->kobj); del_symlink(bdev->bd_part->holder_dir, &disk_to_dev(disk)->kobj);
} }
EXPORT_SYMBOL_GPL(bd_unlink_disk_holder); #else
static inline void bd_unlink_disk_holder(struct block_device *bdev)
{ }
#endif #endif
/* /*
@ -964,12 +934,12 @@ EXPORT_SYMBOL_GPL(bd_unlink_disk_holder);
* to be used for internal purposes. If you ever need it - reconsider * to be used for internal purposes. If you ever need it - reconsider
* your API. * your API.
*/ */
struct block_device *open_by_devnum(dev_t dev, fmode_t mode) struct block_device *open_by_devnum(dev_t dev, fmode_t mode, void *holder)
{ {
struct block_device *bdev = bdget(dev); struct block_device *bdev = bdget(dev);
int err = -ENOMEM; int err = -ENOMEM;
if (bdev) if (bdev)
err = blkdev_get(bdev, mode); err = blkdev_get(bdev, mode, holder);
return err ? ERR_PTR(err) : bdev; return err ? ERR_PTR(err) : bdev;
} }
@ -1235,17 +1205,37 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
return ret; return ret;
} }
int blkdev_get(struct block_device *bdev, fmode_t mode) int blkdev_get(struct block_device *bdev, fmode_t mode, void *holder)
{ {
return __blkdev_get(bdev, mode, 0); struct block_device *whole = NULL;
int res;
WARN_ON_ONCE((mode & FMODE_EXCL) && !holder);
if ((mode & FMODE_EXCL) && holder) {
whole = bd_start_claiming(bdev, holder);
if (IS_ERR(whole)) {
bdput(bdev);
return PTR_ERR(whole);
}
}
res = __blkdev_get(bdev, mode, 0);
if (whole) {
if (res == 0)
bd_finish_claiming(bdev, whole, holder);
else
bd_abort_claiming(whole, holder);
}
return res;
} }
EXPORT_SYMBOL(blkdev_get); EXPORT_SYMBOL(blkdev_get);
static int blkdev_open(struct inode * inode, struct file * filp) static int blkdev_open(struct inode * inode, struct file * filp)
{ {
struct block_device *whole = NULL;
struct block_device *bdev; struct block_device *bdev;
int res;
/* /*
* Preserve backwards compatibility and allow large file access * Preserve backwards compatibility and allow large file access
@ -1266,26 +1256,9 @@ static int blkdev_open(struct inode * inode, struct file * filp)
if (bdev == NULL) if (bdev == NULL)
return -ENOMEM; return -ENOMEM;
if (filp->f_mode & FMODE_EXCL) {
whole = bd_start_claiming(bdev, filp);
if (IS_ERR(whole)) {
bdput(bdev);
return PTR_ERR(whole);
}
}
filp->f_mapping = bdev->bd_inode->i_mapping; filp->f_mapping = bdev->bd_inode->i_mapping;
res = blkdev_get(bdev, filp->f_mode); return blkdev_get(bdev, filp->f_mode, filp);
if (whole) {
if (res == 0)
bd_finish_claiming(bdev, whole, filp);
else
bd_abort_claiming(whole, filp);
}
return res;
} }
static int __blkdev_put(struct block_device *bdev, fmode_t mode, int for_part) static int __blkdev_put(struct block_device *bdev, fmode_t mode, int for_part)
@ -1329,6 +1302,13 @@ static int __blkdev_put(struct block_device *bdev, fmode_t mode, int for_part)
int blkdev_put(struct block_device *bdev, fmode_t mode) int blkdev_put(struct block_device *bdev, fmode_t mode)
{ {
if (mode & FMODE_EXCL) {
mutex_lock(&bdev->bd_mutex);
bd_release(bdev);
if (!bdev->bd_holders)
bd_unlink_disk_holder(bdev);
mutex_unlock(&bdev->bd_mutex);
}
return __blkdev_put(bdev, mode, 0); return __blkdev_put(bdev, mode, 0);
} }
EXPORT_SYMBOL(blkdev_put); EXPORT_SYMBOL(blkdev_put);
@ -1336,8 +1316,7 @@ EXPORT_SYMBOL(blkdev_put);
static int blkdev_close(struct inode * inode, struct file * filp) static int blkdev_close(struct inode * inode, struct file * filp)
{ {
struct block_device *bdev = I_BDEV(filp->f_mapping->host); struct block_device *bdev = I_BDEV(filp->f_mapping->host);
if (bdev->bd_holder == filp)
bd_release(bdev);
return blkdev_put(bdev, filp->f_mode); return blkdev_put(bdev, filp->f_mode);
} }
@ -1494,55 +1473,27 @@ EXPORT_SYMBOL(lookup_bdev);
*/ */
struct block_device *open_bdev_exclusive(const char *path, fmode_t mode, void *holder) struct block_device *open_bdev_exclusive(const char *path, fmode_t mode, void *holder)
{ {
struct block_device *bdev, *whole; struct block_device *bdev;
int error; int error;
bdev = lookup_bdev(path); bdev = lookup_bdev(path);
if (IS_ERR(bdev)) if (IS_ERR(bdev))
return bdev; return bdev;
whole = bd_start_claiming(bdev, holder); error = blkdev_get(bdev, mode | FMODE_EXCL, holder);
if (IS_ERR(whole)) { if (error)
bdput(bdev); return ERR_PTR(error);
return whole;
if ((mode & FMODE_WRITE) && bdev_read_only(bdev)) {
blkdev_put(bdev, mode);
return ERR_PTR(-EACCES);
} }
error = blkdev_get(bdev, mode);
if (error)
goto out_abort_claiming;
error = -EACCES;
if ((mode & FMODE_WRITE) && bdev_read_only(bdev))
goto out_blkdev_put;
bd_finish_claiming(bdev, whole, holder);
return bdev; return bdev;
out_blkdev_put:
blkdev_put(bdev, mode);
out_abort_claiming:
bd_abort_claiming(whole, holder);
return ERR_PTR(error);
} }
EXPORT_SYMBOL(open_bdev_exclusive); EXPORT_SYMBOL(open_bdev_exclusive);
/**
* close_bdev_exclusive - close a blockdevice opened by open_bdev_exclusive()
*
* @bdev: blockdevice to close
* @mode: mode, must match that used to open.
*
* This is the counterpart to open_bdev_exclusive().
*/
void close_bdev_exclusive(struct block_device *bdev, fmode_t mode)
{
bd_release(bdev);
blkdev_put(bdev, mode);
}
EXPORT_SYMBOL(close_bdev_exclusive);
int __invalidate_device(struct block_device *bdev) int __invalidate_device(struct block_device *bdev)
{ {
struct super_block *sb = get_super(bdev); struct super_block *sb = get_super(bdev);

14
fs/btrfs/volumes.c
View File

@ -489,7 +489,7 @@ again:
continue; continue;
if (device->bdev) { if (device->bdev) {
close_bdev_exclusive(device->bdev, device->mode); blkdev_put(device->bdev, device->mode | FMODE_EXCL);
device->bdev = NULL; device->bdev = NULL;
fs_devices->open_devices--; fs_devices->open_devices--;
} }
@ -523,7 +523,7 @@ static int __btrfs_close_devices(struct btrfs_fs_devices *fs_devices)
list_for_each_entry(device, &fs_devices->devices, dev_list) { list_for_each_entry(device, &fs_devices->devices, dev_list) {
if (device->bdev) { if (device->bdev) {
close_bdev_exclusive(device->bdev, device->mode); blkdev_put(device->bdev, device->mode | FMODE_EXCL);
fs_devices->open_devices--; fs_devices->open_devices--;
} }
if (device->writeable) { if (device->writeable) {
@ -638,7 +638,7 @@ static int __btrfs_open_devices(struct btrfs_fs_devices *fs_devices,
error_brelse: error_brelse:
brelse(bh); brelse(bh);
error_close: error_close:
close_bdev_exclusive(bdev, flags); blkdev_put(bdev, flags | FMODE_EXCL);
error: error:
continue; continue;
} }
@ -716,7 +716,7 @@ int btrfs_scan_one_device(const char *path, fmode_t flags, void *holder,
brelse(bh); brelse(bh);
error_close: error_close:
close_bdev_exclusive(bdev, flags); blkdev_put(bdev, flags | FMODE_EXCL);
error: error:
mutex_unlock(&uuid_mutex); mutex_unlock(&uuid_mutex);
return ret; return ret;
@ -1244,7 +1244,7 @@ int btrfs_rm_device(struct btrfs_root *root, char *device_path)
root->fs_info->fs_devices->latest_bdev = next_device->bdev; root->fs_info->fs_devices->latest_bdev = next_device->bdev;
if (device->bdev) { if (device->bdev) {
close_bdev_exclusive(device->bdev, device->mode); blkdev_put(device->bdev, device->mode | FMODE_EXCL);
device->bdev = NULL; device->bdev = NULL;
device->fs_devices->open_devices--; device->fs_devices->open_devices--;
} }
@ -1287,7 +1287,7 @@ error_brelse:
brelse(bh); brelse(bh);
error_close: error_close:
if (bdev) if (bdev)
close_bdev_exclusive(bdev, FMODE_READ); blkdev_put(bdev, FMODE_READ | FMODE_EXCL);
out: out:
mutex_unlock(&root->fs_info->volume_mutex); mutex_unlock(&root->fs_info->volume_mutex);
mutex_unlock(&uuid_mutex); mutex_unlock(&uuid_mutex);
@ -1565,7 +1565,7 @@ out:
mutex_unlock(&root->fs_info->volume_mutex); mutex_unlock(&root->fs_info->volume_mutex);
return ret; return ret;
error: error:
close_bdev_exclusive(bdev, 0); blkdev_put(bdev, FMODE_EXCL);
if (seeding_dev) { if (seeding_dev) {
mutex_unlock(&uuid_mutex); mutex_unlock(&uuid_mutex);
up_write(&sb->s_umount); up_write(&sb->s_umount);

12
fs/ext3/super.c
View File

@ -347,7 +347,7 @@ static struct block_device *ext3_blkdev_get(dev_t dev, struct super_block *sb)
struct block_device *bdev; struct block_device *bdev;
char b[BDEVNAME_SIZE]; char b[BDEVNAME_SIZE];
bdev = open_by_devnum(dev, FMODE_READ|FMODE_WRITE); bdev = open_by_devnum(dev, FMODE_READ|FMODE_WRITE|FMODE_EXCL, sb);
if (IS_ERR(bdev)) if (IS_ERR(bdev))
goto fail; goto fail;
return bdev; return bdev;
@ -364,8 +364,7 @@ fail:
*/ */
static int ext3_blkdev_put(struct block_device *bdev) static int ext3_blkdev_put(struct block_device *bdev)
{ {
bd_release(bdev); return blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
return blkdev_put(bdev, FMODE_READ|FMODE_WRITE);
} }
static int ext3_blkdev_remove(struct ext3_sb_info *sbi) static int ext3_blkdev_remove(struct ext3_sb_info *sbi)
@ -2136,13 +2135,6 @@ static journal_t *ext3_get_dev_journal(struct super_block *sb,
if (bdev == NULL) if (bdev == NULL)
return NULL; return NULL;
if (bd_claim(bdev, sb)) {
ext3_msg(sb, KERN_ERR,
"error: failed to claim external journal device");
blkdev_put(bdev, FMODE_READ|FMODE_WRITE);
return NULL;
}
blocksize = sb->s_blocksize; blocksize = sb->s_blocksize;
hblock = bdev_logical_block_size(bdev); hblock = bdev_logical_block_size(bdev);
if (blocksize < hblock) { if (blocksize < hblock) {

12
fs/ext4/super.c
View File

@ -647,7 +647,7 @@ static struct block_device *ext4_blkdev_get(dev_t dev, struct super_block *sb)
struct block_device *bdev; struct block_device *bdev;
char b[BDEVNAME_SIZE]; char b[BDEVNAME_SIZE];
bdev = open_by_devnum(dev, FMODE_READ|FMODE_WRITE); bdev = open_by_devnum(dev, FMODE_READ|FMODE_WRITE|FMODE_EXCL, sb);
if (IS_ERR(bdev)) if (IS_ERR(bdev))
goto fail; goto fail;
return bdev; return bdev;
@ -663,8 +663,7 @@ fail:
*/ */
static int ext4_blkdev_put(struct block_device *bdev) static int ext4_blkdev_put(struct block_device *bdev)
{ {
bd_release(bdev); return blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
return blkdev_put(bdev, FMODE_READ|FMODE_WRITE);
} }
static int ext4_blkdev_remove(struct ext4_sb_info *sbi) static int ext4_blkdev_remove(struct ext4_sb_info *sbi)
@ -3758,13 +3757,6 @@ static journal_t *ext4_get_dev_journal(struct super_block *sb,
if (bdev == NULL) if (bdev == NULL)
return NULL; return NULL;
if (bd_claim(bdev, sb)) {
ext4_msg(sb, KERN_ERR,
"failed to claim external journal device");
blkdev_put(bdev, FMODE_READ|FMODE_WRITE);
return NULL;
}
blocksize = sb->s_blocksize; blocksize = sb->s_blocksize;
hblock = bdev_logical_block_size(bdev); hblock = bdev_logical_block_size(bdev);
if (blocksize < hblock) { if (blocksize < hblock) {

4
fs/gfs2/ops_fstype.c
View File

@ -1298,7 +1298,7 @@ static struct dentry *gfs2_mount(struct file_system_type *fs_type, int flags,
goto error_bdev; goto error_bdev;
if (s->s_root) if (s->s_root)
close_bdev_exclusive(bdev, mode); blkdev_put(bdev, mode | FMODE_EXCL);
memset(&args, 0, sizeof(args)); memset(&args, 0, sizeof(args));
args.ar_quota = GFS2_QUOTA_DEFAULT; args.ar_quota = GFS2_QUOTA_DEFAULT;
@ -1342,7 +1342,7 @@ error_super:
deactivate_locked_super(s); deactivate_locked_super(s);
return ERR_PTR(error); return ERR_PTR(error);
error_bdev: error_bdev:
close_bdev_exclusive(bdev, mode); blkdev_put(bdev, mode | FMODE_EXCL);
return ERR_PTR(error); return ERR_PTR(error);
} }

17
fs/jfs/jfs_logmgr.c
View File

@ -1120,16 +1120,13 @@ int lmLogOpen(struct super_block *sb)
* file systems to log may have n-to-1 relationship; * file systems to log may have n-to-1 relationship;
*/ */
bdev = open_by_devnum(sbi->logdev, FMODE_READ|FMODE_WRITE); bdev = open_by_devnum(sbi->logdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL,
log);
if (IS_ERR(bdev)) { if (IS_ERR(bdev)) {
rc = -PTR_ERR(bdev); rc = -PTR_ERR(bdev);
goto free; goto free;
} }
if ((rc = bd_claim(bdev, log))) {
goto close;
}
log->bdev = bdev; log->bdev = bdev;
memcpy(log->uuid, sbi->loguuid, sizeof(log->uuid)); memcpy(log->uuid, sbi->loguuid, sizeof(log->uuid));
@ -1137,7 +1134,7 @@ int lmLogOpen(struct super_block *sb)
* initialize log: * initialize log:
*/ */
if ((rc = lmLogInit(log))) if ((rc = lmLogInit(log)))
goto unclaim; goto close;
list_add(&log->journal_list, &jfs_external_logs); list_add(&log->journal_list, &jfs_external_logs);
@ -1163,11 +1160,8 @@ journal_found:
list_del(&log->journal_list); list_del(&log->journal_list);
lbmLogShutdown(log); lbmLogShutdown(log);
unclaim:
bd_release(bdev);
close: /* close external log device */ close: /* close external log device */
blkdev_put(bdev, FMODE_READ|FMODE_WRITE); blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
free: /* free log descriptor */ free: /* free log descriptor */
mutex_unlock(&jfs_log_mutex); mutex_unlock(&jfs_log_mutex);
@ -1512,8 +1506,7 @@ int lmLogClose(struct super_block *sb)
bdev = log->bdev; bdev = log->bdev;
rc = lmLogShutdown(log); rc = lmLogShutdown(log);
bd_release(bdev); blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
blkdev_put(bdev, FMODE_READ|FMODE_WRITE);
kfree(log); kfree(log);

4
fs/logfs/dev_bdev.c
View File

@ -300,7 +300,7 @@ static int bdev_write_sb(struct super_block *sb, struct page *page)
static void bdev_put_device(struct logfs_super *s) static void bdev_put_device(struct logfs_super *s)
{ {
close_bdev_exclusive(s->s_bdev, FMODE_READ|FMODE_WRITE); blkdev_put(s->s_bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
} }
static int bdev_can_write_buf(struct super_block *sb, u64 ofs) static int bdev_can_write_buf(struct super_block *sb, u64 ofs)
@ -331,7 +331,7 @@ int logfs_get_sb_bdev(struct logfs_super *p, struct file_system_type *type,
if (MAJOR(bdev->bd_dev) == MTD_BLOCK_MAJOR) { if (MAJOR(bdev->bd_dev) == MTD_BLOCK_MAJOR) {
int mtdnr = MINOR(bdev->bd_dev); int mtdnr = MINOR(bdev->bd_dev);
close_bdev_exclusive(bdev, FMODE_READ|FMODE_WRITE); blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
return logfs_get_sb_mtd(p, mtdnr); return logfs_get_sb_mtd(p, mtdnr);
} }

4
fs/nilfs2/super.c
View File

@ -1233,7 +1233,7 @@ nilfs_mount(struct file_system_type *fs_type, int flags,
} }
if (!s_new) if (!s_new)
close_bdev_exclusive(sd.bdev, mode); blkdev_put(sd.bdev, mode | FMODE_EXCL);
return root_dentry; return root_dentry;
@ -1242,7 +1242,7 @@ nilfs_mount(struct file_system_type *fs_type, int flags,
failed: failed:
if (!s_new) if (!s_new)
close_bdev_exclusive(sd.bdev, mode); blkdev_put(sd.bdev, mode | FMODE_EXCL);
return ERR_PTR(err); return ERR_PTR(err);
} }

2
fs/ocfs2/cluster/heartbeat.c
View File

@ -1674,7 +1674,7 @@ static ssize_t o2hb_region_dev_write(struct o2hb_region *reg,
goto out; goto out;
reg->hr_bdev = I_BDEV(filp->f_mapping->host); reg->hr_bdev = I_BDEV(filp->f_mapping->host);
ret = blkdev_get(reg->hr_bdev, FMODE_WRITE | FMODE_READ); ret = blkdev_get(reg->hr_bdev, FMODE_WRITE | FMODE_READ, NULL);
if (ret) { if (ret) {
reg->hr_bdev = NULL; reg->hr_bdev = NULL;
goto out; goto out;

2
fs/partitions/check.c
View File

@ -549,7 +549,7 @@ void register_disk(struct gendisk *disk)
goto exit; goto exit;
bdev->bd_invalidated = 1; bdev->bd_invalidated = 1;
err = blkdev_get(bdev, FMODE_READ); err = blkdev_get(bdev, FMODE_READ, NULL);
if (err < 0) if (err < 0)
goto exit; goto exit;
blkdev_put(bdev, FMODE_READ); blkdev_put(bdev, FMODE_READ);

17
fs/reiserfs/journal.c
View File

@ -2552,8 +2552,6 @@ static int release_journal_dev(struct super_block *super,
result = 0; result = 0;
if (journal->j_dev_bd != NULL) { if (journal->j_dev_bd != NULL) {
if (journal->j_dev_bd->bd_dev != super->s_dev)
bd_release(journal->j_dev_bd);
result = blkdev_put(journal->j_dev_bd, journal->j_dev_mode); result = blkdev_put(journal->j_dev_bd, journal->j_dev_mode);
journal->j_dev_bd = NULL; journal->j_dev_bd = NULL;
} }
@ -2571,7 +2569,7 @@ static int journal_init_dev(struct super_block *super,
{ {
int result; int result;
dev_t jdev; dev_t jdev;
fmode_t blkdev_mode = FMODE_READ | FMODE_WRITE; fmode_t blkdev_mode = FMODE_READ | FMODE_WRITE | FMODE_EXCL;
char b[BDEVNAME_SIZE]; char b[BDEVNAME_SIZE];
result = 0; result = 0;
@ -2585,7 +2583,9 @@ static int journal_init_dev(struct super_block *super,
/* there is no "jdev" option and journal is on separate device */ /* there is no "jdev" option and journal is on separate device */
if ((!jdev_name || !jdev_name[0])) { if ((!jdev_name || !jdev_name[0])) {
journal->j_dev_bd = open_by_devnum(jdev, blkdev_mode); if (jdev == super->s_dev)
blkdev_mode &= ~FMODE_EXCL;
journal->j_dev_bd = open_by_devnum(jdev, blkdev_mode, journal);
journal->j_dev_mode = blkdev_mode; journal->j_dev_mode = blkdev_mode;
if (IS_ERR(journal->j_dev_bd)) { if (IS_ERR(journal->j_dev_bd)) {
result = PTR_ERR(journal->j_dev_bd); result = PTR_ERR(journal->j_dev_bd);
@ -2594,15 +2594,8 @@ static int journal_init_dev(struct super_block *super,
"cannot init journal device '%s': %i", "cannot init journal device '%s': %i",
__bdevname(jdev, b), result); __bdevname(jdev, b), result);
return result; return result;
} else if (jdev != super->s_dev) { } else if (jdev != super->s_dev)
result = bd_claim(journal->j_dev_bd, journal);
if (result) {
blkdev_put(journal->j_dev_bd, blkdev_mode);
return result;
}
set_blocksize(journal->j_dev_bd, super->s_blocksize); set_blocksize(journal->j_dev_bd, super->s_blocksize);
}
return 0; return 0;
} }

14
fs/super.c
View File

@ -801,13 +801,13 @@ struct dentry *mount_bdev(struct file_system_type *fs_type,
/* /*
* s_umount nests inside bd_mutex during * s_umount nests inside bd_mutex during
* __invalidate_device(). close_bdev_exclusive() * __invalidate_device(). blkdev_put() acquires
* acquires bd_mutex and can't be called under * bd_mutex and can't be called under s_umount. Drop
* s_umount. Drop s_umount temporarily. This is safe * s_umount temporarily. This is safe as we're
* as we're holding an active reference. * holding an active reference.
*/ */
up_write(&s->s_umount); up_write(&s->s_umount);
close_bdev_exclusive(bdev, mode); blkdev_put(bdev, mode | FMODE_EXCL);
down_write(&s->s_umount); down_write(&s->s_umount);
} else { } else {
char b[BDEVNAME_SIZE]; char b[BDEVNAME_SIZE];
@ -831,7 +831,7 @@ struct dentry *mount_bdev(struct file_system_type *fs_type,
error_s: error_s:
error = PTR_ERR(s); error = PTR_ERR(s);
error_bdev: error_bdev:
close_bdev_exclusive(bdev, mode); blkdev_put(bdev, mode | FMODE_EXCL);
error: error:
return ERR_PTR(error); return ERR_PTR(error);
} }
@ -862,7 +862,7 @@ void kill_block_super(struct super_block *sb)
bdev->bd_super = NULL; bdev->bd_super = NULL;
generic_shutdown_super(sb); generic_shutdown_super(sb);
sync_blockdev(bdev); sync_blockdev(bdev);
close_bdev_exclusive(bdev, mode); blkdev_put(bdev, mode | FMODE_EXCL);
} }
EXPORT_SYMBOL(kill_block_super); EXPORT_SYMBOL(kill_block_super);

2
fs/xfs/linux-2.6/xfs_super.c
View File

@ -623,7 +623,7 @@ xfs_blkdev_put(
struct block_device *bdev) struct block_device *bdev)
{ {
if (bdev) if (bdev)
close_bdev_exclusive(bdev, FMODE_READ|FMODE_WRITE); blkdev_put(bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL);
} }
/* /*

14
include/linux/fs.h
View File

@ -2006,7 +2006,8 @@ extern struct block_device *bdgrab(struct block_device *bdev);
extern void bd_set_size(struct block_device *, loff_t size); extern void bd_set_size(struct block_device *, loff_t size);
extern void bd_forget(struct inode *inode); extern void bd_forget(struct inode *inode);
extern void bdput(struct block_device *); extern void bdput(struct block_device *);
extern struct block_device *open_by_devnum(dev_t, fmode_t); extern struct block_device *open_by_devnum(dev_t dev, fmode_t mode,
void *holder);
extern void invalidate_bdev(struct block_device *); extern void invalidate_bdev(struct block_device *);
extern int sync_blockdev(struct block_device *bdev); extern int sync_blockdev(struct block_device *bdev);
extern struct super_block *freeze_bdev(struct block_device *); extern struct super_block *freeze_bdev(struct block_device *);
@ -2037,22 +2038,16 @@ extern const struct file_operations def_fifo_fops;
extern int ioctl_by_bdev(struct block_device *, unsigned, unsigned long); extern int ioctl_by_bdev(struct block_device *, unsigned, unsigned long);
extern int blkdev_ioctl(struct block_device *, fmode_t, unsigned, unsigned long); extern int blkdev_ioctl(struct block_device *, fmode_t, unsigned, unsigned long);
extern long compat_blkdev_ioctl(struct file *, unsigned, unsigned long); extern long compat_blkdev_ioctl(struct file *, unsigned, unsigned long);
extern int blkdev_get(struct block_device *, fmode_t); extern int blkdev_get(struct block_device *bdev, fmode_t mode, void *holder);
extern int blkdev_put(struct block_device *, fmode_t); extern int blkdev_put(struct block_device *bdev, fmode_t mode);
extern int bd_claim(struct block_device *, void *);
extern void bd_release(struct block_device *);
#ifdef CONFIG_SYSFS #ifdef CONFIG_SYSFS
extern int bd_link_disk_holder(struct block_device *bdev, struct gendisk *disk); extern int bd_link_disk_holder(struct block_device *bdev, struct gendisk *disk);
extern void bd_unlink_disk_holder(struct block_device *bdev);
#else #else
static inline int bd_link_disk_holder(struct block_device *bdev, static inline int bd_link_disk_holder(struct block_device *bdev,
struct gendisk *disk) struct gendisk *disk)
{ {
return 0; return 0;
} }
static inline void bd_unlink_disk_holder(struct block_device *bdev)
{
}
#endif #endif
#endif #endif
@ -2089,7 +2084,6 @@ extern const char *__bdevname(dev_t, char *buffer);
extern const char *bdevname(struct block_device *bdev, char *buffer); extern const char *bdevname(struct block_device *bdev, char *buffer);
extern struct block_device *lookup_bdev(const char *); extern struct block_device *lookup_bdev(const char *);
extern struct block_device *open_bdev_exclusive(const char *, fmode_t, void *); extern struct block_device *open_bdev_exclusive(const char *, fmode_t, void *);
extern void close_bdev_exclusive(struct block_device *, fmode_t);
extern void blkdev_show(struct seq_file *,off_t); extern void blkdev_show(struct seq_file *,off_t);
#else #else

5
kernel/power/swap.c
View File

@ -223,7 +223,7 @@ static int swsusp_swap_check(void)
return res; return res;
root_swap = res; root_swap = res;
res = blkdev_get(hib_resume_bdev, FMODE_WRITE); res = blkdev_get(hib_resume_bdev, FMODE_WRITE, NULL);
if (res) if (res)
return res; return res;
@ -907,7 +907,8 @@ int swsusp_check(void)
{ {
int error; int error;
hib_resume_bdev = open_by_devnum(swsusp_resume_device, FMODE_READ); hib_resume_bdev = open_by_devnum(swsusp_resume_device,
FMODE_READ, NULL);
if (!IS_ERR(hib_resume_bdev)) { if (!IS_ERR(hib_resume_bdev)) {
set_blocksize(hib_resume_bdev, PAGE_SIZE); set_blocksize(hib_resume_bdev, PAGE_SIZE);
clear_page(swsusp_header); clear_page(swsusp_header);

7
mm/swapfile.c
View File

@ -1677,7 +1677,7 @@ SYSCALL_DEFINE1(swapoff, const char __user *, specialfile)
if (S_ISBLK(inode->i_mode)) { if (S_ISBLK(inode->i_mode)) {
struct block_device *bdev = I_BDEV(inode); struct block_device *bdev = I_BDEV(inode);
set_blocksize(bdev, p->old_block_size); set_blocksize(bdev, p->old_block_size);
bd_release(bdev); blkdev_put(bdev, FMODE_READ | FMODE_WRITE | FMODE_EXCL);
} else { } else {
mutex_lock(&inode->i_mutex); mutex_lock(&inode->i_mutex);
inode->i_flags &= ~S_SWAPFILE; inode->i_flags &= ~S_SWAPFILE;
@ -1939,7 +1939,8 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
error = -EINVAL; error = -EINVAL;
if (S_ISBLK(inode->i_mode)) { if (S_ISBLK(inode->i_mode)) {
bdev = I_BDEV(inode); bdev = I_BDEV(inode);
error = bd_claim(bdev, sys_swapon); error = blkdev_get(bdev, FMODE_READ | FMODE_WRITE | FMODE_EXCL,
sys_swapon);
if (error < 0) { if (error < 0) {
bdev = NULL; bdev = NULL;
error = -EINVAL; error = -EINVAL;
@ -2136,7 +2137,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
bad_swap: bad_swap:
if (bdev) { if (bdev) {
set_blocksize(bdev, p->old_block_size); set_blocksize(bdev, p->old_block_size);
bd_release(bdev); blkdev_put(bdev, FMODE_READ | FMODE_WRITE | FMODE_EXCL);
} }
destroy_swap_extents(p); destroy_swap_extents(p);
swap_cgroup_swapoff(type); swap_cgroup_swapoff(type);