mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-29 23:53:55 +08:00
ALSA: bebob: remove an unnecessary condition in hwdep_read()
Drivers in ALSA firewire stack supports eventing to userspace applications via ALSA hwdep interface. All of the drivers supports stream lock events. Some of them supports their unique events according to specification of target device. ALSA bebob driver supports the stream lock event only. In the case, it's enough to check condition only in loop with process blocking. However, current implementation check it again after breaking the loop. This commit removes the redundant check. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Reported-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp> Link: https://lore.kernel.org/r/20210125140208.26318-1-o-takashi@sakamocchi.jp Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
parent
f4514249d6
commit
e32da5eb62
@ -37,11 +37,9 @@ hwdep_read(struct snd_hwdep *hwdep, char __user *buf, long count,
|
|||||||
|
|
||||||
memset(&event, 0, sizeof(event));
|
memset(&event, 0, sizeof(event));
|
||||||
count = min_t(long, count, sizeof(event.lock_status));
|
count = min_t(long, count, sizeof(event.lock_status));
|
||||||
if (bebob->dev_lock_changed) {
|
event.lock_status.type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS;
|
||||||
event.lock_status.type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS;
|
event.lock_status.status = (bebob->dev_lock_count > 0);
|
||||||
event.lock_status.status = (bebob->dev_lock_count > 0);
|
bebob->dev_lock_changed = false;
|
||||||
bebob->dev_lock_changed = false;
|
|
||||||
}
|
|
||||||
|
|
||||||
spin_unlock_irq(&bebob->lock);
|
spin_unlock_irq(&bebob->lock);
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user