renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-03 19:24:02 +08:00
Code

media: cx88: Fix some error handling path in 'cx8800_initdev()'

Browse Source 
A call to 'pci_disable_device()' is missing in the error handling path.
In some cases, a call to 'free_irq()' may also be missing.

Reorder the error handling path, add some new labels and fix the 2 issues
mentionned above.

This way, the error handling path in more in line with 'cx8800_finidev()'
(i.e. the remove function)

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Christophe JAILLET 2019-09-22 04:41:23 -03:00 committed by Mauro Carvalho Chehab
parent 2eca8e4c1d
commit e1444e9b04
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/media/pci/cx88/cx88-video.c
View File

@ -1277,7 +1277,7 @@ static int cx8800_initdev(struct pci_dev *pci_dev,
core = cx88_core_get(dev->pci); core = cx88_core_get(dev->pci);
if (!core) { if (!core) {
err = -EINVAL; err = -EINVAL;
goto fail_free; goto fail_disable;
} }
dev->core = core; dev->core = core;
@ -1323,7 +1323,7 @@ static int cx8800_initdev(struct pci_dev *pci_dev,
cc->step, cc->default_value); cc->step, cc->default_value);
if (!vc) { if (!vc) {
err = core->audio_hdl.error; err = core->audio_hdl.error;
goto fail_core; goto fail_irq;
} }
vc->priv = (void *)cc; vc->priv = (void *)cc;
} }
@ -1337,7 +1337,7 @@ static int cx8800_initdev(struct pci_dev *pci_dev,
cc->step, cc->default_value); cc->step, cc->default_value);
if (!vc) { if (!vc) {
err = core->video_hdl.error; err = core->video_hdl.error;
goto fail_core; goto fail_irq;
} }
vc->priv = (void *)cc; vc->priv = (void *)cc;
if (vc->id == V4L2_CID_CHROMA_AGC) if (vc->id == V4L2_CID_CHROMA_AGC)
@ -1509,11 +1509,14 @@ static int cx8800_initdev(struct pci_dev *pci_dev,
fail_unreg: fail_unreg:
cx8800_unregister_video(dev); cx8800_unregister_video(dev);
free_irq(pci_dev->irq, dev);
mutex_unlock(&core->lock); mutex_unlock(&core->lock);
fail_irq:
free_irq(pci_dev->irq, dev);
fail_core: fail_core:
core->v4ldev = NULL; core->v4ldev = NULL;
cx88_core_put(core, dev->pci); cx88_core_put(core, dev->pci);
fail_disable:
pci_disable_device(pci_dev);
fail_free: fail_free:
kfree(dev); kfree(dev);
return err; return err;