renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-27 22:53:55 +08:00
Code

xfs: validate feature support when recovering rmap/refcount intents

Browse Source 
The rmap, and refcount log intent items were added to support the rmap
and reflink features.  Because these features come with changes to the
ondisk format, the log items aren't tied to a log incompat flag.

However, the log recovery routines don't actually check for those
feature flags.  The kernel has no business replayng an intent item for a
feature that isn't enabled, so check that as part of recovered log item
validation.  (Note that kernels pre-dating rmap and reflink already fail
log recovery on the unknown log item type code.)

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
This commit is contained in:
Darrick J. Wong 2020-11-29 16:33:39 -08:00
parent 7396c7fbe0
commit da5de11029
2 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/xfs/xfs_refcount_item.c
View File

@ -423,6 +423,9 @@ xfs_cui_validate_phys(
struct xfs_mount *mp, struct xfs_mount *mp,
struct xfs_phys_extent *refc) struct xfs_phys_extent *refc)
{ {
if (!xfs_sb_version_hasreflink(&mp->m_sb))
return false;
if (refc->pe_flags & ~XFS_REFCOUNT_EXTENT_FLAGS) if (refc->pe_flags & ~XFS_REFCOUNT_EXTENT_FLAGS)
return false; return false;

3
fs/xfs/xfs_rmap_item.c
View File

@ -466,6 +466,9 @@ xfs_rui_validate_map(
struct xfs_mount *mp, struct xfs_mount *mp,
struct xfs_map_extent *rmap) struct xfs_map_extent *rmap)
{ {
if (!xfs_sb_version_hasrmapbt(&mp->m_sb))
return false;
if (rmap->me_flags & ~XFS_RMAP_EXTENT_FLAGS) if (rmap->me_flags & ~XFS_RMAP_EXTENT_FLAGS)
return false; return false;