mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-16 09:13:55 +08:00
pstore: Make default pstorefs root dir perms 0750
Currently only DMESG and CONSOLE record types are protected, and it isn't obvious that they are using a capability check. Instead switch to explicit root directory mode of 0750 to keep files private by default. This will allow the removal of the capability check, which was non-obvious and forces a process to have possibly too much privilege when simple post-boot chgrp for readers would be possible without it. Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
This commit is contained in:
parent
520eccdfe1
commit
d7caa33687
@ -471,7 +471,7 @@ static int pstore_fill_super(struct super_block *sb, void *data, int silent)
|
||||
|
||||
inode = pstore_get_inode(sb);
|
||||
if (inode) {
|
||||
inode->i_mode = S_IFDIR | 0755;
|
||||
inode->i_mode = S_IFDIR | 0750;
|
||||
inode->i_op = &pstore_dir_inode_operations;
|
||||
inode->i_fop = &simple_dir_operations;
|
||||
inc_nlink(inode);
|
||||
|
Loading…
Reference in New Issue
Block a user