2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-25 05:34:00 +08:00

target/iscsi: precedence bug in iscsit_set_dataout_sequence_values()

Clang warns about this bug:
drivers/target/iscsi/iscsi_target_erl0.c:52:45: warning: operator '?:'
	has lower precedence than '+'; '+' will be evaluated first
	[-Wparentheses]

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
This commit is contained in:
Dan Carpenter 2012-10-02 11:22:48 +03:00 committed by Nicholas Bellinger
parent 232ebe34e1
commit d7ca663c77

View File

@ -48,9 +48,9 @@ void iscsit_set_dataout_sequence_values(
if (cmd->unsolicited_data) { if (cmd->unsolicited_data) {
cmd->seq_start_offset = cmd->write_data_done; cmd->seq_start_offset = cmd->write_data_done;
cmd->seq_end_offset = (cmd->write_data_done + cmd->seq_end_offset = (cmd->write_data_done +
(cmd->se_cmd.data_length > ((cmd->se_cmd.data_length >
conn->sess->sess_ops->FirstBurstLength) ? conn->sess->sess_ops->FirstBurstLength) ?
conn->sess->sess_ops->FirstBurstLength : cmd->se_cmd.data_length); conn->sess->sess_ops->FirstBurstLength : cmd->se_cmd.data_length));
return; return;
} }