renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-16 17:23:55 +08:00
Code

sis900: generate fake MAC address if the hardware doesn't have one

Browse Source 
The attached patch modifies the sis900 driver when the MAC address
read from the hardware is invalid. As suggested, the patch now
generates a random address so that the user can go on and use
the hardware. In any case a message is also shown to warn on the
unexpected condition.
This seems to happen with newer HW implementation of the sis900
chipset, since this never came up before.

Patch is against vanilla 2.6.28 (but the driver doesn't change so often,
so it will probably apply to older/newer versions too).

See bugzilla ID 10201 and 11649 and ignore the previous patch.

Signed-off-by: Daniele Venzano <venza@brownhat.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Daniele Venzano 2009-01-14 20:46:24 -08:00 committed by David S. Miller
parent d7e094d421
commit d1d5e6b1ce
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/sis900.c
View File

@ -509,10 +509,10 @@ static int __devinit sis900_probe(struct pci_dev *pci_dev,
else else
ret = sis900_get_mac_addr(pci_dev, net_dev); ret = sis900_get_mac_addr(pci_dev, net_dev);
if (ret == 0) { if (!ret || !is_valid_ether_addr(net_dev->dev_addr)) {
printk(KERN_WARNING "%s: Cannot read MAC address.\n", dev_name); random_ether_addr(net_dev->dev_addr);
ret = -ENODEV; printk(KERN_WARNING "%s: Unreadable or invalid MAC address,"
goto err_unmap_rx; "using random generated one\n", dev_name);
} }
/* 630ET : set the mii access mode as software-mode */ /* 630ET : set the mii access mode as software-mode */