renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-16 01:04:08 +08:00
Code

mm,generic: only flush the local TLB in ptep_set_access_flags

Browse Source 
The function ptep_set_access_flags is only ever used to upgrade
access permissions to a page. That means the only negative side
effect of not flushing remote TLBs is that other CPUs may incur
spurious page faults, if they happen to access the same address,
and still have a PTE with the old permissions cached in their
TLB.

Having another CPU maybe incur a spurious page fault is faster
than always incurring the cost of a remote TLB flush, so replace
the remote TLB flush with a purely local one.

This should be safe on every architecture that correctly
implements flush_tlb_fix_spurious_fault() to actually invalidate
the local TLB entry that caused a page fault, as well as on
architectures where the hardware invalidates TLB entries that
cause page faults.

In the unlikely event that you are hitting what appears to be
an infinite loop of page faults, and 'git bisect' took you to
this changeset, your architecture needs to implement
flush_tlb_fix_spurious_fault to actually flush the TLB entry.

Signed-off-by: Rik van Riel <riel@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Michel Lespinasse <walken@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Rik van Riel 2012-11-06 09:56:01 +00:00 committed by Mel Gorman
parent e4a1cc56e4
commit cef23d9db6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mm/pgtable-generic.c
View File

@ -12,8 +12,8 @@
#ifndef __HAVE_ARCH_PTEP_SET_ACCESS_FLAGS #ifndef __HAVE_ARCH_PTEP_SET_ACCESS_FLAGS
/* /*
* Only sets the access flags (dirty, accessed, and * Only sets the access flags (dirty, accessed), as well as write
* writable). Furthermore, we know it always gets set to a "more * permission. Furthermore, we know it always gets set to a "more
* permissive" setting, which allows most architectures to optimize * permissive" setting, which allows most architectures to optimize
* this. We return whether the PTE actually changed, which in turn * this. We return whether the PTE actually changed, which in turn
* instructs the caller to do things like update__mmu_cache. This * instructs the caller to do things like update__mmu_cache. This
@ -27,7 +27,7 @@ int ptep_set_access_flags(struct vm_area_struct *vma,
int changed = !pte_same(*ptep, entry); int changed = !pte_same(*ptep, entry);
if (changed) { if (changed) {
set_pte_at(vma->vm_mm, address, ptep, entry); set_pte_at(vma->vm_mm, address, ptep, entry);
flush_tlb_page(vma, address); flush_tlb_fix_spurious_fault(vma, address);
} }
return changed; return changed;
} }