renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-22 12:33:59 +08:00
Code

tipc: Revise comment justifying release of configuration spinlock

Browse Source 
Comment-only change to better explain why TIPC's configuration lock is
temporarily released while activating support for network interfaces,
and why the existing activation code doesn't require rework.

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
This commit is contained in:
Allan Stephens 2011-10-18 14:47:02 -04:00 committed by Paul Gortmaker
parent 5c216e1d28
commit bfec73d7e4
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
net/tipc/config.c
View File

@ -184,13 +184,12 @@ static struct sk_buff *cfg_set_own_addr(void)
" (cannot change node address once assigned)"); " (cannot change node address once assigned)");
/* /*
* Must release all spinlocks before calling start_net() because * Must temporarily release configuration spinlock while switching into
* Linux version of TIPC calls eth_media_start() which calls * networking mode as it calls tipc_eth_media_start(), which may sleep.
* register_netdevice_notifier() which may block! * Releasing the lock is harmless as other locally-issued configuration
* * commands won't occur until this one completes, and remotely-issued
* Temporarily releasing the lock should be harmless for non-Linux TIPC, * configuration commands can't be received until a local configuration
* but Linux version of eth_media_start() should really be reworked * command to enable the first bearer is received and processed.
* so that it can be called with spinlocks held.
*/ */
spin_unlock_bh(&config_lock); spin_unlock_bh(&config_lock);