renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-08 13:44:01 +08:00
Code

rtw88: fix shift of more than 32 bits of a integer

Browse Source 
Currently the shift of an integer value more than 32 bits can
occur when nss is more than 32.  Fix this by making the integer
constants unsigned long longs before shifting and bit-wise or'ing
with the u64 ra_mask to avoid the undefined shift behaviour.

Addresses-Coverity: ("Bad shift operation")
Fixes: e3037485c6 ("rtw88: new Realtek 802.11ac driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
This commit is contained in:
Colin Ian King 2019-05-01 15:19:45 +01:00 committed by Kalle Valo
parent 5a489b99ec
commit b85bd9a14c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/wireless/realtek/rtw88/main.c
View File

@ -363,13 +363,13 @@ static u64 get_vht_ra_mask(struct ieee80211_sta *sta)
vht_mcs_cap = mcs_map & 0x3;
switch (vht_mcs_cap) {
case 2: /* MCS9 */
ra_mask |= 0x3ff << nss;
ra_mask |= 0x3ffULL << nss;
break;
case 1: /* MCS8 */
ra_mask |= 0x1ff << nss;
ra_mask |= 0x1ffULL << nss;
break;
case 0: /* MCS7 */
ra_mask |= 0x0ff << nss;
ra_mask |= 0x0ffULL << nss;
break;
default:
break;