From b2b98ea87a8d82d1100200324ace989970a92423 Mon Sep 17 00:00:00 2001 From: Jiri Kosina Date: Sun, 15 Dec 2013 18:25:26 +0100 Subject: [PATCH] HID: microsoft: no fallthrough in MS ergonomy 0xff05 usage For 0xff05 usage in MS ergonomy keyboard quirk, we are falling through and returning 0 instread of properly (because we've performed new mapping) returning 1. Fix that. Reported-by: Joe Perches Signed-off-by: Jiri Kosina --- drivers/hid/hid-microsoft.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c index 551795b7da1d..c6ef6eed3091 100644 --- a/drivers/hid/hid-microsoft.c +++ b/drivers/hid/hid-microsoft.c @@ -73,6 +73,7 @@ static int ms_ergonomy_kb_quirk(struct hid_input *hi, struct hid_usage *usage, set_bit(KEY_F16, input->keybit); set_bit(KEY_F17, input->keybit); set_bit(KEY_F18, input->keybit); + break; default: return 0; }