mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-24 13:13:57 +08:00
USB: ehci-omap.c: introduce missing kfree
Error handling code following a kzalloc should free the allocated data. The semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S <... when != x when != if (...) { <+...x...+> } ( x->f1 = E | (x->f1 == NULL || ...) | f(...,x->f1,...) ) ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
06e182911d
commit
b2b6080905
@ -558,7 +558,7 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev)
|
||||
omap = kzalloc(sizeof(*omap), GFP_KERNEL);
|
||||
if (!omap) {
|
||||
ret = -ENOMEM;
|
||||
goto err_create_hcd;
|
||||
goto err_disabled;
|
||||
}
|
||||
|
||||
hcd = usb_create_hcd(&ehci_omap_hc_driver, &pdev->dev,
|
||||
@ -653,6 +653,7 @@ err_ioremap:
|
||||
usb_put_hcd(hcd);
|
||||
|
||||
err_create_hcd:
|
||||
kfree(omap);
|
||||
err_disabled:
|
||||
err_pdata:
|
||||
return ret;
|
||||
|
Loading…
Reference in New Issue
Block a user