renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-15 08:44:14 +08:00
Code

rtc: max77686: Fix the returned value in case of error in 'max77686_rtc_read_time()'

Browse Source 
In case of error, we return 0.
This is spurious and not consistent with the other functions of the driver.
Commit e115a2bf14 has modified more than what is said in the commit
message. Reverse part of it znd return an error when needed, as it was
previously.

Fixes: e115a2bf14 ("rtc: max77686: stop validating rtc_time in .read_time")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
Christophe JAILLET 2018-11-14 00:36:45 +01:00 committed by Alexandre Belloni
parent 50c8aec421
commit b28cc6cec3
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/rtc/rtc-max77686.c
View File

@ -360,7 +360,7 @@ static int max77686_rtc_read_time(struct device *dev, struct rtc_time *tm)
out: out:
mutex_unlock(&info->lock); mutex_unlock(&info->lock);
return 0; return ret;
} }
static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm) static int max77686_rtc_set_time(struct device *dev, struct rtc_time *tm)