renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-16 01:24:08 +08:00
Code

scsi: ufs: Remove unused setup_regulators variant function

Browse Source 
Since setup_regulators variant function is not used by any vendors, simply
remove it.

Link: https://lore.kernel.org/r/20201205120041.26869-2-stanley.chu@mediatek.com
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Stanley Chu 2020-12-05 20:00:38 +08:00 committed by Martin K. Petersen
parent ca1bb061d6
commit ade921a891
2 changed files with 1 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/scsi/ufs/ufshcd.c
View File

@ -8189,16 +8189,10 @@ static int ufshcd_variant_hba_init(struct ufs_hba *hba)
goto out; goto out;
err = ufshcd_vops_init(hba); err = ufshcd_vops_init(hba);
if (err)
goto out;
err = ufshcd_vops_setup_regulators(hba, true);
if (err)
ufshcd_vops_exit(hba);
out:
if (err) if (err)
dev_err(hba->dev, "%s: variant %s init failed err %d\n", dev_err(hba->dev, "%s: variant %s init failed err %d\n",
__func__, ufshcd_get_var_name(hba), err); __func__, ufshcd_get_var_name(hba), err);
out:
return err; return err;
} }
@ -8207,8 +8201,6 @@ static void ufshcd_variant_hba_exit(struct ufs_hba *hba)
if (!hba->vops) if (!hba->vops)
return; return;
ufshcd_vops_setup_regulators(hba, false);
ufshcd_vops_exit(hba); ufshcd_vops_exit(hba);
} }

10
drivers/scsi/ufs/ufshcd.h
View File

@ -300,7 +300,6 @@ struct ufs_pwr_mode_info {
* @get_ufs_hci_version: called to get UFS HCI version * @get_ufs_hci_version: called to get UFS HCI version
* @clk_scale_notify: notifies that clks are scaled up/down * @clk_scale_notify: notifies that clks are scaled up/down
* @setup_clocks: called before touching any of the controller registers * @setup_clocks: called before touching any of the controller registers
* @setup_regulators: called before accessing the host controller
* @hce_enable_notify: called before and after HCE enable bit is set to allow * @hce_enable_notify: called before and after HCE enable bit is set to allow
* variant specific Uni-Pro initialization. * variant specific Uni-Pro initialization.
* @link_startup_notify: called before and after Link startup is carried out * @link_startup_notify: called before and after Link startup is carried out
@ -331,7 +330,6 @@ struct ufs_hba_variant_ops {
enum ufs_notify_change_status); enum ufs_notify_change_status);
int (*setup_clocks)(struct ufs_hba *, bool, int (*setup_clocks)(struct ufs_hba *, bool,
enum ufs_notify_change_status); enum ufs_notify_change_status);
int (*setup_regulators)(struct ufs_hba *, bool);
int (*hce_enable_notify)(struct ufs_hba *, int (*hce_enable_notify)(struct ufs_hba *,
enum ufs_notify_change_status); enum ufs_notify_change_status);
int (*link_startup_notify)(struct ufs_hba *, int (*link_startup_notify)(struct ufs_hba *,
@ -1121,14 +1119,6 @@ static inline int ufshcd_vops_setup_clocks(struct ufs_hba *hba, bool on,
return 0; return 0;
} }
static inline int ufshcd_vops_setup_regulators(struct ufs_hba *hba, bool status)
{
if (hba->vops && hba->vops->setup_regulators)
return hba->vops->setup_regulators(hba, status);
return 0;
}
static inline int ufshcd_vops_hce_enable_notify(struct ufs_hba *hba, static inline int ufshcd_vops_hce_enable_notify(struct ufs_hba *hba,
bool status) bool status)
{ {