renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-15 16:53:54 +08:00
Code

sunrpc: remove unnecessary svc_xprt_put

Browse Source 
The 'struct svc_deferred_req's on the xpt_deferred queue do not
own a reference to the owning xprt.  This is seen in svc_revisit
which is where things are added to this queue.  dr->xprt is set to
NULL and the reference to the xprt it put.

So when this list is cleaned up in svc_delete_xprt, we mustn't
put the reference.

Also, replace the 'for' with a 'while' which is arguably
simpler and more likely to compile efficiently.

Cc: Tom Tucker <tom@opengridcomputing.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Cc: stable@kernel.org
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
This commit is contained in:
Neil Brown 2010-02-27 09:33:40 +11:00 committed by J. Bruce Fields
parent 58255a4e3c
commit ab1b18f70a
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
net/sunrpc/svc_xprt.c
View File

@ -896,11 +896,8 @@ void svc_delete_xprt(struct svc_xprt *xprt)
if (test_bit(XPT_TEMP, &xprt->xpt_flags)) if (test_bit(XPT_TEMP, &xprt->xpt_flags))
serv->sv_tmpcnt--; serv->sv_tmpcnt--;
for (dr = svc_deferred_dequeue(xprt); dr; while ((dr = svc_deferred_dequeue(xprt)) != NULL)
dr = svc_deferred_dequeue(xprt)) {
svc_xprt_put(xprt);
kfree(dr); kfree(dr);
}
svc_xprt_put(xprt); svc_xprt_put(xprt);
spin_unlock_bh(&serv->sv_lock); spin_unlock_bh(&serv->sv_lock);