renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-16 09:13:55 +08:00
Code

gpio: exar: Use correct property prefix and document bindings

Browse Source 
The device-specific property should be prefixed with the vendor name,
not "linux,", as Linus Walleij pointed out. Change this and document the
bindings of this platform device.

We didn't ship the old binding in a release yet. So we can still change
it without breaking an official API.

Fixes: 380b1e2f3a ("gpio-exar/8250-exar: Make set of exported GPIOs configurable")
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Jan Kiszka 2017-07-19 07:31:14 +02:00 committed by Linus Walleij
parent cc9269f896
commit a589e211bd
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Documentation/devicetree/bindings/gpio/gpio-exar.txt Normal file
View File

@ -0,0 +1,5 @@
Exportable MPIO interface of Exar UART chips
Required properties of the device:
- exar,first-pin: first exportable pins (0..15)
- ngpios: number of exportable pins (1..16)

2
drivers/gpio/gpio-exar.c
View File

@ -132,7 +132,7 @@ static int gpio_exar_probe(struct platform_device *pdev)
if (!p) if (!p)
return -ENOMEM; return -ENOMEM;
ret = device_property_read_u32(&pdev->dev, "linux,first-pin", ret = device_property_read_u32(&pdev->dev, "exar,first-pin",
&first_pin); &first_pin);
if (ret) if (ret)
return ret; return ret;

4
drivers/tty/serial/8250/8250_exar.c
View File

@ -261,7 +261,7 @@ __xr17v35x_register_gpio(struct pci_dev *pcidev,
} }
static const struct property_entry exar_gpio_properties[] = { static const struct property_entry exar_gpio_properties[] = {
PROPERTY_ENTRY_U32("linux,first-pin", 0), PROPERTY_ENTRY_U32("exar,first-pin", 0),
PROPERTY_ENTRY_U32("ngpios", 16), PROPERTY_ENTRY_U32("ngpios", 16),
{ } { }
}; };
@ -326,7 +326,7 @@ static int iot2040_rs485_config(struct uart_port *port,
} }
static const struct property_entry iot2040_gpio_properties[] = { static const struct property_entry iot2040_gpio_properties[] = {
PROPERTY_ENTRY_U32("linux,first-pin", 10), PROPERTY_ENTRY_U32("exar,first-pin", 10),
PROPERTY_ENTRY_U32("ngpios", 1), PROPERTY_ENTRY_U32("ngpios", 1),
{ } { }
}; };