renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-04 11:43:54 +08:00
Code

scsi: smartpqi: correct remove scsi devices

Browse Source 
correct a problem caused by holding a spinlock during device deletion.

Reviewed-by: Scott Benesh <scott.benesh@microsemi.com>
Reviewed-by: Scott Teel <scott.teel@microsemi.com>
Signed-off-by: Kevin Barnett <kevin.barnett@microsemi.com>
Signed-off-by: Don Brace <don.brace@microsemi.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Kevin Barnett 2017-05-03 18:52:22 -05:00 committed by Martin K. Petersen
parent 30c0061c9b
commit a37ef74517
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/scsi/smartpqi/smartpqi_init.c
View File

@ -1823,19 +1823,25 @@ static void pqi_remove_all_scsi_devices(struct pqi_ctrl_info *ctrl_info)
{ {
unsigned long flags; unsigned long flags;
struct pqi_scsi_dev *device; struct pqi_scsi_dev *device;
struct pqi_scsi_dev *next;
spin_lock_irqsave(&ctrl_info->scsi_device_list_lock, flags); while (1) {
spin_lock_irqsave(&ctrl_info->scsi_device_list_lock, flags);
device = list_first_entry_or_null(&ctrl_info->scsi_device_list,
struct pqi_scsi_dev, scsi_device_list_entry);
if (device)
list_del(&device->scsi_device_list_entry);
spin_unlock_irqrestore(&ctrl_info->scsi_device_list_lock,
flags);
if (!device)
break;
list_for_each_entry_safe(device, next, &ctrl_info->scsi_device_list,
scsi_device_list_entry) {
if (device->sdev) if (device->sdev)
pqi_remove_device(ctrl_info, device); pqi_remove_device(ctrl_info, device);
list_del(&device->scsi_device_list_entry);
pqi_free_device(device); pqi_free_device(device);
} }
spin_unlock_irqrestore(&ctrl_info->scsi_device_list_lock, flags);
} }
static int pqi_scan_scsi_devices(struct pqi_ctrl_info *ctrl_info) static int pqi_scan_scsi_devices(struct pqi_ctrl_info *ctrl_info)