renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-16 01:04:08 +08:00
Code

memory: emif: Convert to DEFINE_SHOW_ATTRIBUTE

Browse Source 
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Along with this change, we get additionally:
        .owner          = THIS_MODULE,
        .llseek         = seq_lseek,

1. The llseek method is used to change the current read/write position
in a file which can be ignored if you don't use it.
2. The owner is not even a method. Instead, it is a pointer to the
module that “owns” this structure; it is used by the kernel to maintain
the module's usage count which can be ignored.

Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Link: https://lore.kernel.org/r/20200917125113.103550-1-miaoqinglang@huawei.com
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
This commit is contained in:
Qinglang Miao 2020-09-17 20:51:13 +08:00 committed by Krzysztof Kozlowski
parent 67a344e889
commit 94ca857336
1 changed files with 2 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/memory/emif.c
View File

@ -131,16 +131,7 @@ static int emif_regdump_show(struct seq_file *s, void *unused)
return 0; return 0;
} }
static int emif_regdump_open(struct inode *inode, struct file *file) DEFINE_SHOW_ATTRIBUTE(emif_regdump);
{
return single_open(file, emif_regdump_show, inode->i_private);
}
static const struct file_operations emif_regdump_fops = {
.open = emif_regdump_open,
.read = seq_read,
.release = single_release,
};
static int emif_mr4_show(struct seq_file *s, void *unused) static int emif_mr4_show(struct seq_file *s, void *unused)
{ {
@ -150,16 +141,7 @@ static int emif_mr4_show(struct seq_file *s, void *unused)
return 0; return 0;
} }
static int emif_mr4_open(struct inode *inode, struct file *file) DEFINE_SHOW_ATTRIBUTE(emif_mr4);
{
return single_open(file, emif_mr4_show, inode->i_private);
}
static const struct file_operations emif_mr4_fops = {
.open = emif_mr4_open,
.read = seq_read,
.release = single_release,
};
static int __init_or_module emif_debugfs_init(struct emif_data *emif) static int __init_or_module emif_debugfs_init(struct emif_data *emif)
{ {