renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-19 18:53:52 +08:00
Code

fs/ocfs2/dlm/dlmdebug.c: use seq_open_private() not seq_open()

Browse Source 
Reduce boilerplate code by using seq_open_private() instead of seq_open()

Signed-off-by: Rob Jones <rob.jones@codethink.co.uk>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Mark Fasheh <mfasheh@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Rob Jones 2014-10-09 15:25:05 -07:00 committed by Linus Torvalds
parent 6ae075485e
commit 8f9ac03232
1 changed files with 14 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
fs/ocfs2/dlm/dlmdebug.c
View File

@ -647,41 +647,30 @@ static const struct seq_operations debug_lockres_ops = {
static int debug_lockres_open(struct inode *inode, struct file *file) static int debug_lockres_open(struct inode *inode, struct file *file)
{ {
struct dlm_ctxt *dlm = inode->i_private; struct dlm_ctxt *dlm = inode->i_private;
int ret = -ENOMEM; struct debug_lockres *dl;
struct seq_file *seq; void *buf;
struct debug_lockres *dl = NULL;
dl = kzalloc(sizeof(struct debug_lockres), GFP_KERNEL); buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
if (!dl) { if (!buf)
mlog_errno(ret);
goto bail; goto bail;
}
dl = __seq_open_private(file, &debug_lockres_ops, sizeof(*dl));
if (!dl)
goto bailfree;
dl->dl_len = PAGE_SIZE; dl->dl_len = PAGE_SIZE;
dl->dl_buf = kmalloc(dl->dl_len, GFP_KERNEL); dl->dl_buf = buf;
if (!dl->dl_buf) {
mlog_errno(ret);
goto bail;
}
ret = seq_open(file, &debug_lockres_ops);
if (ret) {
mlog_errno(ret);
goto bail;
}
seq = file->private_data;
seq->private = dl;
dlm_grab(dlm); dlm_grab(dlm);
dl->dl_ctxt = dlm; dl->dl_ctxt = dlm;
return 0; return 0;
bailfree:
kfree(buf);
bail: bail:
if (dl) mlog_errno(-ENOMEM);
kfree(dl->dl_buf); return -ENOMEM;
kfree(dl);
return ret;
} }
static int debug_lockres_release(struct inode *inode, struct file *file) static int debug_lockres_release(struct inode *inode, struct file *file)