mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-23 12:43:55 +08:00
[media] USB: Deletion of unnecessary checks before three function calls
GIT_AUTHOR_DATE=1416486805 The functions pvr2_hdw_destroy(), rc_unregister_device() and vfree() perform also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
parent
332b295d10
commit
83f56f7cbd
@ -363,8 +363,7 @@ void au0828_rc_unregister(struct au0828_dev *dev)
|
||||
if (!ir)
|
||||
return;
|
||||
|
||||
if (ir->rc)
|
||||
rc_unregister_device(ir->rc);
|
||||
rc_unregister_device(ir->rc);
|
||||
|
||||
/* done */
|
||||
kfree(ir);
|
||||
|
@ -841,8 +841,7 @@ static int em28xx_ir_fini(struct em28xx *dev)
|
||||
if (!ir)
|
||||
goto ref_put;
|
||||
|
||||
if (ir->rc)
|
||||
rc_unregister_device(ir->rc);
|
||||
rc_unregister_device(ir->rc);
|
||||
|
||||
kfree(ir->i2c_client);
|
||||
|
||||
|
@ -80,7 +80,7 @@ static void pvr2_context_set_notify(struct pvr2_context *mp, int fl)
|
||||
static void pvr2_context_destroy(struct pvr2_context *mp)
|
||||
{
|
||||
pvr2_trace(PVR2_TRACE_CTXT,"pvr2_context %p (destroy)",mp);
|
||||
if (mp->hdw) pvr2_hdw_destroy(mp->hdw);
|
||||
pvr2_hdw_destroy(mp->hdw);
|
||||
pvr2_context_set_notify(mp, 0);
|
||||
mutex_lock(&pvr2_context_mutex);
|
||||
if (mp->exist_next) {
|
||||
|
@ -1974,8 +1974,7 @@ static int s2255_release_sys_buffers(struct s2255_vc *vc)
|
||||
{
|
||||
unsigned long i;
|
||||
for (i = 0; i < SYS_FRAMES; i++) {
|
||||
if (vc->buffer.frame[i].lpvbits)
|
||||
vfree(vc->buffer.frame[i].lpvbits);
|
||||
vfree(vc->buffer.frame[i].lpvbits);
|
||||
vc->buffer.frame[i].lpvbits = NULL;
|
||||
}
|
||||
return 0;
|
||||
|
Loading…
Reference in New Issue
Block a user