2
0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-15 08:44:14 +08:00

drivers: comedi: replace ternary operator with min()

Fix the following coccicheck warning:

drivers/comedi/drivers.c:857:12-13: WARNING opportunity for min().

min() macro is defined in include/linux/minmax.h. It avoids multiple
evaluations of the arguments when non-constant and performs strict
type-checking.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
Link: https://lore.kernel.org/r/20220513071608.49047-1-guozhengkui@vivo.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Guo Zhengkui 2022-05-13 15:16:06 +08:00 committed by Greg Kroah-Hartman
parent 7394d2ebb6
commit 80ad54a63a

View File

@ -854,7 +854,7 @@ int comedi_load_firmware(struct comedi_device *dev,
release_firmware(fw); release_firmware(fw);
} }
return ret < 0 ? ret : 0; return min(ret, 0);
} }
EXPORT_SYMBOL_GPL(comedi_load_firmware); EXPORT_SYMBOL_GPL(comedi_load_firmware);