mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-18 02:04:05 +08:00
platform: x86: asus_acpi: world-writable procfs files
Don't allow everybody to change ACPI settings. The comment says that it is done deliberatelly, however, the comment before disp_proc_write() says that at least one of these setting is experimental. Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> Signed-off-by: Matthew Garrett <mjg@redhat.com>
This commit is contained in:
parent
8a6a142c12
commit
8040835760
@ -1081,14 +1081,8 @@ static int asus_hotk_add_fs(struct acpi_device *device)
|
||||
struct proc_dir_entry *proc;
|
||||
mode_t mode;
|
||||
|
||||
/*
|
||||
* If parameter uid or gid is not changed, keep the default setting for
|
||||
* our proc entries (-rw-rw-rw-) else, it means we care about security,
|
||||
* and then set to -rw-rw----
|
||||
*/
|
||||
|
||||
if ((asus_uid == 0) && (asus_gid == 0)) {
|
||||
mode = S_IFREG | S_IRUGO | S_IWUGO;
|
||||
mode = S_IFREG | S_IRUGO | S_IWUSR | S_IWGRP;
|
||||
} else {
|
||||
mode = S_IFREG | S_IRUSR | S_IRGRP | S_IWUSR | S_IWGRP;
|
||||
printk(KERN_WARNING " asus_uid and asus_gid parameters are "
|
||||
|
Loading…
Reference in New Issue
Block a user