renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-18 18:43:59 +08:00
Code

drm/doc: Document legacy_cursor_update better

Browse Source 
It's the horror and shouldn't be used. Realized we're not clear on
this in a discussion with Rob about what msm is doing to better
support async commits.

v2: Refine existing todo item to include this (Thomas)

Cc: Sean Paul <sean@poorly.run>
Cc: Rob Clark <robdclark@gmail.com>
Acked-by: Rob Clark <robdclark@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20201023123925.2374863-3-daniel.vetter@ffwll.ch
This commit is contained in:
Daniel Vetter 2020-10-23 14:39:25 +02:00
parent 4dfec0d1d7
commit 7d18e2f3f2
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Documentation/gpu/todo.rst
View File

@ -105,6 +105,10 @@ converted over to the new infrastructure.
One issue with the helpers is that they require that drivers handle completion One issue with the helpers is that they require that drivers handle completion
events for atomic commits correctly. But fixing these bugs is good anyway. events for atomic commits correctly. But fixing these bugs is good anyway.
Somewhat related is the legacy_cursor_update hack, which should be replaced with
the new atomic_async_check/commit functionality in the helpers in drivers that
still look at that flag.
Contact: Daniel Vetter, respective driver maintainers Contact: Daniel Vetter, respective driver maintainers
Level: Advanced Level: Advanced

12
include/drm/drm_atomic.h
View File

@ -308,7 +308,6 @@ struct __drm_private_objs_state {
* struct drm_atomic_state - the global state object for atomic updates * struct drm_atomic_state - the global state object for atomic updates
* @ref: count of all references to this state (will not be freed until zero) * @ref: count of all references to this state (will not be freed until zero)
* @dev: parent DRM device * @dev: parent DRM device
* @legacy_cursor_update: hint to enforce legacy cursor IOCTL semantics
* @async_update: hint for asynchronous plane update * @async_update: hint for asynchronous plane update
* @planes: pointer to array of structures with per-plane data * @planes: pointer to array of structures with per-plane data
* @crtcs: pointer to array of CRTC pointers * @crtcs: pointer to array of CRTC pointers
@ -336,6 +335,17 @@ struct drm_atomic_state {
* drm_atomic_crtc_needs_modeset(). * drm_atomic_crtc_needs_modeset().
*/ */
bool allow_modeset : 1; bool allow_modeset : 1;
/**
* @legacy_cursor_update:
*
* Hint to enforce legacy cursor IOCTL semantics.
*
* WARNING: This is thoroughly broken and pretty much impossible to
* implement correctly. Drivers must ignore this and should instead
* implement &drm_plane_helper_funcs.atomic_async_check and
* &drm_plane_helper_funcs.atomic_async_commit hooks. New users of this
* flag are not allowed.
*/
bool legacy_cursor_update : 1; bool legacy_cursor_update : 1;
bool async_update : 1; bool async_update : 1;
/** /**