renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2024-12-15 16:53:54 +08:00
Code

scsi: elx: libefc: Fix IRQ restore in efc_domain_dispatch_frame()

Browse Source 
Calling a nested spin_lock_irqsave() will overwrite the original "flags" so
that they can not be enabled again at the end.

Link: https://lore.kernel.org/r/YMyjH16k4M1yEmmU@mwanda
Fixes: 3146240f19 ("scsi: elx: libefc: FC Domain state machine interfaces")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Dan Carpenter 2021-06-18 16:43:59 +03:00 committed by Martin K. Petersen
parent 99cf922692
commit 7cca85dff2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/scsi/elx/libefc/efc_domain.c
View File

@ -1001,10 +1001,10 @@ efc_domain_dispatch_frame(void *arg, struct efc_hw_sequence *seq)
if (node->hold_frames || !list_empty(&node->pend_frames)) {
/* add frame to node's pending list */
spin_lock_irqsave(&node->pend_frames_lock, flags);
spin_lock(&node->pend_frames_lock);
INIT_LIST_HEAD(&seq->list_entry);
list_add_tail(&seq->list_entry, &node->pend_frames);
spin_unlock_irqrestore(&node->pend_frames_lock, flags);
spin_unlock(&node->pend_frames_lock);
rc = EFC_HW_SEQ_HOLD;
goto out_release;
}