renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-23 04:54:01 +08:00
Code

mmc: sdio: improve mmc_io_rw_extended

Browse Source 
Improve mmc_io_rw_extended a little:
- using DIV_ROUND_UP achieves the same but is better readable
- simplify code by using sg_set_buf
- simplify one statement by using -= operator

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Heiner Kallweit 2017-03-22 21:59:29 +01:00 committed by Ulf Hansson
parent 474e25e15f
commit 7aceaf566e
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/mmc/core/sdio_ops.c
View File

@ -152,7 +152,7 @@ int mmc_io_rw_extended(struct mmc_card *card, int write, unsigned fn,
data.flags = write ? MMC_DATA_WRITE : MMC_DATA_READ; data.flags = write ? MMC_DATA_WRITE : MMC_DATA_READ;
left_size = data.blksz * data.blocks; left_size = data.blksz * data.blocks;
nents = (left_size - 1) / seg_size + 1; nents = DIV_ROUND_UP(left_size, seg_size);
if (nents > 1) { if (nents > 1) {
if (sg_alloc_table(&sgtable, nents, GFP_KERNEL)) if (sg_alloc_table(&sgtable, nents, GFP_KERNEL))
return -ENOMEM; return -ENOMEM;
@ -161,10 +161,9 @@ int mmc_io_rw_extended(struct mmc_card *card, int write, unsigned fn,
data.sg_len = nents; data.sg_len = nents;
for_each_sg(data.sg, sg_ptr, data.sg_len, i) { for_each_sg(data.sg, sg_ptr, data.sg_len, i) {
sg_set_page(sg_ptr, virt_to_page(buf + (i * seg_size)), sg_set_buf(sg_ptr, buf + i * seg_size,
min(seg_size, left_size), min(seg_size, left_size));
offset_in_page(buf + (i * seg_size))); left_size -= seg_size;
left_size = left_size - seg_size;
} }
} else { } else {
data.sg = &sg; data.sg = &sg;