renegade-project/linux-next
2
0
Fork 0
mirror of https://github.com/edk2-porting/linux-next.git synced 2025-01-08 21:53:54 +08:00
Code

pinctrl: pinmux: handle radix_tree_insert() errors in pinmux_generic_add_function()

Browse Source 
pinctrl_generic_add_function() doesn't check result of radix_tree_insert()
despite they both may return a negative error code.  Linus Walleij said he
has copied the radix tree code from kernel/irq/ where the functions calling
radix_tree_insert() are *void* themselves; I think it makes more sense to
propagate the errors from radix_tree_insert() upstream if we can do that...

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/20230719202253.13469-4-s.shtylyov@omp.ru
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Sergey Shtylyov 2023-07-19 23:22:53 +03:00 committed by Linus Walleij
parent ecfe9a015d
commit 6ec89cd4d1
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/pinctrl/pinmux.c
View File

@ -872,7 +872,7 @@ int pinmux_generic_add_function(struct pinctrl_dev *pctldev,
void *data) void *data)
{ {
struct function_desc *function; struct function_desc *function;
int selector; int selector, error;
if (!name) if (!name)
return -EINVAL; return -EINVAL;
@ -892,7 +892,9 @@ int pinmux_generic_add_function(struct pinctrl_dev *pctldev,
function->num_group_names = num_groups; function->num_group_names = num_groups;
function->data = data; function->data = data;
radix_tree_insert(&pctldev->pin_function_tree, selector, function); error = radix_tree_insert(&pctldev->pin_function_tree, selector, function);
if (error)
return error;
pctldev->num_functions++; pctldev->num_functions++;