mirror of
https://github.com/edk2-porting/linux-next.git
synced 2024-12-16 09:13:55 +08:00
HSI: omap_ssi: fix handling ida_simple_get result
The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> Signed-off-by: Sebastian Reichel <sre@kernel.org>
This commit is contained in:
parent
403c5c0650
commit
6bf6ded300
@ -323,11 +323,10 @@ static int __init ssi_add_controller(struct hsi_controller *ssi,
|
||||
return -ENOMEM;
|
||||
}
|
||||
|
||||
ssi->id = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL);
|
||||
if (ssi->id < 0) {
|
||||
err = ssi->id;
|
||||
err = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL);
|
||||
if (err < 0)
|
||||
goto out_err;
|
||||
}
|
||||
ssi->id = err;
|
||||
|
||||
ssi->owner = THIS_MODULE;
|
||||
ssi->device.parent = &pd->dev;
|
||||
|
Loading…
Reference in New Issue
Block a user